genirq/msi: Fix device MSI prepare/alloc sequencing
Status from this message: The following commit has been merged into the irq/msi branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 16 repliesApplied
- v14 patches 10 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | genirq/msi: Add .msi_teardown() callback as the reverse of .msi_prepare()include/ kernel/ | +16 | 0 replies | |
| 2/5 | irqchip/gic-v3-its: Implement .msi_teardown() callbackdrivers/ drivers/ kernel/ | +36 | 0 replies | |
| 3/5 | genirq/msi: Move prepare() call to per-device allocationinclude/ kernel/ | +33 | 11 replies | |
| 4/5 | genirq/msi: Engage the .msi_teardown() callback on domain removalkernel/ | +3 | 0 replies | |
| 5/5 | irqchip/gic-v3-its: Use allocation size from the prepare calldrivers/ | +0 | 5 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Zenghui Yu |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | T-b |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] genirq/msi: Fix device MSI prepare/alloc sequencing
While reviewing (and debugging) the GICv5 code, it became obvious that there was something pretty fishy about the way MSI allocation was taking place in respect to the msi_prepare() callback.
There is a strong (though not 100% explicit) requirement that the .msi_prepare() callback must take place exactly once during the lifetime of an MSI domain, before any MSI is allocated. Sadly, that's not how the core code behaves, leading to all sorts of "interesting" issues with MBIGEN or the GICv5 IWB.
The fix is both simple and surprisingly convoluted. The first course of action would be to hoist the "prepare" action before we allocate any MSI, adding new tracking for the msi_alloc_info_t structure.
But this unveils another issue that the core code has been papering over, which is that there is no pendant to the .msi_prepare() callback that would be called on irqdomain destruction, and that at least the ITS code has been using some crap heuristics to work around it.
So this needs to be addressed first, and that's the point of the first two patches, introducing and implementing the .msi_teardown() callback. The .msi_prepare() call is then moved is the specific case of device-MSI, and the .msi_teardown() callback wired up.
The last patch remove a gross hack in the ITS msi-parent code, which was papering over the broken use of the "prepare" callback.
This has been tested on a GICv4 system with MBIGEN, patches on top of tip/irq/msi (a1d8a83093675).
* From v1 [1]:
- Fixed blunder in the ITS .msi_teardown()
- Fixed spelling, grammar, and other use of unclear terms
- Fixed line splitting, disgraceful underscores
- Split the calling of .msi_teardown() into its own patch
- Rebased on top of tip/irq/msi
[1] https://lore.kernel.org/r/[email protected]
Marc Zyngier (5):
genirq/msi: Add .msi_teardown() callback as the reverse of
.msi_prepare()
irqchip/gic-v3-its: Implement .msi_teardown() callback genirq/msi: Move prepare() call to per-device allocation genirq/msi: Engage the .msi_teardown() callback on domain removal irqchip/gic-v3-its: Use allocation size from the prepare call
drivers/irqchip/irq-gic-v3-its-msi-parent.c | 29 +++++-------- drivers/irqchip/irq-gic-v3-its.c | 46 +++++++++++---------- include/linux/msi.h | 12 +++++- kernel/irq/msi.c | 45 ++++++++++++++++++-- 4 files changed, 86 insertions(+), 46 deletions(-)
Signature · 1 line
2.39.2