Skip to content

platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

Antheas Kapenekakis linux-doc linux-hwmon lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 38 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10platform/x86: msi-wmi-platform: Use input buffer for returning resultdrivers/platform/x86/msi-wmi-platform.c+26 -272 replies
2/10platform/x86: msi-wmi-platform: Add unlocked msi_wmi_platform_querydrivers/platform/x86/msi-wmi-platform.c+17 -106 replies
3/10platform/x86: msi-wmi-platform: Add quirk systemdrivers/platform/x86/msi-wmi-platform.c+45 -02 replies
4/10platform/x86: msi-wmi-platform: Add support for fan controlDocumentation/wmi/devices/msi-wmi-platform.rst drivers/platform/x86/msi-wmi-platform.c+337 -173 replies
5/10platform/x86: msi-wmi-platform: Add platform profile through shift modedrivers/platform/x86/Kconfig drivers/platform/x86/msi-wmi-platform.c+118 -04 replies
6/10platform/x86: msi-wmi-platform: Add PL1/PL2 support via firmware attributesdrivers/platform/x86/Kconfig drivers/platform/x86/msi-wmi-platform.c+360 -23 replies
7/10platform/x86: msi-wmi-platform: Add charge_threshold supportdrivers/platform/x86/Kconfig drivers/platform/x86/msi-wmi-platform.c+111 -02 replies
8/10platform/x86: msi-wmi-platform: Drop excess fans in dual fan devicesdrivers/platform/x86/msi-wmi-platform.c+25 -31 reply
9/10platform/x86: msi-wmi-platform: Update header textdrivers/platform/x86/msi-wmi-platform.c+3 -21 reply
10/10platform/x86: msi-wmi-platform: Restore fan curves on PWM disable and unloaddrivers/platform/x86/msi-wmi-platform.c+122 -12 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchArmin Wolf
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 00/10] platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

This draft patch series brings into parity the msi-wmi-platform driver with the MSI Center M Windows application for the MSI Claw (all models). Unfortunately, MSI Center M and this interface do not have a discovery API, necessitating the introduction of a quirk system.

While this patch series is fully functional and tested, there are still some issues that need to be addressed:
- Armin notes we need to disable fan curve support by default and quirk it as well, as it is not supported on all models. However, the way PWM enable ops work, this makes it a bit difficult, so I would like some suggestions on how to rework this.
- It turns out that to fully disable the fan curve, we have to restore the default fan values. This is also what is done on the OEM software. For this, the last patch in the series is used, which is a bit dirty.

Sleep was tested with all values being preserved during S0iX (platform profile, fan curve, PL1/PL2), so we do not need suspend/resume hooks, at least for the Claw devices.

For PL1/PL2, we use firmware-attributes. So for that I +cc Kurt since if his new high level interface is merged beforehand, we can use that instead.

Antheas Kapenekakis (8):
platform/x86: msi-wmi-platform: Add unlocked msi_wmi_platform_query platform/x86: msi-wmi-platform: Add quirk system platform/x86: msi-wmi-platform: Add platform profile through shift
mode
platform/x86: msi-wmi-platform: Add PL1/PL2 support via firmware
attributes
platform/x86: msi-wmi-platform: Add charge_threshold support platform/x86: msi-wmi-platform: Drop excess fans in dual fan devices platform/x86: msi-wmi-platform: Update header text platform/x86: msi-wmi-platform: Restore fan curves on PWM disable and
unload

Armin Wolf (2):
platform/x86: msi-wmi-platform: Use input buffer for returning result platform/x86: msi-wmi-platform: Add support for fan control

 .../wmi/devices/msi-wmi-platform.rst          |   26 +
 drivers/platform/x86/Kconfig                  |    3 +
 drivers/platform/x86/msi-wmi-platform.c       | 1181 ++++++++++++++++-
 3 files changed, 1156 insertions(+), 54 deletions(-)

base-commit: 62b1dcf2e7af3dc2879d1a39bf6823c99486a8c2

Signature · 1 line
2.49.0