Skip to content

drm/xe/vf: Post-migration recovery of queues and jobs

Tomasz Lis intel-xe 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest8 patches 2 repliesIn review
  2. v88 patches 5 repliesSuperseded
  3. v79 patches 1 replySuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v69 patches11 repliesSuperseded
v58 patches1 replySuperseded
v48 patches5 repliesSuperseded
v37 patches16 repliesSuperseded
v27 patches4 repliesSuperseded
v17 patches12 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/xe/sa: Avoid caching GGTT address within the managerdrivers/gpu/drm/xe/xe_gt_debugfs.c drivers/gpu/drm/xe/xe_guc_buf.c drivers/gpu/drm/xe/xe_sa.c +3 more+19 -70 replies
2/8drm/xe/vf: Pause submissions during RESFIX fixupsdrivers/gpu/drm/xe/xe_gpu_scheduler.c drivers/gpu/drm/xe/xe_gpu_scheduler.h drivers/gpu/drm/xe/xe_guc_submit.c +2 more+97 -00 replies
3/8drm/xe: Block reset while recovering from VF migrationdrivers/gpu/drm/xe/xe_gt.c drivers/gpu/drm/xe/xe_guc_submit.c drivers/gpu/drm/xe/xe_guc_submit.h +2 more+66 -20 replies
4/8drm/xe/vf: Rebase HWSP of all contexts after migrationdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_guc_submit.c +4 more+52 -00 replies
5/8drm/xe/vf: Rebase MEMIRQ structures for all contexts after migrationdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_gt_sriov_vf.c +6 more+96 -100 replies
6/8drm/xe/vf: Post migration, repopulate ring area for pending requestdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_guc_submit.c +2 more+53 -11 reply
7/8drm/xe/vf: Refresh utilization buffer during migration recoverydrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_guc_submit.c +4 more+66 -200 replies
8/8drm/xe/vf: Rebase exec queue parallel commands during migration recoverydrivers/gpu/drm/xe/abi/guc_actions_abi.h drivers/gpu/drm/xe/xe_guc_submit.c+62 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMichal WajdeczkoMichal WiniarskiSatyanarayana K V PJonathan Cavitt
1/8R-b
2/8R-b
3/8R-b
4/8R-b A-b
5/8R-b A-b
6/8R-b R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/8] drm/xe/vf: Post-migration recovery of queues and jobs

To support VF Migration, it is necessary to do fixups to any non-virtualized resources. These fixups need to be applied within VM, on the KMD working with VF.

This series adds two fixup functions to the recovery worker:
* for fixing xe_lrc structs within queues
* for fixing xe_job structs and the commands they emit It also provides some performance and stability fixes - blocking submissions and resets while the fixups are being applied. In case of sub-allocator, it removes the cached GGTT addresses instead of implementing fixups for them.

v2: Switcghed to update of addresses by xe_lrc_write_ctx_reg()
to avoid kzalloc(), renamed or moved few functions
v3: Renamed and reordered parameters, added kerneldocs
v4: Take job_list_lock, introduce a new atomic for reset
blocking, add "refresh utilization buffer" patch
v5: Replaced "Finish RESFIX by reset" patch with "Skip fixups
before getting GGTT info", rebased "Refresh utilization buffer" patch
v6: Rebased to changes in "Make multi-GT migration less error prone",
used a scratch buffer, and added one more ring recovery patch
v7: Used better matching atomic functs, fixed noop item at end of
WQ ring, added more exit conditions in wq ring
v8: Improve error/warn logging, add propagation of errors,
make enum for offsets
v9: Rephrased comments in one patch

Tomasz Lis (8):
drm/xe/sa: Avoid caching GGTT address within the manager drm/xe/vf: Pause submissions during RESFIX fixups
drm/xe: Block reset while recovering from VF migration drm/xe/vf: Rebase HWSP of all contexts after migration drm/xe/vf: Rebase MEMIRQ structures for all contexts after migration drm/xe/vf: Post migration, repopulate ring area for pending request drm/xe/vf: Refresh utilization buffer during migration recovery drm/xe/vf: Rebase exec queue parallel commands during migration
recovery

 drivers/gpu/drm/xe/abi/guc_actions_abi.h |   8 ++
 drivers/gpu/drm/xe/xe_exec_queue.c       |  48 +++++++
 drivers/gpu/drm/xe/xe_exec_queue.h       |   4 +
 drivers/gpu/drm/xe/xe_gpu_scheduler.c    |  13 ++
 drivers/gpu/drm/xe/xe_gpu_scheduler.h    |   1 +
 drivers/gpu/drm/xe/xe_gt.c               |  10 ++
 drivers/gpu/drm/xe/xe_gt_debugfs.c       |   5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c      |  14 ++
 drivers/gpu/drm/xe/xe_gt_sriov_vf.h      |   1 +
 drivers/gpu/drm/xe/xe_guc_buf.c          |   2 +-
 drivers/gpu/drm/xe/xe_guc_submit.c       | 175 +++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_guc_submit.h       |   9 ++
 drivers/gpu/drm/xe/xe_guc_types.h        |   6 +
 drivers/gpu/drm/xe/xe_lrc.c              | 107 ++++++++++++--
 drivers/gpu/drm/xe/xe_lrc.h              |   9 ++
 drivers/gpu/drm/xe/xe_sa.c               |   1 -
 drivers/gpu/drm/xe/xe_sa.h               |  15 +-
 drivers/gpu/drm/xe/xe_sa_types.h         |   1 -
 drivers/gpu/drm/xe/xe_sriov_vf.c         |  78 +++++++++-
 drivers/gpu/drm/xe/xe_sriov_vf_ccs.c     |   2 +-
 20 files changed, 490 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.1