Skip to content

Refactor test state handling and clarify naming in lib

Li Wang via ltp ltp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Changes in v1 from the cover letter

* rebase code on the latest branch
* replace pid_t by int32_t
* memset zero in allocating ipc_region
* adding back SAFE_MMAP in setup_ipc
* set context->lib_pid in setup_ipc

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib: rename tid to tcidlib/tst_test.c+6 -62 replies
2/2lib: moves test infrastructure states into a shared context structurelib/tst_test.c+126 -966 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPetr VorelCyril Hrubis
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH v1 0/2] Refactor test state handling and clarify naming in lib

RFC -> V1
* rebase code on the latest branch
* replace pid_t by int32_t
* memset zero in allocating ipc_region
* adding back SAFE_MMAP in setup_ipc
* set context->lib_pid in setup_ipc

CI job: https://github.com/wangli5665/ltp/actions/runs/15034122818

Also, manually tested by myself on RHEL-9.6 and RHEL-10.0 (all arches).

This patch series introduces two improvements to the test infrastructure:

1: Introduce shared struct context for runtime test state

This refactor consolidates scattered global runtime state variables into a single struct context, which is stored in a new struct ipc_region. This change is aimed at improving test robustness and maintainability by enabling structured state sharing between parent and child processes, particularly for tests requiring checkpointing or fork/exec workflows.

2: Rename tid to tcid

This is a simple but meaningful rename to avoid confusion between thread ID (tid) and test case ID (tcid). This improves code clarity and avoids misinterpretation during code review.

Li Wang (2):
lib: rename tid to tcid
lib: moves test infrastructure states into a shared context structure

 lib/tst_test.c | 234 ++++++++++++++++++++++++++++---------------------
 1 file changed, 132 insertions(+), 102 deletions(-)
Signature · 5 lines
2.49.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp