Status from this message: Applied to devres, thank you!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 9 repliesApplied
- v26 patches 9 repliesSuperseded
- v17 patches 12 repliesSuperseded
Changes in v3 from the cover letter
- Adjust wording for Documentation patch (Randy, Alok)
- Apply Sathyanarayanan's RBs.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | PCI: Remove hybrid devres nature from request functionsdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 2/6 | Documentation/driver-api: Update pcim_enable_device()Documentation/ | +1 | 1 reply | |
| 3/6 | PCI: Remove pcim_request_region_exclusive()drivers/ drivers/ | +0 | 0 replies | |
| 4/6 | PCI: Remove request_flags relict from devresdrivers/ | +20 | 3 replies | |
| 5/6 | PCI: Remove redundant set of request funcsdrivers/ | +5 | 0 replies | |
| 6/6 | PCI: Remove hybrid-devres hazzard warnings from docdrivers/ | +0 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Kuppuswamy Sathyanarayanan |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | R-b |
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6]
Changes in v3:
- Adjust wording for Documentation patch (Randy, Alok)
- Apply Sathyanarayanan's RBs.
Changes in v2:
- Drop patch for removing forgotten header. Patch is unrelated. Will resend seperately. (Andy)
- Make docu patch headline "Documentation/driver-api:". There seems to be no canonical way, but this style is quite frequent. (Andy)
- Apply Andy's RBs where applicable.
Howdy,
the great day has finally arrived, I managed to get rid of one of the big three remaining problems in the PCI devres API (the other two being MSI having hybrid-devres, too, and the good old pcim_iomap_tablle)!
It turned out that there aren't even that many users of the hybrid API, where pcim_enable_device() switches certain functions in pci.c into managed devres mode, which we want to remove.
The affected drivers can be found with:
grep -rlZ "pcim_enable_device" | xargs -0 grep -l "pci_request"
These were:
ASoC [1] alsa [2] cardreader [3] cirrus [4] i2c [5] mmc [6] mtd [7] mxser [8] net [9] spi [10] vdpa [11] vmwgfx [12]
All of those have been merged and are queued up for the merge window. The only possible exception is vdpa, but it seems to be ramped up right now; vdpa, however, doesn't even use the hybrid behavior, so that patch is just for generic cleanup anyways.
With the users of the hybrid feature gone, the feature itself can finally be burned.
So I'm sending out this series now to probe whether it's judged to be good enough for the upcoming merge window. If we could take it, we would make it impossible that anyone adds new users of the hybrid thing.
If it's too late for the merge window, then that's what it is, of course.
In any case I'm glad we can get rid of most of that legacy stuff now.
Regards,
Philipp
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/ (private confirmation mail from Greg KH)
[4] https://lore.kernel.org/dri-devel/[email protected]/
[5] https://lore.kernel.org/all/l26azmnpceka2obq4gtwozziq6lbilb2owx57aajtp3t6jhd3w@llmeikgjvqyh/
[6] https://lore.kernel.org/all/CAPDyKFqqV2VEqi17UHmFE0b9Y+h5q2YaNfHTux8U=7DgF+svEw@mail.gmail.com/
[7] https://lore.kernel.org/all/[email protected]/
[8] https://lore.kernel.org/all/[email protected]/ (private confirmation mail from Greg KH)
[9] https://lore.kernel.org/all/174588423950.1081621.6688170836136857875.git-patchwork-notify@kernel.org/
[10] https://lore.kernel.org/all/[email protected]/
[11] https://lore.kernel.org/all/[email protected]/
[12] https://lore.kernel.org/dri-devel/CABQX2QNQbO4dMq-Hi6tvpi7OTwcVfjM62eCr1OGkzF8Phy-Shw@mail.gmail.com/
Philipp Stanner (6):
PCI: Remove hybrid devres nature from request functions Documentation/driver-api: Update pcim_enable_device()
PCI: Remove pcim_request_region_exclusive()
PCI: Remove request_flags relict from devres
PCI: Remove redundant set of request funcs
PCI: Remove hybrid-devres hazzard warnings from doc
.../driver-api/driver-model/devres.rst | 2 +- drivers/pci/devres.c | 201 +++--------------- drivers/pci/iomap.c | 16 -- drivers/pci/pci.c | 42 ---- drivers/pci/pci.h | 3 - 5 files changed, 32 insertions(+), 232 deletions(-)
Signature · 1 line
2.49.0