Skip to content

Allow non-atomic allocs for overflows

Jens Axboe io-uring 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 4 repliesIn review
  2. v35 patches 7 repliesSuperseded
  3. v23 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Fix typos in commit message.
- Rename io_cqe_overflow_lockless() -> io_cqe_overflow(), and io_cqe_overflow() -> io_cqe_overflow_locked().
- Make io_init_cqe() a static inline function rather than a macro.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5io_uring: open code io_req_cqe_overflow()io_uring/io_uring.c+10 -100 replies
2/5io_uring: split alloc and add of overflowio_uring/io_uring.c+45 -302 replies
3/5io_uring: make io_alloc_ocqe() take a struct io_cqe pointerio_uring/io_uring.c+16 -101 reply
4/5io_uring: pass in struct io_big_cqe to io_alloc_ocqe()include/linux/io_uring_types.h io_uring/io_uring.c+12 -120 replies
5/5io_uring: add new helpers for posting overflowsio_uring/io_uring.c+29 -211 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchCaleb Sander Mateos
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCHSET v4 0/5] Allow non-atomic allocs for overflows

Hi,

This is heavily inspired by the series that Pavel posted here:

https://lore.kernel.org/io-uring/[email protected]/

Basically this patchset tries to accomplish two things:

1) Enable GFP_KERNEL alloc of the overflow entries, when possible.

2) Make the overflow side pollute the fast/common path as little as possible.

Also does some cleanups, like passing more appropriate and easily readable arguments to the overflow handling, rather than need 3..5 arguments of various user_data/res/cflags/extra1/extra1 being passed along.

 include/linux/io_uring_types.h |  2 +-
 io_uring/io_uring.c            | 99 ++++++++++++++++++++++------------
 2 files changed, 65 insertions(+), 36 deletions(-)

Since v3:
- Fix typos in commit message.
- Rename io_cqe_overflow_lockless() -> io_cqe_overflow(), and io_cqe_overflow() -> io_cqe_overflow_locked().
- Make io_init_cqe() a static inline function rather than a macro.

Signature · 1 line
Jens Axboe