Skip to content

SHA-256 cleanup

Eric Biggers linux-crypto lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Revert "crypto: sha256 - Use the partial block API"crypto/sha256.c+23 -580 replies
2/8Revert "crypto: lib/sha256 - Use generic block helper"include/crypto/internal/sha2.h lib/crypto/sha256.c+68 -100 replies
3/8Revert "crypto: x86/sha256 - Add simd block function"arch/x86/lib/crypto/Kconfig arch/x86/lib/crypto/sha256.c+3 -100 replies
4/8Revert "crypto: riscv/sha256 - Add simd block function"arch/riscv/lib/crypto/Kconfig arch/riscv/lib/crypto/sha256.c+4 -100 replies
5/8Revert "crypto: arm64/sha256 - Add simd block function"arch/arm64/crypto/sha512-glue.c arch/arm64/lib/crypto/Kconfig arch/arm64/lib/crypto/sha2-armv8.pl +1 more+11 -120 replies
6/8Revert "crypto: arm/sha256 - Add simd block function"arch/arm/lib/crypto/Kconfig arch/arm/lib/crypto/sha256-armv4.pl arch/arm/lib/crypto/sha256.c+17 -180 replies
7/8Revert "crypto: sha256 - Use the partial block API for generic"crypto/sha256.c include/crypto/sha2.h+38 -480 replies
8/8Revert "crypto: lib/sha256 - Add helpers for block-based shash"include/crypto/internal/sha2.h lib/crypto/Kconfig lib/crypto/sha256.c+23 -620 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] SHA-256 cleanup

This series restores the SHA-256 code to have a clean design where the crypto_shash API is implemented on top of the regular library API instead of a special unsafe low-level API. Diffstat is -41 lines.

Eric Biggers (8):
Revert "crypto: sha256 - Use the partial block API" Revert "crypto: lib/sha256 - Use generic block helper" Revert "crypto: x86/sha256 - Add simd block function" Revert "crypto: riscv/sha256 - Add simd block function" Revert "crypto: arm64/sha256 - Add simd block function" Revert "crypto: arm/sha256 - Add simd block function" Revert "crypto: sha256 - Use the partial block API for generic" Revert "crypto: lib/sha256 - Add helpers for block-based shash"

 arch/arm/lib/crypto/Kconfig         |   1 -
 arch/arm/lib/crypto/sha256-armv4.pl |  20 ++--
 arch/arm/lib/crypto/sha256.c        |  14 +--
 arch/arm64/crypto/sha512-glue.c     |   6 +-
 arch/arm64/lib/crypto/Kconfig       |   1 -
 arch/arm64/lib/crypto/sha2-armv8.pl |   2 +-
 arch/arm64/lib/crypto/sha256.c      |  14 +--
 arch/riscv/lib/crypto/Kconfig       |   1 -
 arch/riscv/lib/crypto/sha256.c      |  13 +--
 arch/x86/lib/crypto/Kconfig         |   1 -
 arch/x86/lib/crypto/sha256.c        |  12 +--
 crypto/sha256.c                     | 142 ++++++++++------------------
 include/crypto/internal/sha2.h      |  52 ++--------
 include/crypto/sha2.h               |   7 +-
 lib/crypto/Kconfig                  |   8 --
 lib/crypto/sha256.c                 |  97 +++++++++++++++----
 16 files changed, 175 insertions(+), 216 deletions(-)

base-commit: 1bafd82d9a40cf09c6c40f1c09cc35b7050b1a9f

Signature · 1 line
2.49.0

Read the cover letter in its thread