Drop git-exec-path from non-Git child programs
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | t7005: sanitize test environment for subsequent testst/ | +3 | 2 replies | |
| 2/4 | editor: use standard strvec API to receive environment for external editorsbuiltin/ editor.c editor.h | +10 | 5 replies | |
| 3/4 | run-command: prep_childenv on all platformsrun-command.c | +6 | 3 replies | |
| 4/4 | drop git_exec_path() from non-Git commands' PATHrun-command.c t/ | +58 | 11 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Johannes Schindelin |
|---|---|
| Series | Helped-by Helped-by Helped-by Helped-by |
| 1/4 | |
| 2/4 | Helped-by |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Drop git-exec-path from non-Git child programs
This has caused trouble in the past [1] [2]; after attempting to help Git-for-Windows avoid that problem in Vim [3] by recommendation [4], it was suggested that upstreaming the change instead would be a better solution. Indeed, this should work for more uses/editors/etc.
[1]: https://public-inbox.org/git/CALnO6CDtGRRav8zK2GKi1oHTZWrHFTxZNmnOWu64-ab+oY3_Lw@mail.gmail.com/
[2]: https://benknoble.github.io/blog/2020/05/22/libexec-git-core-on-path/
[3]: https://github.com/git-for-windows/build-extra/pull/616
[4]: https://github.com/benknoble/Dotfiles/issues/143#issuecomment-2869525481
I haven't managed to test this on Windows, so any extra eyeballs there are greatly appreciated. I'd also appreciate suggestions to fix the memory leak.
Structure: patches 1 & 2 are cleanups. In particular, patch 1 is essential to the tests in patch 4. I don't think patch 2 is strictly needed. Patch 3 refactors a little to make patch 4 take effect on all platforms. Patch 4 does the real work.
D. Ben Knoble (4):
t7005: sanitize test environment for subsequent tests
editor: use standard strvec API to receive environment for external
editors
run-command: prep_childenv on all platforms
drop git_exec_path() from non-Git commands' PATH
builtin/commit.c | 2 +- editor.c | 10 ++++----- editor.h | 7 +++--- run-command.c | 55 ++++++++++++++++++++++++++++++++++++++++++----- t/t7005-editor.sh | 18 +++++++++++++--- 5 files changed, 75 insertions(+), 17 deletions(-)
base-commit: 7a1d2bd0a596f42a8a7a68d55577967bb454fec0
Signature · 1 line
2.48.1