Skip to content

Drop git-exec-path from non-Git child programs

D. Ben Knoble git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4t7005: sanitize test environment for subsequent testst/t7005-editor.sh+3 -42 replies
2/4editor: use standard strvec API to receive environment for external editorsbuiltin/commit.c editor.c editor.h+10 -95 replies
3/4run-command: prep_childenv on all platformsrun-command.c+6 -43 replies
4/4drop git_exec_path() from non-Git commands' PATHrun-command.c t/t7005-editor.sh+58 -211 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchJohannes Schindelin
SeriesHelped-by Helped-by Helped-by Helped-by
1/4
2/4Helped-by
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Drop git-exec-path from non-Git child programs

This has caused trouble in the past [1] [2]; after attempting to help Git-for-Windows avoid that problem in Vim [3] by recommendation [4], it was suggested that upstreaming the change instead would be a better solution. Indeed, this should work for more uses/editors/etc.

[1]: https://public-inbox.org/git/CALnO6CDtGRRav8zK2GKi1oHTZWrHFTxZNmnOWu64-ab+oY3_Lw@mail.gmail.com/
[2]: https://benknoble.github.io/blog/2020/05/22/libexec-git-core-on-path/
[3]: https://github.com/git-for-windows/build-extra/pull/616
[4]: https://github.com/benknoble/Dotfiles/issues/143#issuecomment-2869525481

I haven't managed to test this on Windows, so any extra eyeballs there are greatly appreciated. I'd also appreciate suggestions to fix the memory leak.

Structure: patches 1 & 2 are cleanups. In particular, patch 1 is essential to the tests in patch 4. I don't think patch 2 is strictly needed. Patch 3 refactors a little to make patch 4 take effect on all platforms. Patch 4 does the real work.

D. Ben Knoble (4):
t7005: sanitize test environment for subsequent tests
editor: use standard strvec API to receive environment for external
editors
run-command: prep_childenv on all platforms
drop git_exec_path() from non-Git commands' PATH

 builtin/commit.c  |  2 +-
 editor.c          | 10 ++++-----
 editor.h          |  7 +++---
 run-command.c     | 55 ++++++++++++++++++++++++++++++++++++++++++-----
 t/t7005-editor.sh | 18 +++++++++++++---
 5 files changed, 75 insertions(+), 17 deletions(-)

base-commit: 7a1d2bd0a596f42a8a7a68d55577967bb454fec0

Signature · 1 line
2.48.1