Convert bringup_guestfs to a single Ansible role
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest12 patches 3 repliesIn review
- v1 RFC5 patches 9 repliesSuperseded
Changes since RFC from the cover letter
- All of bringup_guestfs.sh has now been converted to Ansible
- Remove the old code as the last step in the series
- Reorganize the series to reduce the size of each patch
- Modernize steps that Ansible can now do with builtin modules
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | guestfs: Replace scripts/destroy_guestfs.sh with an Ansible playbook.gitignore playbooks/ playbooks/ +2 more | +50 | 0 replies | |
| 2/12 | Move the guestfs install-deps to the guestfs playbookplaybooks/ playbooks/ playbooks/ +3 more | +60 | 0 replies | |
| 3/12 | guestfs: Do not use the config-check tagscripts/ | +1 | 0 replies | |
| 4/12 | guestfs: Add a "bringup" tag to the guestfs roleplaybooks/ playbooks/ playbooks/ +1 more | +93 | 0 replies | |
| 5/12 | guestfs: Copy "network" tag steps to guestfs roleplaybooks/ playbooks/ playbooks/ +1 more | +93 | 0 replies | |
| 6/12 | guestfs: Move the QEMU_GROUP checkplaybooks/ scripts/ | +14 | 0 replies | |
| 7/12 | Add a base-image roleplaybooks/ playbooks/ playbooks/ +6 more | +399 | 0 replies | |
| 8/12 | guestfs: Convert scripts/bringup_guestfs.sh to Ansibleplaybooks/ playbooks/ playbooks/ +4 more | +190 | 0 replies | |
| 9/12 | guestfs: Move console-related steps to guestfs roleplaybooks/ playbooks/ scripts/ | +41 | 0 replies | |
| 10/12 | bringup_guestfs: Remove the roleplaybooks/ playbooks/ playbooks/ +4 more | +0 | 0 replies | |
| 11/12 | scripts: Remove the bringup_guestfs.sh scriptscripts/ | +0 | 0 replies | |
| 12/12 | scripts: Remove the destroy_guestfs.sh scriptscripts/ | +0 | 0 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Luis Chamberlain |
|---|---|
| 1/12 | R-b |
| 2/12 | R-b |
| 3/12 | |
| 4/12 | |
| 5/12 | |
| 6/12 | |
| 7/12 | |
| 8/12 | |
| 9/12 | R-b |
| 10/12 | |
| 11/12 | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/12] Convert bringup_guestfs to a single Ansible role
From: Chuck Lever <[email protected]>
This series demonstrates some ideas about how libvirt/guestfs bring- up might be expressed using only Ansible (ie. with a minimal use of shell scripting). Benefits include:
- Starting guests is now done in parallel
- "make bringup" is more idempotent
- Lets us create utilities that both guestfs and Terraform can use
The new parts that handle custom upstream images has not yet been tested.
Changes since RFC:
- All of bringup_guestfs.sh has now been converted to Ansible
- Remove the old code as the last step in the series
- Reorganize the series to reduce the size of each patch
- Modernize steps that Ansible can now do with builtin modules
Chuck Lever (12):
guestfs: Replace scripts/destroy_guestfs.sh with an Ansible playbook Move the guestfs install-deps to the guestfs playbook
guestfs: Do not use the config-check tag
guestfs: Add a "bringup" tag to the guestfs role
guestfs: Copy "network" tag steps to guestfs role
guestfs: Move the QEMU_GROUP check
Add a base-image role
guestfs: Convert scripts/bringup_guestfs.sh to Ansible
guestfs: Move console-related steps to guestfs role
bringup_guestfs: Remove the role
scripts: Remove the bringup_guestfs.sh script
scripts: Remove the destroy_guestfs.sh script
.gitignore | 1 +
playbooks/base_image.yml | 7 +
playbooks/bringup_guestfs.yml | 4 -
playbooks/guestfs.yml | 7 +
playbooks/roles/base_image/README.md | 45 ++
playbooks/roles/base_image/defaults/main.yml | 7 +
.../roles/base_image/tasks/base-image.yml | 80 ++++
.../roles/base_image/tasks/custom-image.yml | 159 +++++++
playbooks/roles/base_image/tasks/main.yml | 19 +
.../base_image/templates/custom-index.j2 | 2 +
.../base_image/templates/custom-source.j2 | 3 +
.../base_image/templates/virt-builder.j2 | 77 ++++
.../roles/bringup_guestfs/defaults/main.yml | 12 -
.../tasks/install-deps/main.yml | 17 -
.../roles/bringup_guestfs/tasks/main.yml | 243 -----------
playbooks/roles/guestfs/defaults/main.yml | 5 +
.../tasks/bringup/console-permissions.yml | 31 ++
.../guestfs/tasks/bringup/extra-disks.yml | 16 +
.../roles/guestfs/tasks/bringup/largeio.yml | 11 +
.../roles/guestfs/tasks/bringup/main.yml | 132 ++++++
.../roles/guestfs/tasks/bringup/network.yml | 83 ++++
.../tasks/bringup/storage-pool-path.yml | 92 ++++
playbooks/roles/guestfs/tasks/destroy.yml | 32 ++
.../tasks/install-deps/debian/main.yml | 3 +-
.../roles/guestfs/tasks/install-deps/main.yml | 21 +
.../tasks/install-deps/redhat/main.yml | 5 +-
.../tasks/install-deps/suse/main.yml | 3 +-
playbooks/roles/guestfs/tasks/main.yml | 67 +++
scripts/bringup_guestfs.sh | 399 ------------------
scripts/destroy_guestfs.sh | 36 --
scripts/guestfs.Makefile | 23 +-
31 files changed, 911 insertions(+), 731 deletions(-)
create mode 100644 playbooks/base_image.yml
delete mode 100644 playbooks/bringup_guestfs.yml
create mode 100644 playbooks/guestfs.yml
create mode 100644 playbooks/roles/base_image/README.md
create mode 100644 playbooks/roles/base_image/defaults/main.yml
create mode 100644 playbooks/roles/base_image/tasks/base-image.yml
create mode 100644 playbooks/roles/base_image/tasks/custom-image.yml
create mode 100644 playbooks/roles/base_image/tasks/main.yml
create mode 100644 playbooks/roles/base_image/templates/custom-index.j2
create mode 100644 playbooks/roles/base_image/templates/custom-source.j2
create mode 100644 playbooks/roles/base_image/templates/virt-builder.j2
delete mode 100644 playbooks/roles/bringup_guestfs/defaults/main.yml
delete mode 100644 playbooks/roles/bringup_guestfs/tasks/install-deps/main.yml
delete mode 100644 playbooks/roles/bringup_guestfs/tasks/main.yml
create mode 100644 playbooks/roles/guestfs/defaults/main.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/console-permissions.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/extra-disks.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/largeio.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/main.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/network.yml
create mode 100644 playbooks/roles/guestfs/tasks/bringup/storage-pool-path.yml
create mode 100644 playbooks/roles/guestfs/tasks/destroy.yml
rename playbooks/roles/{bringup_guestfs => guestfs}/tasks/install-deps/debian/main.yml (78%)
create mode 100644 playbooks/roles/guestfs/tasks/install-deps/main.yml
rename playbooks/roles/{bringup_guestfs => guestfs}/tasks/install-deps/redhat/main.yml (62%)
rename playbooks/roles/{bringup_guestfs => guestfs}/tasks/install-deps/suse/main.yml (71%)
create mode 100644 playbooks/roles/guestfs/tasks/main.yml
delete mode 100755 scripts/bringup_guestfs.sh
delete mode 100755 scripts/destroy_guestfs.shSignature · 1 line
2.49.0