Skip to content

migration: Some enhancements and cleanups for 10.1

Peter Xu qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 8 repliesIn review
  2. v211 patches 10 repliesSuperseded
  3. v111 patches 15 repliesSuperseded

Changes in v3 from the cover letter

- Fix checkpatch issues on spaces etc.
- Added Tested-by tags for Mario on relevant patches

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11migration/hmp: Reorg "info migrate" once moremigration/migration-hmp-cmds.c+31 -280 replies
2/11migration/hmp: Fix postcopy-blocktime per-vCPU resultsmigration/migration-hmp-cmds.c+13 -91 reply
3/11migration/docs: Move docs for postcopy blocktime featuredocs/devel/migration/postcopy.rst+17 -190 replies
4/11migration/bg-snapshot: Do not check for SKIP in iteratormigration/migration.c+2 -30 replies
5/11migration: Drop save_live_complete_postcopy hookinclude/migration/register.h migration/block-dirty-bitmap.c migration/ram.c +1 more+12 -231 reply
6/11migration: Rename save_live_complete_precopy to save_completehw/ppc/spapr.c hw/s390x/s390-stattrib.c hw/vfio/migration.c +4 more+11 -114 replies
7/11migration: qemu_savevm_complete*() helpersmigration/savevm.c+44 -341 reply
8/11migration/ram: One less indent for ram_find_and_save_block()migration/ram.c+11 -90 replies
9/11migration/ram: Add tracepoints for ram_save_complete()migration/ram.c migration/trace-events+6 -00 replies
10/11migration: Rewrite the migration complete detect logicmigration/migration.c+42 -150 replies
11/11migration/postcopy: Avoid clearing dirty bitmap for postcopy toomigration/ram.c+3 -10 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchLi ZhijianDr. David Alan GilbertJuraj MarcinMario CasqueroFabiano Rosas
1/11T-b R-b A-b R-b T-b
2/11R-b T-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/11] migration: Some enhancements and cleanups for 10.1

v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]

v3 changelog:
- Fix checkpatch issues on spaces etc.
- Added Tested-by tags for Mario on relevant patches

The series is based on a small patch from Yanfei Xu here:

Based-on: <[email protected]>
https://lore.kernel.org/r/[email protected]

This is a series that collected many of either enhancements or cleanups I got for QEMU 10.1, which almost came from when working on the last patch.

The last patch, which is a oneliner, can further reduce 10% postcopy page fault latency with preempt mode enabled.

      Before: 268.00us (+-1.87%)
      After:  232.67us (+-2.01%)

The patch layout is as following:

Patch 1: A follow up of HMP change for "info migrate", per
suggestion from Dave

Patch 2:         Yet another HMP fix for blocktime displays
Patch 3-10:      Cleanups everywhere, especially please take a look at

patch 10 which changes the core switchover decision logic
Patch 11: The one-liner optimization

Comments welcomed, thanks.

Peter Xu (11):
migration/hmp: Reorg "info migrate" once more migration/hmp: Fix postcopy-blocktime per-vCPU results migration/docs: Move docs for postcopy blocktime feature migration/bg-snapshot: Do not check for SKIP in iterator
migration: Drop save_live_complete_postcopy hook
migration: Rename save_live_complete_precopy to save_complete
migration: qemu_savevm_complete*() helpers migration/ram: One less indent for ram_find_and_save_block() migration/ram: Add tracepoints for ram_save_complete()
migration: Rewrite the migration complete detect logic migration/postcopy: Avoid clearing dirty bitmap for postcopy too

 docs/devel/migration/postcopy.rst | 36 +++++++-------
 include/migration/register.h      | 26 ++++------
 hw/ppc/spapr.c                    |  2 +-
 hw/s390x/s390-stattrib.c          |  2 +-
 hw/vfio/migration.c               |  2 +-
 migration/block-dirty-bitmap.c    |  3 +-
 migration/migration-hmp-cmds.c    | 81 ++++++++++++++++--------------
 migration/migration.c             | 62 ++++++++++++++++-------
 migration/ram.c                   | 32 +++++++-----
 migration/savevm.c                | 83 +++++++++++++++++--------------
 migration/trace-events            |  1 +
 11 files changed, 185 insertions(+), 145 deletions(-)
Signature · 1 line
2.49.0