dm: core: use {s,u}32 instead of int for dev_read_{s,u}32_default
Get series with b4
b4 am [email protected] change-id 20250528-dev_read_x32_default-73e09c95f64eVersions newest first
- v1 Latest2 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | dm: core: use u32 instead of int for dev_read_u32_defaultdrivers/ include/ | +5 | 3 replies | |
| 2/2 | dm: core: use s32 instead of int for dev_read_s32_defaultdrivers/ include/ | +6 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Simon Glass |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] dm: core: use {s,u}32 instead of int for dev_read_{s,u}32_default
Out of all the dev_read_*_default functions, only two do not properly use the type as argument and return type: dev_read_u32_default and dev_read_s32_default. They both use int instead of u32/s32.
Considering that it's generally not guaranteed that an int is 4 bytes but also for consistency sake, let's have them use the expected type.
Note that I have not tested this, just stumbled upon that inconsistency by chance.
---
Quentin Schulz (2):
dm: core: use u32 instead of int for dev_read_u32_default
dm: core: use s32 instead of int for dev_read_s32_default
drivers/core/read.c | 8 ++++---- include/dm/read.h | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-)
---
base-commit: e04d137231f2e9e14708a32448c879125b8e308f
change-id: 20250528-dev_read_x32_default-73e09c95f64e
Best regards,
Signature · 1 line
Quentin Schulz <[email protected]>