Skip to content

RFC New Telephony interface for HSP, HFP and CCP

Frédéric Danis linux-bluetooth 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest27 patches 3 repliesIn review
  2. v1 RFC10 patches 1 replySuperseded

Changes in v2 from the cover letter · 19 lines

- Rename org.bluez.TelephonyCall1 to org.bluez.Call1
- Remove reference to profiles in org.bluez.TelephonyAg1 object path
- Add profile UUID property to org.bluez.TelephonyAg1
- Add OperatorName property to org.bluez.TelephonyAg1
- Rename telephony_set_call_state() to telephony_call_set_state()
- Use first available index of call for new call
- Fix DBus message memory leak in hfp_dial_cb()
- Display UUID and OperatorName in bluetoothctl telephony.show command
- Add hangup-active and hangup-held support
- Add SendTones support
- Remove HFP specific comments in documentation
- Add HFP HF server and related SDP record
- Add OperatorName support to HFP HF
- Add call line identification property support to HFP HF
- Disable NREC during HFP HF connection phase
- Enable Waiting call event to HFP HF
- Enable Extended error support in HFP HF
- Add telephony_call_set_multiparty() to telephony API
- Enable Enhanced call status support in HFP HF, and use it to update calls status if available on both side

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27doc: Add new telephony related profiles interfacesMakefile.am doc/org.bluez.Call.rst doc/org.bluez.TelephonyAg.rst+347 -02 replies
2/27audio/telephony: Add shared interfaces implementationprofiles/audio/telephony.c profiles/audio/telephony.h+890 -00 replies
3/27audio/telephony: Add skeleton for HFP profileMakefile.plugins configure.ac profiles/audio/hfp-hf.c+228 -00 replies
4/27audio/hfp-hf: Add HFP SLC connection and event supportprofiles/audio/hfp-hf.c+934 -00 replies
5/27audio/hfp-hf: Add dial supportprofiles/audio/hfp-hf.c+75 -00 replies
6/27audio/hfp-hf: Add hangup all calls supportprofiles/audio/hfp-hf.c+57 -00 replies
7/27audio/hfp-hf: Add answer a specific call supportprofiles/audio/hfp-hf.c+22 -00 replies
8/27client/telephony: Add new submenuMakefile.tools client/bluetoothctl-telephony.rst client/main.c +2 more+642 -30 replies
9/27audio/hfp-hf: Remove call interface during profile disconnectionprofiles/audio/hfp-hf.c+11 -00 replies
10/27audio/hfp-hf: Create existing call during SLC phaseprofiles/audio/hfp-hf.c+19 -30 replies
11/27audio/telephony: Add hangup_active and hangup_held functionsprofiles/audio/telephony.c profiles/audio/telephony.h+30 -00 replies
12/27audio/hfp-hf: Add hangup_active and hangup_held supportprofiles/audio/hfp-hf.c+87 -00 replies
13/27client/telephony: Add hangup_active and hangup_held supportclient/telephony.c+97 -00 replies
14/27audio/hfp-hf: Add SendTones supportprofiles/audio/hfp-hf.c+40 -00 replies
15/27client/telephony: Add SendTones supportclient/telephony.c+54 -00 replies
16/27doc: Make telephony docs more genericdoc/org.bluez.Call.rst doc/org.bluez.TelephonyAg.rst+5 -350 replies
17/27client/telephony: Remove IncomingLineclient/telephony.c+0 -10 replies
18/27audio/telephony: Remove IncomingLineprofiles/audio/telephony.c profiles/audio/telephony.h+0 -270 replies
19/27audio/hfp-hf: Add HFP HF server and SDP recordprofiles/audio/hfp-hf.c+253 -00 replies
20/27audio/hfp-hf: Add operator name supportprofiles/audio/hfp-hf.c+47 -10 replies
21/27audio/telephony: Add call line identication property supportprofiles/audio/telephony.c profiles/audio/telephony.h+17 -00 replies
22/27audio/hfp-hf: Add call line idenfication supportprofiles/audio/hfp-hf.c+42 -10 replies
23/27audio/hfp-hf: Disable NREC during connection setupprofiles/audio/hfp-hf.c+21 -10 replies
24/27audio/hfp-hf: Enable waiting call if supported by remote AGprofiles/audio/hfp-hf.c+69 -20 replies
25/27audio/hfp-hf: Enable extended error if supported by remote AGprofiles/audio/hfp-hf.c+29 -70 replies
26/27audio/telephony: Add call multiparty property supportprofiles/audio/telephony.c profiles/audio/telephony.h+16 -00 replies
27/27audio/hfp-hf: Enable enhanced call status if supported by remote AGprofiles/audio/hfp-hf.c+191 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC BlueZ v2 00/27] New Telephony interface for HSP, HFP and CCP

This will introduce a new Telephony interface wich is intended to be shared by the profiles able to control telephony calls.

The idea is to split the call control interface from the audio streaming, as it is done for AVRCP and A2DP.
As for A2DP, the audio part will be delegated to the audio daemon (like PipeWire) by the creation of new endpoints for CVSD and mSBC, LC3 endpoint already exists.

The interface is mostly based on the one done for PipeWire's native backend.

This will simplify the qualification of the telephony related profiles as the qualification will no more depend on external projects, and calls can be controlled from bluetoothctl.

A first implementation allows to dial or hangup a call using HFP.

v1->v2:
- Rename org.bluez.TelephonyCall1 to org.bluez.Call1
- Remove reference to profiles in org.bluez.TelephonyAg1 object path
- Add profile UUID property to org.bluez.TelephonyAg1
- Add OperatorName property to org.bluez.TelephonyAg1
- Rename telephony_set_call_state() to telephony_call_set_state()
- Use first available index of call for new call
- Fix DBus message memory leak in hfp_dial_cb()
- Display UUID and OperatorName in bluetoothctl telephony.show command
- Add hangup-active and hangup-held support
- Add SendTones support
- Remove HFP specific comments in documentation
- Add HFP HF server and related SDP record
- Add OperatorName support to HFP HF
- Add call line identification property support to HFP HF
- Disable NREC during HFP HF connection phase
- Enable Waiting call event to HFP HF
- Enable Extended error support in HFP HF
- Add telephony_call_set_multiparty() to telephony API
- Enable Enhanced call status support in HFP HF, and use it to update calls status if available on both side

Frédéric Danis (27):
doc: Add new telephony related profiles interfaces audio/telephony: Add shared interfaces implementation audio/telephony: Add skeleton for HFP profile audio/hfp-hf: Add HFP SLC connection and event support audio/hfp-hf: Add dial support
audio/hfp-hf: Add hangup all calls support
audio/hfp-hf: Add answer a specific call support client/telephony: Add new submenu
audio/hfp-hf: Remove call interface during profile disconnection audio/hfp-hf: Create existing call during SLC phase audio/telephony: Add hangup_active and hangup_held functions audio/hfp-hf: Add hangup_active and hangup_held support client/telephony: Add hangup_active and hangup_held support audio/hfp-hf: Add SendTones support
client/telephony: Add SendTones support
doc: Make telephony docs more generic
client/telephony: Remove IncomingLine
audio/telephony: Remove IncomingLine
audio/hfp-hf: Add HFP HF server and SDP record audio/hfp-hf: Add operator name support
audio/telephony: Add call line identication property support audio/hfp-hf: Add call line idenfication support audio/hfp-hf: Disable NREC during connection setup audio/hfp-hf: Enable waiting call if supported by remote AG audio/hfp-hf: Enable extended error if supported by remote AG audio/telephony: Add call multiparty property support audio/hfp-hf: Enable enhanced call status if supported by remote AG

 Makefile.am                       |    4 +
 Makefile.plugins                  |    5 +
 Makefile.tools                    |    9 +-
 client/bluetoothctl-telephony.rst |   95 ++
 client/main.c                     |    3 +
 client/telephony.c                |  676 ++++++++++
 client/telephony.h                |   12 +
 configure.ac                      |    7 +
 doc/org.bluez.Call.rst            |  107 ++
 doc/org.bluez.TelephonyAg.rst     |  206 +++
 profiles/audio/hfp-hf.c           | 2092 +++++++++++++++++++++++++++++
 profiles/audio/telephony.c        |  808 +++++++++++
 profiles/audio/telephony.h        |  118 ++
 13 files changed, 4139 insertions(+), 3 deletions(-)
 create mode 100644 client/bluetoothctl-telephony.rst
 create mode 100644 client/telephony.c
 create mode 100644 client/telephony.h
 create mode 100644 doc/org.bluez.Call.rst
 create mode 100644 doc/org.bluez.TelephonyAg.rst
 create mode 100644 profiles/audio/hfp-hf.c
 create mode 100644 profiles/audio/telephony.c
 create mode 100644 profiles/audio/telephony.h
Signature · 1 line
2.43.0