ASoC: Intel: avs: Set of functional fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ASoC: codecs: hda: Fix RPM usage count underflowsound/ | +2 | 0 replies | |
| 2/9 | ASoC: Intel: avs: Fix deadlock when the failing IPC is SET_D0IXsound/ | +3 | 0 replies | |
| 3/9 | ASoC: Intel: avs: Fix PPLCxFMT calculationsound/ | +5 | 0 replies | |
| 4/9 | ASoC: Intel: avs: Fix possible null-ptr-deref when initing hwsound/ | +1 | 0 replies | |
| 5/9 | ASoC: Intel: avs: Fix paths in MODULE_FIRMWARE hintssound/ | +10 | 0 replies | |
| 6/9 | ASoC: Intel: avs: Verify kcalloc() status when setting constraintssound/ | +2 | 0 replies | |
| 7/9 | ASoC: Intel: avs: Verify content returned by parse_int_array()sound/ | +5 | 0 replies | |
| 8/9 | ASoC: Intel: avs: Simplify verification of parse_int_array() resultsound/ sound/ | +4 | 0 replies | |
| 9/9 | ASoC: Intel: avs: Include missing string.hsound/ | +1 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Amadeusz Sławiński | Cezary Rojewski |
|---|---|---|
| 1/9 | R-b | |
| 2/9 | R-b | |
| 3/9 | R-b | |
| 4/9 | R-b | |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | R-b | |
| 8/9 | R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] ASoC: Intel: avs: Set of functional fixes
Medium range of fixes all avs-driver related. The most important fixes lead the way:
1. For ASoC-hda codec driver, existing RPM manipulation in hda_codec_probe_complete()'s error path is superfluous and leads to RPM usage count underflow if the probe exists early e.g.: build-controls operation fails.
2. Resolve deadlock when DSP-recovery is a consequence of SET_D0IX IPC. The procedure handling IPC timeouts and EXCEPTION_CAUGHT notification shall cancel any D0IX work before proceeding with DSP recovery. If SET_D0IX called from delayed_work is the failing IPC the procedure will deadlock.
3. LINK format (PPLCxFMT) calculation is incorrect.
HDAudio transfer types utilize SDxFMT for front-end (HOST) and PPLCxFMT for back-end (LINK) side when setting up the stream. BE's substream->runtime duplicates FE runtime so switch to using BE's hw_params to address incorrect format values on the LINK side when FE and BE formats differ.
Below three patches address problems found by Coverity static analyzer:
ASoC: Intel: avs: Fix possible null-ptr-deref when initing hw
ASoC: Intel: avs: Verify kcalloc() status when setting constraints
ASoC: Intel: avs: Verify content returned by parse_int_array()
While unlikely in runtime, it's good to keep code resilient. The last few patches are readability/cohesiveness improvements.
Amadeusz Sławiński (1):
ASoC: Intel: avs: Fix paths in MODULE_FIRMWARE hints
Cezary Rojewski (8):
ASoC: codecs: hda: Fix RPM usage count underflow
ASoC: Intel: avs: Fix deadlock when the failing IPC is SET_D0IX
ASoC: Intel: avs: Fix PPLCxFMT calculation
ASoC: Intel: avs: Fix possible null-ptr-deref when initing hw
ASoC: Intel: avs: Verify kcalloc() status when setting constraints
ASoC: Intel: avs: Verify content returned by parse_int_array()
ASoC: Intel: avs: Simplify verification of parse_int_array() result
ASoC: Intel: avs: Include missing string.h
sound/soc/codecs/hda.c | 4 ++-- sound/soc/intel/avs/board_selection.c | 2 +- sound/soc/intel/avs/core.c | 20 ++++++++++---------- sound/soc/intel/avs/debugfs.c | 12 ++++++++---- sound/soc/intel/avs/ipc.c | 4 +++- sound/soc/intel/avs/loader.c | 1 + sound/soc/intel/avs/path.c | 2 ++ sound/soc/intel/avs/pcm.c | 13 ++++++------- 8 files changed, 33 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1