Skip to content

RFC net: dsa: b53: fix BCM5325 support

Álvaro Fernández Rojas lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest10 patches 5 repliesIn review
  2. v1 RFC10 patches 22 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net: dsa: b53: add support for FDB operations on 5325/5365drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h drivers/net/dsa/b53/b53_regs.h+117 -233 replies
2/10net: dsa: b53: prevent FAST_AGE access on BCM5325drivers/net/dsa/b53/b53_common.c+9 -00 replies
3/10net: dsa: b53: prevent SWITCH_CTRL access on BCM5325drivers/net/dsa/b53/b53_common.c+6 -50 replies
4/10net: dsa: b53: fix IP_MULTICAST_CTRL on BCM5325drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_regs.h+12 -70 replies
5/10net: dsa: b53: prevent DIS_LEARNING access on BCM5325drivers/net/dsa/b53/b53_common.c+10 -10 replies
6/10net: dsa: b53: prevent BRCM_HDR access on BCM5325drivers/net/dsa/b53/b53_common.c+4 -01 reply
7/10net: dsa: b53: prevent GMII_PORT_OVERRIDE_CTRL access on BCM5325drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_regs.h+18 -40 replies
8/10net: dsa: b53: fix unicast/multicast flooding on BCM5325drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_regs.h+55 -180 replies
9/10net: dsa: b53: fix b53_imp_vlan_setup for BCM5325drivers/net/dsa/b53/b53_common.c+4 -00 replies
10/10net: dsa: b53: ensure BCM5325 PHYs are enableddrivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_regs.h+15 -01 reply

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/10
2/10
3/10R-b
4/10
5/10
6/10R-b
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH net-next v2 00/10] net: dsa: b53: fix BCM5325 support

These patches get the BCM5325 switch working with b53.

I'm not really sure that everything here is correct since I don't work for Broadcom and all this is based on the public datasheet available for the BCM5325 and my own experiments with a Huawei HG556a (BCM6358).

v2: introduce changes requested by Jonas, Florian and Vladimir:
- Add b53_arl_to_entry_25 function.
- Add b53_arl_from_entry_25 function.
- Add b53_arl_read_25 function, fixing usage of ARLTBL_VALID_25 and

    ARLTBL_VID_MASK_25.

- Change b53_set_forwarding function flow.
- Disallow BR_LEARNING on b53_br_flags_pre() for BCM5325.
- Drop rate control registers.
- Move B53_PD_MODE_CTRL_25 to b53_setup_port().

Florian Fainelli (1):
net: dsa: b53: add support for FDB operations on 5325/5365

Álvaro Fernández Rojas (9):
net: dsa: b53: prevent FAST_AGE access on BCM5325
net: dsa: b53: prevent SWITCH_CTRL access on BCM5325
net: dsa: b53: fix IP_MULTICAST_CTRL on BCM5325
net: dsa: b53: prevent DIS_LEARNING access on BCM5325
net: dsa: b53: prevent BRCM_HDR access on BCM5325
net: dsa: b53: prevent GMII_PORT_OVERRIDE_CTRL access on BCM5325
net: dsa: b53: fix unicast/multicast flooding on BCM5325
net: dsa: b53: fix b53_imp_vlan_setup for BCM5325
net: dsa: b53: ensure BCM5325 PHYs are enabled

 drivers/net/dsa/b53/b53_common.c | 255 ++++++++++++++++++++++++-------
 drivers/net/dsa/b53/b53_priv.h   |  29 ++++
 drivers/net/dsa/b53/b53_regs.h   |  24 ++-
 3 files changed, 250 insertions(+), 58 deletions(-)
Signature · 1 line
2.39.5