Skip to content

media: mt9m114: Changes to make it work with atomisp devices

Hans de Goede linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 15 repliesIn review
  2. v212 patches 19 repliesSuperseded

Changes in v3 from the cover letter

- Document that using 768Mhz for out_clock_max does not work
- Improve "media: mt9m114: Put sensor in reset on power down" commit message
- Drop setting of the MT9M114_CAM_OUTPUT_FORMAT_BT656_CROP_SCALE_DISABLE bit
- Split "media: mt9m114: Fix scaler bypass mode" into multiple patches, addressing various review comments as part of this

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15media: aptina-pll: Debug log p1 min and max valuesdrivers/media/i2c/aptina-pll.c+2 -00 replies
2/15media: mt9m114: Add support for clock-frequency propertydrivers/media/i2c/mt9m114.c+17 -50 replies
3/15media: mt9m114: Use aptina-PLL helper to get PLL valuesdrivers/media/i2c/Kconfig drivers/media/i2c/mt9m114.c+41 -150 replies
4/15media: mt9m114: Lower minimum vblank valuedrivers/media/i2c/mt9m114.c+2 -20 replies
5/15media: mt9m114: Fix default hblank and vblank valuesdrivers/media/i2c/mt9m114.c+4 -30 replies
6/15media: mt9m114: Tweak default hblank and vblank for more accurate fpsdrivers/media/i2c/mt9m114.c+2 -20 replies
7/15media: mt9m114: Avoid a reset low spike during probe()drivers/media/i2c/mt9m114.c+1 -10 replies
8/15media: mt9m114: Put sensor in reset on power downdrivers/media/i2c/mt9m114.c+7 -00 replies
9/15media: mt9m114: Add and use mt9m114_ifp_get_border() helper functiondrivers/media/i2c/mt9m114.c+38 -161 reply
10/15media: mt9m114: Adjust IFP selections and src format when src pixelfmt changes to/from RAW10drivers/media/i2c/mt9m114.c+48 -52 replies
11/15media: mt9m114: Update src pad sel and format when sink pad format changesdrivers/media/i2c/mt9m114.c+2 -01 reply
12/15media: mt9m114: Don't allow changing the IFP crop/compose selections when bypassing the scalerdrivers/media/i2c/mt9m114.c+10 -41 reply
13/15media: mt9m114: Drop start-, stop-streaming sequence from initializedrivers/media/i2c/mt9m114.c+11 -84 replies
14/15media: mt9m114: Return -EPROBE_DEFER if no endpoint is founddrivers/media/i2c/mt9m114.c+7 -43 replies
15/15media: mt9m114: Add ACPI enumeration supportdrivers/media/i2c/mt9m114.c+7 -00 replies

Reviews trailers per patch

12 of 15 patches have a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/15R-b
2/15
3/15
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/15] media: mt9m114: Changes to make it work with atomisp devices

Hi All,

Here is v3 of my series to make the "mainline" mt9m114 driver work on devices with an atomisp CSI2 receiver / ISP. This has been tested on an Asus T100TA.

Changes in v3:
- Document that using 768Mhz for out_clock_max does not work
- Improve "media: mt9m114: Put sensor in reset on power down" commit message
- Drop setting of the MT9M114_CAM_OUTPUT_FORMAT_BT656_CROP_SCALE_DISABLE bit
- Split "media: mt9m114: Fix scaler bypass mode" into multiple patches, addressing various review comments as part of this

Changes in v2:
- Rebase on top of sailus/media_tree.git/fixes which now has 4 of the patches from Mathis': "MT9M114 driver bugfix and improvements" series, this avoids most of the conlicts between the 2 series
- Add Laurent's Reviewed-by to some of the patches
- Add select VIDEO_APTINA_PLL to Kconfig
- Use correct aptina_pll_limits
- After setting reset high wait 20 clk cycles before disabling the clk and regulators
- When bypassing the scalar make ifp_get_selection() / ifp_set_selection() fill sel->r with a rectangle of (0,0)/wxh and return 0 instead of returning -EINVAL

Regards,

Hans

Hans de Goede (15):
media: aptina-pll: Debug log p1 min and max values
media: mt9m114: Add support for clock-frequency property
media: mt9m114: Use aptina-PLL helper to get PLL values
media: mt9m114: Lower minimum vblank value
media: mt9m114: Fix default hblank and vblank values
media: mt9m114: Tweak default hblank and vblank for more accurate fps
media: mt9m114: Avoid a reset low spike during probe()
media: mt9m114: Put sensor in reset on power down
media: mt9m114: Add and use mt9m114_ifp_get_border() helper function
media: mt9m114: Adjust IFP selections and src format when src pixelfmt
changes to/from RAW10
media: mt9m114: Update src pad sel and format when sink pad format
changes
media: mt9m114: Don't allow changing the IFP crop/compose selections
when bypassing the scaler
media: mt9m114: Drop start-, stop-streaming sequence from initialize
media: mt9m114: Return -EPROBE_DEFER if no endpoint is found
media: mt9m114: Add ACPI enumeration support

 drivers/media/i2c/Kconfig      |   1 +
 drivers/media/i2c/aptina-pll.c |   2 +
 drivers/media/i2c/mt9m114.c    | 255 +++++++++++++++++++++++++--------
 3 files changed, 196 insertions(+), 62 deletions(-)
Signature · 1 line
2.49.0