Skip to content

Handle aborted suspend better

Mario Limonciello amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/amd: Add support for a complete pmops actiondrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 more+25 -10 replies
2/3drm/amd/display: Stop storing failures into adev->dm.cached_statedrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+18 -70 replies
3/3drm/amd/display: Destroy cached state in complete() callbackdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+60 -400 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Hung
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Handle aborted suspend better

From: Mario Limonciello <[email protected]>

Chris Bainbridge reported some list corruption occurring around the suspend sequence when an aborted suspend occurs.

I couldn't reproduce this specific problem, but when I tried I found some other issues where the cached DM state isn't properly destroyed.

This is because there isn't a complete() callback to match the prepare() callback used by amdgpu. Normally the PM core will call complete() after every suspend attempt (succesful or not).

Mario Limonciello (3):
drm/amd: Add support for a complete pmops action drm/amd/display: Stop storing failures into adev->dm.cached_state drm/amd/display: Destroy cached state in complete() callback

 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  22 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |   2 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 125 +++++++++++-------
 drivers/gpu/drm/amd/include/amd_shared.h      |   1 +
 5 files changed, 103 insertions(+), 48 deletions(-)
Signature · 1 line
2.43.0