Skip to content

rust: Add ACPI match table support for Rust drivers

Igor Korotin linux-acpi linux-devicetree linux-i2c lkml rust-for-linux 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest9 patches 11 repliesIn review
  2. v79 patches 5 repliesSuperseded
  3. v66 patches 6 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v56 patches2 repliesSuperseded
v45 patches2 repliesSuperseded
v34 patches15 repliesSuperseded
v25 patches2 repliesSuperseded
v13 of 5 patches3 repliesSuperseded

Changes in v8 from the cover letter

- Rebased on top of the latest state of the driver-core-next branch.
- Replaced FwNode::is_compatible() API with FwNode::is_of_node()
per Danilo's request. This includes initial commit and conditional call
in samples: rust: platform: conditionally call Self::properties_parse()
- Link to v7: https://lore.kernel.org/rust-for-linux/[email protected]/

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9rust: device: implement FwNode::is_of_node()MAINTAINERS rust/helpers/helpers.c rust/helpers/of.c +1 more+17 -03 replies
2/9samples: rust: platform: don't call as_ref() repeatedlysamples/rust/rust_driver_platform.rs+5 -31 reply
3/9samples: rust: platform: conditionally call Self::properties_parse()samples/rust/rust_driver_platform.rs+3 -10 replies
4/9rust: acpi: add `acpi::DeviceId` abstractionMAINTAINERS rust/kernel/acpi.rs rust/kernel/lib.rs+62 -06 replies
5/9rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]`rust/kernel/driver.rs+21 -190 replies
6/9rust: driver: Add ACPI id table support to Adapter traitrust/bindings/bindings_helper.h rust/kernel/driver.rs rust/kernel/platform.rs+46 -20 replies
7/9rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` traitrust/kernel/platform.rs+1 -10 replies
8/9rust: platform: Add ACPI match table support to `Driver` traitrust/kernel/platform.rs+21 -20 replies
9/9samples: rust: add ACPI match table example to platform driversamples/rust/rust_driver_platform.rs+69 -10 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by.

PatchDirk BehmeRafael J. WysockiRob Herring (Arm)
1/9R-b
2/9R-b
3/9
4/9A-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/9] rust: Add ACPI match table support for Rust drivers

This patch series introduces support for ACPI match tables in Rust drivers.

Currently, Rust abstractions support only Open Firmware (OF) device matching. This series extends the driver model to support ACPI-based matching, enabling Rust drivers to bind to ACPI-described devices.

Changes include:
- A new acpi::DeviceId abstraction for working with struct acpi_device_id.
- Updates to the core Adapter trait and platform::Driver to support optional ACPI ID tables.
- A sample implementation in the Rust platform driver, demonstrating multi-bus matching.

This is especially useful for writing drivers that work across platforms using both OF and ACPI.

Tested using QEMU with a custom SSDT that creates an ACPI device matching the sample Rust platform driver.

This series is based on three patches by Danilo Krummrich, which introduce general improvements to the Rust platform driver. These patches re included unchanged at the beginning of the series for completeness, as they are required for the ACPI integration.

Danilo Krummrich (3):
rust: device: implement FwNode::is_of_node()
samples: rust: platform: don't call as_ref() repeatedly
samples: rust: platform: conditionally call Self::properties_parse()

Igor Korotin (6):
rust: acpi: add acpi::DeviceId abstraction
rust: driver: Consolidate Adapter::of_id_info methods using #[cfg]
rust: driver: Add ACPI id table support to Adapter trait
rust: platform: Set OF_ID_TABLE default to None in Driver trait
rust: platform: Add ACPI match table support to Driver trait
samples: rust: add ACPI match table example to platform driver

Changelog
---------
v8:
- Rebased on top of the latest state of the driver-core-next branch.
- Replaced FwNode::is_compatible() API with FwNode::is_of_node()
per Danilo's request. This includes initial commit and conditional call
in samples: rust: platform: conditionally call Self::properties_parse()
- Link to v7: https://lore.kernel.org/rust-for-linux/[email protected]/
v7:
- Rebased onto the driver-core-next branch
- Incorporated three of Danilo’s upstream patches as a base
- Switched from assert! to build_assert! in acpi::DeviceId::new
for compile-time checks
- Renamed the sample ACPI HID to TST0001
- Moved the ACPI test instructions into the module’s top-level
documentation comment
- Link to v6: https://lore.kernel.org/rust-for-linux/[email protected]/
v6:
- Moved set Driver::OF_ID_TABLE default to None to a separate commit
- Removed out of scope change related to cpufreq driver.
- Link to v5: https://lore.kernel.org/rust-for-linux/[email protected]/
v5:
- Got rid of unnecessary consolidation of Adapter::acpi_id_info methods.
Instead, firstly made consolidation of Adapter::of_id_info, then Adapter::acpi_id_info is added using the same pattern.
- Set Adapter::OF_ID_TABLE and Adapter::ACPI_ID_TABLE as None by
default.
- Removed Adapter::OF_ID_TABLE/Adapter::ACPI_ID_TABLE initialization
example due to irrelevance.
- Removed extra of dependency and Adapter::OF_ID_TABLE initialization
in cpufreq driver.
- Link to v4: https://lore.kernel.org/rust-for-linux/[email protected]/
v4:
- Fixed code example for trait Adapter in platform.rs
- Fixed driver implementation example in rust_driver_platform.rs and moved
it to trait Adapter in platform.rs per Danilo Krummrich's suggestion.
- Consolidated Adapter::of_id_info and Adapter::acpi_id_info methods using
#[cfg] per Benno Lossin's suggestion.
- Link to v3: https://lore.kernel.org/rust-for-linux/[email protected]/
v3:
- Removed fwnode type check in Adapter::id_info per Greg's and Danilo's
comments
- Removed is_of_node rust helper, due to unnecessity.
- Fixed example code in rust_driver_platform.rs per Danilo's comment
- Added an instruction of testing ACPI using QEMU with a custom SSDT
- Fixed minor code formatting issues.
- Link to v2: https://lore.kernel.org/rust-for-linux/[email protected]/
v2:
- Removed misleading comment in acpi::DeviceID implementation.
- Removed unnecessary casting in acpi::DeviceID::new.
- Moved pub mod acpi to correct alphabetical position in rust/kernel/lib.rs.
- Link to v1: https://lore.kernel.org/rust-for-linux/[email protected]/

 MAINTAINERS                          |  2 +
 rust/bindings/bindings_helper.h      |  1 +
 rust/helpers/helpers.c               |  1 +
 rust/helpers/of.c                    |  8 +++
 rust/kernel/acpi.rs                  | 60 +++++++++++++++++++++
 rust/kernel/device/property.rs       |  7 +++
 rust/kernel/driver.rs                | 81 +++++++++++++++++++++-------
 rust/kernel/lib.rs                   |  1 +
 rust/kernel/platform.rs              | 29 ++++++++--
 samples/rust/rust_driver_platform.rs | 80 +++++++++++++++++++++++++--
 10 files changed, 243 insertions(+), 27 deletions(-)
 create mode 100644 rust/helpers/of.c
 create mode 100644 rust/kernel/acpi.rs

base-commit: b29929b819f35503024c6a7e6ad442f6e36c68a0

Signature · 1 line
2.43.0