Skip to content

drop volatile from global data

Rasmus Villemoes u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12arm: drop volatile qualifier from gd pointerarch/arm/include/asm/global_data.h+2 -21 reply
2/12powerpc: drop volatile qualifier from gd pointerarch/powerpc/include/asm/global_data.h+1 -10 replies
3/12mips: drop volatile qualifier from gd pointerarch/mips/include/asm/global_data.h+1 -10 replies
4/12microblaze: drop volatile qualifier from gd pointerarch/microblaze/include/asm/global_data.h+1 -10 replies
5/12m68k: drop volatile qualifier from gd pointerarch/m68k/include/asm/global_data.h+1 -10 replies
6/12m68k: drop pointless #if 0 blockarch/m68k/include/asm/global_data.h+0 -51 reply
7/12arc: drop volatile qualifier from gd pointerarch/arc/include/asm/global_data.h+1 -10 replies
8/12arm: imx: remove unnecessary volatile qualifiers from "save gd" variablesarch/arm/mach-imx/hab.c arch/arm/mach-imx/imx9/scmi/soc.c arch/arm/mach-imx/romapi.c+6 -61 reply
9/12efi: drop volatile qualifier from "save gd" variableslib/efi_loader/efi_boottime.c+1 -11 reply
10/12lib/trace: drop volatile qualifier from "save gd" variableslib/trace.c+2 -20 replies
11/12arm: remove volatile from set_gd prototypearch/arm/include/asm/global_data.h+1 -10 replies
12/12riscv: remove volatile from set_gd prototypearch/riscv/include/asm/global_data.h+1 -10 replies

Reviews trailers per patch

2 of 12 patches have a Reviewed-by or Acked-by.

PatchHeinrich SchuchardtAngelo DureghelloAnshul Dalal
1/12T-b
2/12
3/12
4/12
5/12
6/12A-b
7/12
8/12T-b
9/12R-b
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] drop volatile from global data

There's really no reason for the gd pointer to have the volatile qualifier.

In fact, I claim that it's completely unnecessary and just pessimizes code generation and forces ugly casts in lots of places. For example, see the casts in drivers/core/tag.c where elements are added to gd->dm_taglist, or a helper such as cyclic_get_list() that should not be needed.

Also, it is what ends up standing in the way of an otherwise innocent code cleanup of list.h:
https://lore.kernel.org/u-boot/20250522165656.GB2179216@bill-the-cat/

Note that riscv, x86 as well as arm64 with LTO enabled has not had this volatile qualifier, so it's unlikely there's any generic code that depends on it.

CI seems mostly happy:

https://github.com/u-boot/u-boot/pull/775/checks?check_run_id=43463083829

The one failing test seems to be an infrastructure thing unrelated to these patches ("docker: filesystem layer verification failed for digest sha256:379cc6cd06dc3fc80e31d5170204c0cfcc25cb3b3ad457ced23bed2b38ec9f36")

Rasmus Villemoes (12):
arm: drop volatile qualifier from gd pointer
powerpc: drop volatile qualifier from gd pointer
mips: drop volatile qualifier from gd pointer
microblaze: drop volatile qualifier from gd pointer
m68k: drop volatile qualifier from gd pointer
m68k: drop pointless #if 0 block
arc: drop volatile qualifier from gd pointer
arm: imx: remove unnecessary volatile qualifiers from "save gd"
variables
efi: drop volatile qualifier from "save gd" variables lib/trace: drop volatile qualifier from "save gd" variables
arm: remove volatile from set_gd prototype
riscv: remove volatile from set_gd prototype

 arch/arc/include/asm/global_data.h        | 2 +-
 arch/arm/include/asm/global_data.h        | 6 +++---
 arch/arm/mach-imx/hab.c                   | 2 +-
 arch/arm/mach-imx/imx9/scmi/soc.c         | 4 ++--
 arch/arm/mach-imx/romapi.c                | 6 +++---
 arch/m68k/include/asm/global_data.h       | 7 +------
 arch/microblaze/include/asm/global_data.h | 2 +-
 arch/mips/include/asm/global_data.h       | 2 +-
 arch/powerpc/include/asm/global_data.h    | 2 +-
 arch/riscv/include/asm/global_data.h      | 2 +-
 lib/efi_loader/efi_boottime.c             | 2 +-
 lib/trace.c                               | 4 ++--
 12 files changed, 18 insertions(+), 23 deletions(-)
Signature · 1 line
2.49.0