Skip to content

Improve ATA NCQ command error in mpt3sas and mpi3mr

Damien Le Moal linux-scsi 1 version Applied

Status from this message: Applied to 6.17/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: mpi3mr: Correctly handle ATA device errorsdrivers/scsi/mpi3mr/mpi3mr_os.c+19 -10 replies
2/2scsi: mpt3sas: Correctly handle ATA device errorsdrivers/scsi/mpt3sas/mpt3sas_scsih.c+19 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchYafang Shao
SeriesT-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Improve ATA NCQ command error in mpt3sas and mpi3mr

Martin,

Two similar patches for the mpt3sas and mpi3mr drivers to improve the handling of NCQ command terminated due to an NCQ command failure. These so-called collateral aborts must be retried immediately but that must be done without incrementing the command retry counter. Otherwise, these collateral abort commands may endup being failed due to other NCQ command errors.

This issue is especially easy to trigger with the mpi3mr driver with a drive subject to a mixed workload of commands with a short CDL limit and commands without limits. The failures due to the limit being exceeded, which are normal, endup also failing commands without a limit, which is incorrect.

Broadcom people,

I am working in the dark here, with zero information on how your HBA handle ATA NCQ collateral aborts. I am patching against what I am seeing, which may be only a partial picture of the problem. So please check this !

Damien Le Moal (2):
scsi: mpi3mr: Correctly handle ATA device errors
scsi: mpt3sas: Correctly handle ATA device errors

 drivers/scsi/mpi3mr/mpi3mr_os.c      | 20 +++++++++++++++++++-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 19 +++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)
Signature · 1 line
2.49.0