Skip to content

ACPI: Improve SPCR handling and messaging on SPCR-less systems

Li Chen linux-acpi linux-arm-kernel lkml 2 versions – Applied

Status from this message: Applied to arm64 (for-next/acpi), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied
  2. v12 patches 3 repliesSuperseded

Changelog from the cover letter

v2: refine the printk message logic as suggested by Hanjun Guo. [2]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2ACPI: Return -ENODEV from acpi_parse_spcr() when SPCR support is disabledinclude/linux/acpi.h+1 -12 replies
2/2ACPI: Suppress misleading SPCR console message when SPCR table is absentarch/arm64/kernel/acpi.c+7 -30 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHanjun Guo
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] ACPI: Improve SPCR handling and messaging on SPCR-less systems

From: Li Chen <[email protected]>

From: Li Chen <[email protected]>

This small series improves the kernel behavior and output when the ACPI SPCR table is not present or not supported.

Currently, even on systems that completely lack an SPCR table, the kernel prints:
"Use ACPI SPCR as default console: Yes"

This may mislead users into thinking an SPCR table exists
when in fact there is no such table at all. This series addresses this in two steps:

Patch 1 ensures that acpi_parse_spcr() returns -ENODEV if CONFIG_ACPI_SPCR_TABLE is disabled.

Patch 2 updates arm64 acpi_boot_table_init() to only print the Yes if acpi_parse_spcr() succeeds.

This results in cleaner and more accurate boot logs on ARM64.

Tested on both SPCR-enabled and SPCR-less qemu-system arm64 virt platform. [1]

Changelog:
v2: refine the printk message logic as suggested by Hanjun Guo. [2]

[1]: https://patchew.org/QEMU/[email protected]/
[2]: https://www.spinics.net/lists/kernel/msg5730585.html

Li Chen (2):
ACPI: Return -ENODEV from acpi_parse_spcr() when SPCR support is
disabled
ACPI: Suppress misleading SPCR console message when SPCR table is
absent

 arch/arm64/kernel/acpi.c | 10 +++++++---
 include/linux/acpi.h     |  2 +-
 2 files changed, 8 insertions(+), 4 deletions(-)
Signature · 1 line
2.49.0