Skip to content

drm/xe: Make all xe_ggtt structs private.

Maarten Lankhorst intel-xe 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 17 repliesIn review
  2. v612 patches 2 repliesSuperseded
  3. v56 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches0 repliesSuperseded
v36 patches4 repliesSuperseded
v25 patches3 repliesSuperseded
v13 patches0 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/xe: Start using ggtt->start in preparation of balloon removaldrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h drivers/gpu/drm/xe/xe_ggtt_types.h +1 more+59 -330 replies
2/12drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTTdrivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h +1 more+130 -880 replies
3/12drm/xe: Add xe_ggtt_node_addr() to avoid dereferencing xe_ggtt_nodedrivers/gpu/drm/xe/xe_bo.h drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h+18 -33 replies
4/12drm/xe/display: Avoid dereferencing xe_ggtt_nodedrivers/gpu/drm/xe/compat-i915-headers/i915_vma.h drivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/display/xe_stolen.c+5 -51 reply
5/12drm/xe: Do not dereference ggtt_node in xe_bo.cdrivers/gpu/drm/xe/xe_bo.c+3 -33 replies
6/12drm/xe: Improve xe_gt_sriov_pf_config GGTT handlingdrivers/gpu/drm/xe/xe_gt_sriov_pf_config.c drivers/gpu/drm/xe/xe_gt_sriov_pf_config_types.h+14 -94 replies
7/12drm/xe: Privatize xe_ggtt_nodedrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt_types.h+19 -181 reply
8/12drm/xe: Make xe_ggtt_node offset relative to starting offsetdrivers/gpu/drm/xe/xe_ggtt.c+14 -72 replies
9/12drm/xe: Rewrite GGTT VF initialisationdrivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c drivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_ggtt.c +7 more+60 -3251 reply
10/12drm/xe: Move struct xe_ggtt to xe_ggtt.cdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h drivers/gpu/drm/xe/xe_ggtt_types.h+55 -560 replies
11/12drm/xe: Make xe_ggtt_node_insert return a nodedrivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h +1 more+38 -731 reply
12/12drm/xe: Remove xe_ggtt_node_allocateddrivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt.h +1 more+7 -231 reply

Reviews trailers per patch

7 of 12 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostJuha-Pekka HeikkilaStuart Summers
1/12R-b
2/12R-b R-b
3/12
4/12R-b
5/12
6/12R-b
7/12R-b
8/12
9/12
10/12R-b
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/12] drm/xe: Make all xe_ggtt structs private.

The previous approach iterated over the entire GGTT, but it's easier to hide even the xe_ggtt_node struct and only provide a xe_ggtt_node_addr() function.

While cleaning up, also remove xe_ggtt_node_alloc()/fini(), this can be handled in xe_ggtt_insert() instead as all the other users are already internal.

This makes the final cleanup the removal of xe_ggtt_node_allocated(), as it can be changed to a simple null check instead.

Rebase as previous version failed to apply.

Maarten Lankhorst (12):
drm/xe: Start using ggtt->start in preparation of balloon removal drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT drm/xe: Add xe_ggtt_node_addr() to avoid dereferencing xe_ggtt_node drm/xe/display: Avoid dereferencing xe_ggtt_node
drm/xe: Do not dereference ggtt_node in xe_bo.c
drm/xe: Improve xe_gt_sriov_pf_config GGTT handling drm/xe: Privatize xe_ggtt_node
drm/xe: Make xe_ggtt_node offset relative to starting offset drm/xe: Rewrite GGTT VF initialisation
drm/xe: Move struct xe_ggtt to xe_ggtt.c
drm/xe: Make xe_ggtt_node_insert return a node
drm/xe: Remove xe_ggtt_node_allocated

 .../gpu/drm/xe/compat-i915-headers/i915_vma.h |   4 +-
 drivers/gpu/drm/xe/display/xe_fb_pin.c        | 114 ++---
 drivers/gpu/drm/xe/display/xe_stolen.c        |   2 +-
 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c   |   8 +-
 drivers/gpu/drm/xe/xe_bo.c                    |   6 +-
 drivers/gpu/drm/xe/xe_bo.h                    |   8 +-
 drivers/gpu/drm/xe/xe_device_types.h          |   2 -
 drivers/gpu/drm/xe/xe_ggtt.c                  | 476 +++++++++---------
 drivers/gpu/drm/xe/xe_ggtt.h                  |  27 +-
 drivers/gpu/drm/xe/xe_ggtt_types.h            |  78 +--
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c    |  53 +-
 .../gpu/drm/xe/xe_gt_sriov_pf_config_types.h  |   8 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c           |   5 +-
 drivers/gpu/drm/xe/xe_pci.c                   |   7 +
 drivers/gpu/drm/xe/xe_tile_sriov_vf.c         | 197 +-------
 drivers/gpu/drm/xe/xe_tile_sriov_vf.h         |   4 +-
 drivers/gpu/drm/xe/xe_tile_sriov_vf_types.h   |   4 +
 17 files changed, 391 insertions(+), 612 deletions(-)
Signature · 1 line
2.51.0