cgroup: nmi safe css_rstat_updated
Status from this message: Applied to cgroup/for-6.17.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyApplied
- v24 patches 6 repliesSuperseded
- v13 patches 11 repliesSuperseded
Changes in v3 from the cover letter
- Add more clear explanation in cover letter and in the comment as suggested by Andrew, Michal & Tejun.
- Use this_cpu_cmpxchg() instead of try_cmpxchg() as suggested by Tejun.
- Remove the per-cpu ss locks as they are not needed anymore.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | cgroup: support to enable nmi-safe css_rstat_updatedinclude/ kernel/ | +25 | 0 replies | |
| 2/4 | cgroup: make css_rstat_updated nmi safekernel/ | +53 | 0 replies | |
| 3/4 | cgroup: remove per-cpu per-subsystem locksinclude/ include/ kernel/ | +4 | 0 replies | |
| 4/4 | memcg: cgroup: call css_rstat_updated irrespective of in_nmi()mm/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/4] cgroup: nmi safe css_rstat_updated
BPF programs can run in nmi context and may trigger memcg charged memory allocation in such context. Recently linux added support to nmi safe page allocation along with memcg charging of such allocations. However the kmalloc/slab support and corresponding memcg charging is still lacking,
To provide nmi safe support for memcg charging for kmalloc/slab allocations, we need nmi safe memcg stats because for kernel memory charging and stats happen together. At the moment, memcg charging and memcg stats are nmi safe and the only thing which is not nmi safe is adding the cgroup to the per-cpu rstat update tree. i.e. css_rstat_updated() which this series is doing.
This series made css_rstat_updated by using per-cpu lockless lists whose node in embedded in individual struct cgroup_subsys_state and the per-cpu head is placed in struct cgroup_subsys. For rstat users without cgroup_subsys, a global per-cpu lockless list head is created. The main challenge to use lockless in this scenario was the potential multiple inserters from the stacked context i.e. process, softirq, hardirq & nmi, potentially using the same per-cpu lockless node of a given cgroup_subsys_state. The normal lockless list does not protect against such scenario.
The multiple stacked inserters using potentially same lockless node was resolved by making one of them succeed on reset the lockless node and the
winner gets to insert the lockless node in the corresponding lockless list. The losers can assume the lockless list insertion will eventually succeed and continue their operation.
Changelog since v3:
- Rebased on for-6.17 branch of cgroup tree
Changelog since v2:
- Add more clear explanation in cover letter and in the comment as suggested by Andrew, Michal & Tejun.
- Use this_cpu_cmpxchg() instead of try_cmpxchg() as suggested by Tejun.
- Remove the per-cpu ss locks as they are not needed anymore.
Changelog since v1:
- Based on Yosry's suggestion always use llist on the update side and create the update tree on flush side
[v1]
https://lore.kernel.org/cgroups/[email protected]/
Shakeel Butt (4):
cgroup: support to enable nmi-safe css_rstat_updated
cgroup: make css_rstat_updated nmi safe
cgroup: remove per-cpu per-subsystem locks
memcg: cgroup: call css_rstat_updated irrespective of in_nmi()
include/linux/cgroup-defs.h | 11 +-- include/trace/events/cgroup.h | 47 ---------- kernel/cgroup/rstat.c | 158 ++++++++++++++-------------------- mm/memcontrol.c | 10 +-- 4 files changed, 72 insertions(+), 154 deletions(-)
Signature · 1 line
2.47.1