Skip to content

fbdev: Fix warnings related to including <linux/export.h>

Thomas Zimmermann dri-devel linux-arm-kernel linux-fbdev linux-omap 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 8 repliesIn review
  2. v114 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- remove unused functions (Helge)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14fbdev: Remove trailing whitespacesdrivers/video/fbdev/macmodes.c+1 -10 replies
2/14fbdev: Include <linux/export.h>drivers/video/fbdev/core/cfbcopyarea.c drivers/video/fbdev/core/cfbfillrect.c drivers/video/fbdev/core/cfbimgblt.c +15 more+26 -00 replies
3/14fbdev/c2p: Include <linux/export.h>drivers/video/fbdev/c2p_iplan2.c drivers/video/fbdev/c2p_planar.c+2 -00 replies
4/14fbdev/cyber2000fb: Unexport symbolsdrivers/video/fbdev/cyber2000fb.c drivers/video/fbdev/cyber2000fb.h+0 -381 reply
5/14fbdev/matroxfb: Remove trailing whitespacesdrivers/video/fbdev/matrox/g450_pll.c drivers/video/fbdev/matrox/matroxfb_DAC1064.c drivers/video/fbdev/matrox/matroxfb_g450.c +1 more+75 -750 replies
6/14fbdev/matroxfb: Include <linux/export.h>drivers/video/fbdev/matrox/g450_pll.c drivers/video/fbdev/matrox/matroxfb_DAC1064.c drivers/video/fbdev/matrox/matroxfb_Ti3026.c +4 more+10 -00 replies
7/14fbdev/omap: Include <linux/export.h>drivers/video/fbdev/omap/lcd_dma.c drivers/video/fbdev/omap/lcdc.c drivers/video/fbdev/omap/omapfb_main.c+5 -00 replies
8/14fbdev/omap2: Include <linux/export.h>drivers/video/fbdev/omap2/omapfb/dss/apply.c drivers/video/fbdev/omap2/omapfb/dss/core.c drivers/video/fbdev/omap2/omapfb/dss/dispc-compat.c +8 more+11 -01 reply
9/14fbdev/omap2: Do not include <linux/export.h>drivers/video/fbdev/omap2/omapfb/dss/dpi.c drivers/video/fbdev/omap2/omapfb/dss/sdi.c drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c+0 -31 reply
10/14fbdev/mb862xx: Do not include <linux/export.h>drivers/video/fbdev/mb862xx/mb862xx-i2c.c+0 -11 reply
11/14fbdev/pxafb: Unexport symboldrivers/video/fbdev/pxafb.c include/linux/platform_data/video-pxafb.h+2 -161 reply
12/14fbdev/sisfb: Unexport symbolsdrivers/video/fbdev/sis/sis.h drivers/video/fbdev/sis/sis_main.c include/video/sisfb.h+0 -331 reply
13/14fbdev/viafb: Include <linux/export.h>drivers/video/fbdev/via/via-core.c drivers/video/fbdev/via/via_i2c.c+2 -01 reply
14/14fbdev/viafb: Do not include <linux/export.h>drivers/video/fbdev/via/via-gpio.c+0 -11 reply

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchHelge Deller
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] fbdev: Fix warnings related to including <linux/export.h>

Some source files in fbdev do not include <linux/export.h> properly; others do when they don't have to. The build scripts warn about these cases.

Clean up to fix the related warnings. While at it, also fix trailing whitespaces in the affected files.

v2:
- remove unused functions (Helge)

Thomas Zimmermann (14):
fbdev: Remove trailing whitespaces
fbdev: Include <linux/export.h>
fbdev/c2p: Include <linux/export.h>
fbdev/cyber2000fb: Unexport symbols
fbdev/matroxfb: Remove trailing whitespaces
fbdev/matroxfb: Include <linux/export.h>
fbdev/omap: Include <linux/export.h>
fbdev/omap2: Include <linux/export.h>
fbdev/omap2: Do not include <linux/export.h>
fbdev/mb862xx: Do not include <linux/export.h>
fbdev/pxafb: Unexport symbol
fbdev/sisfb: Unexport symbols
fbdev/viafb: Include <linux/export.h>
fbdev/viafb: Do not include <linux/export.h>

 drivers/video/fbdev/c2p_iplan2.c              |  1 +
 drivers/video/fbdev/c2p_planar.c              |  1 +
 drivers/video/fbdev/core/cfbcopyarea.c        |  2 +
 drivers/video/fbdev/core/cfbfillrect.c        |  2 +
 drivers/video/fbdev/core/cfbimgblt.c          |  2 +
 drivers/video/fbdev/core/fb_ddc.c             |  1 +
 drivers/video/fbdev/core/fb_defio.c           |  1 +
 drivers/video/fbdev/core/fb_io_fops.c         |  1 +
 drivers/video/fbdev/core/fb_sys_fops.c        |  2 +
 drivers/video/fbdev/core/fbcmap.c             |  1 +
 drivers/video/fbdev/core/fbcon.c              |  1 +
 drivers/video/fbdev/core/fbmon.c              |  2 +
 drivers/video/fbdev/core/modedb.c             |  1 +
 drivers/video/fbdev/core/svgalib.c            |  1 +
 drivers/video/fbdev/core/syscopyarea.c        |  2 +
 drivers/video/fbdev/core/sysfillrect.c        |  2 +
 drivers/video/fbdev/core/sysimgblt.c          |  2 +
 drivers/video/fbdev/cyber2000fb.c             | 36 -----------
 drivers/video/fbdev/cyber2000fb.h             |  2 -
 drivers/video/fbdev/macmodes.c                |  3 +-
 drivers/video/fbdev/matrox/g450_pll.c         | 26 ++++----
 drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 47 +++++++-------
 drivers/video/fbdev/matrox/matroxfb_Ti3026.c  |  1 +
 drivers/video/fbdev/matrox/matroxfb_accel.c   |  2 +
 drivers/video/fbdev/matrox/matroxfb_base.c    |  1 +
 drivers/video/fbdev/matrox/matroxfb_g450.c    | 62 ++++++++++---------
 drivers/video/fbdev/matrox/matroxfb_misc.c    | 21 ++++---
 drivers/video/fbdev/mb862xx/mb862xx-i2c.c     |  1 -
 drivers/video/fbdev/omap/lcd_dma.c            |  1 +
 drivers/video/fbdev/omap/lcdc.c               |  2 +
 drivers/video/fbdev/omap/omapfb_main.c        |  2 +
 drivers/video/fbdev/omap2/omapfb/dss/apply.c  |  1 +
 drivers/video/fbdev/omap2/omapfb/dss/core.c   |  1 +
 .../fbdev/omap2/omapfb/dss/dispc-compat.c     |  1 +
 .../video/fbdev/omap2/omapfb/dss/display.c    |  1 +
 drivers/video/fbdev/omap2/omapfb/dss/dpi.c    |  1 -
 drivers/video/fbdev/omap2/omapfb/dss/dss-of.c |  1 +
 .../fbdev/omap2/omapfb/dss/dss_features.c     |  1 +
 .../video/fbdev/omap2/omapfb/dss/manager.c    |  1 +
 drivers/video/fbdev/omap2/omapfb/dss/output.c |  1 +
 .../video/fbdev/omap2/omapfb/dss/overlay.c    |  1 +
 drivers/video/fbdev/omap2/omapfb/dss/sdi.c    |  1 -
 drivers/video/fbdev/omap2/omapfb/dss/venc.c   |  1 +
 .../video/fbdev/omap2/omapfb/omapfb-ioctl.c   |  1 -
 drivers/video/fbdev/omap2/omapfb/vrfb.c       |  1 +
 drivers/video/fbdev/pxafb.c                   | 17 +----
 drivers/video/fbdev/sbuslib.c                 |  1 +
 drivers/video/fbdev/sis/sis.h                 |  2 -
 drivers/video/fbdev/sis/sis_main.c            | 25 --------
 drivers/video/fbdev/via/via-core.c            |  1 +
 drivers/video/fbdev/via/via-gpio.c            |  1 -
 drivers/video/fbdev/via/via_i2c.c             |  1 +
 drivers/video/fbdev/wmt_ge_rops.c             |  1 +
 include/linux/platform_data/video-pxafb.h     |  1 -
 include/video/sisfb.h                         |  6 --
 55 files changed, 134 insertions(+), 168 deletions(-)
Signature · 1 line
2.49.0