Skip to content

tty: summer cleanup

Jiri Slaby (SUSE) linux-arm-kernel linux-bluetooth linux-m68k linux-mips linux-serial linux-staging linux-usb linuxppc-dev lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest33 patches 58 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33tty: introduce and use tty_port_tty_vhangup() helperdrivers/isdn/capi/capi.c drivers/staging/greybus/uart.c drivers/tty/serial/serial_core.c +5 more+25 -423 replies
2/33powerpc/legacy_serial: cache serial port and info in add_legacy_port()arch/powerpc/kernel/legacy_serial.c+26 -261 reply
3/33powerpc/legacy_serial: use %pa for phys_addr_t printsarch/powerpc/kernel/legacy_serial.c+2 -30 replies
4/33m68k: remove unneeded tty includesarch/m68k/amiga/config.c arch/m68k/apollo/config.c arch/m68k/atari/config.c +2 more+0 -92 replies
5/33powerpc/powermac: remove unneeded tty includesarch/powerpc/platforms/powermac/setup.c+0 -21 reply
6/33tty: vt: use sane types for userspace APIinclude/uapi/linux/vt.h+22 -221 reply
7/33tty: vt: use _IO() to define ioctl numbersinclude/uapi/linux/vt.h+17 -177 replies
8/33serial: 8250: sanitize uart_port::serial_{in,out}() typesarch/powerpc/kernel/legacy_serial.c drivers/tty/serial/8250/8250_dw.c drivers/tty/serial/8250/8250_em.c +9 more+56 -552 replies
9/33serial: 8250: remove CONFIG_SERIAL_8250_RSA inline macros from codedrivers/tty/serial/8250/8250_port.c+27 -272 replies
10/33serial: 8250: invert conditions in RSA functionsdrivers/tty/serial/8250/8250_port.c+34 -251 reply
11/33serial: 8250: put RSA functions to their namespacedrivers/tty/serial/8250/8250_port.c+9 -91 reply
12/33serial: 8250: move RSA functions to 8250_rsa.cdrivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_port.c drivers/tty/serial/8250/8250_rsa.c+100 -991 reply
13/33serial: 8250: extract serial8250_startup_special()drivers/tty/serial/8250/8250_port.c+32 -211 reply
14/33serial: 8250: extract serial8250_set_TRG_levels()drivers/tty/serial/8250/8250_port.c+41 -361 reply
15/33serial: 8250: extract serial8250_THRE_test()drivers/tty/serial/8250/8250_port.c+49 -433 replies
16/33serial: 8250: extract serial8250_initialize()drivers/tty/serial/8250/8250_port.c+50 -532 replies
17/33serial: 8250: extract serial8250_clear_interrupts()drivers/tty/serial/8250/8250_port.c+12 -151 reply
18/33serial: 8250: extract serial8250_set_mini()drivers/tty/serial/8250/8250_port.c+17 -71 reply
19/33serial: 8250: extract serial8250_set_trigger_for_slow_speed()drivers/tty/serial/8250/8250_port.c+19 -71 reply
20/33serial: 8250: extract serial8250_set_afe()drivers/tty/serial/8250/8250_port.c+17 -151 reply
21/33serial: 8250: extract serial8250_set_errors_and_ignoresdrivers/tty/serial/8250/8250_port.c+33 -341 reply
22/33serial: 8250: extract serial8250_set_ier()drivers/tty/serial/8250/8250_port.c+17 -141 reply
23/33serial: 8250: extract serial8250_set_efr()drivers/tty/serial/8250/8250_port.c+25 -186 replies
24/33serial: 8250: extract serial8250_set_fcr()drivers/tty/serial/8250/8250_port.c+26 -151 reply
25/33serial: 8250: lcr compute cleanupdrivers/tty/serial/8250/8250_port.c+10 -131 reply
26/33serial: 8250: drop unused frac from serial8250_do_get_divisor()drivers/tty/serial/8250/8250_port.c+2 -41 reply
27/33serial: 8250: extract serial_get_or_create_irq_info()drivers/tty/serial/8250/8250_core.c+26 -111 reply
28/33serial: 8250: remove debug prints from ISRdrivers/tty/serial/8250/8250_core.c+0 -41 reply
29/33serial: 8250: drop DEBUG_AUTOCONF() macrodrivers/tty/serial/8250/8250_port.c+2 -374 replies
30/33serial: 8250: invert serial8250_register_8250_port() CIR conditiondrivers/tty/serial/8250/8250_core.c+127 -1266 replies
31/33serial: 8250: invert condition to avoid a goto labeldrivers/tty/serial/8250/8250_port.c+10 -121 reply
32/33serial: 8250: use hashtabledrivers/tty/serial/8250/8250_core.c+8 -161 reply
33/33serial: 8250_omap: use uart_port pointer when availabledrivers/tty/serial/8250/8250_omap.c+27 -260 replies

Reviews trailers per patch

25 of 33 patches have a Reviewed-by or Acked-by.

PatchIlpo JärvinenNicolas PitreAndy ShevchenkoGeert Uytterhoeven
1/33R-b
2/33R-b
3/33
4/33R-b R-b A-b
5/33R-b
6/33R-b
7/33R-b R-b
8/33R-b
9/33R-b
10/33R-b
11/33R-b
12/33R-b
13/33R-b
14/33R-b
15/33
16/33
17/33R-b
18/33R-b
19/33R-b
20/33R-b
21/33
22/33R-b
23/33
24/33R-b
25/33R-b
26/33R-b
27/33R-b
28/33R-b
29/33R-b
30/33R-b
31/33
32/33
33/33

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/33] tty: summer cleanup

Hi,

this is (yet) another series of various cleanup in tty of issues which popped up at me during a larger rework.

Jiri Slaby (SUSE) (33):
tty: introduce and use tty_port_tty_vhangup() helper powerpc/legacy_serial: cache serial port and info in add_legacy_port() powerpc/legacy_serial: use %pa for phys_addr_t prints
m68k: remove unneeded tty includes
powerpc/powermac: remove unneeded tty includes
tty: vt: use sane types for userspace API
tty: vt: use _IO() to define ioctl numbers
serial: 8250: sanitize uart_port::serial_{in,out}() types
serial: 8250: remove CONFIG_SERIAL_8250_RSA inline macros from code
serial: 8250: invert conditions in RSA functions
serial: 8250: put RSA functions to their namespace
serial: 8250: move RSA functions to 8250_rsa.c
serial: 8250: extract serial8250_startup_special()
serial: 8250: extract serial8250_set_TRG_levels()
serial: 8250: extract serial8250_THRE_test()
serial: 8250: extract serial8250_initialize()
serial: 8250: extract serial8250_clear_interrupts()
serial: 8250: extract serial8250_set_mini()
serial: 8250: extract serial8250_set_trigger_for_slow_speed()
serial: 8250: extract serial8250_set_afe()
serial: 8250: extract serial8250_set_errors_and_ignores
serial: 8250: extract serial8250_set_ier()
serial: 8250: extract serial8250_set_efr()
serial: 8250: extract serial8250_set_fcr()
serial: 8250: lcr compute cleanup
serial: 8250: drop unused frac from serial8250_do_get_divisor()
serial: 8250: extract serial_get_or_create_irq_info()
serial: 8250: remove debug prints from ISR
serial: 8250: drop DEBUG_AUTOCONF() macro
serial: 8250: invert serial8250_register_8250_port() CIR condition
serial: 8250: invert condition to avoid a goto label
serial: 8250: use hashtable
serial: 8250_omap: use uart_port pointer when available

 arch/m68k/amiga/config.c                |   2 -
 arch/m68k/apollo/config.c               |   2 -
 arch/m68k/atari/config.c                |   1 -
 arch/m68k/mac/config.c                  |   2 -
 arch/m68k/q40/config.c                  |   2 -
 arch/powerpc/kernel/legacy_serial.c     |  62 +-
 arch/powerpc/platforms/powermac/setup.c |   2 -
 drivers/isdn/capi/capi.c                |   8 +-
 drivers/staging/greybus/uart.c          |   7 +-
 drivers/tty/serial/8250/8250.h          |   8 +
 drivers/tty/serial/8250/8250_core.c     | 316 +++++-----
 drivers/tty/serial/8250/8250_dw.c       |  34 +-
 drivers/tty/serial/8250/8250_em.c       |   4 +-
 drivers/tty/serial/8250/8250_ingenic.c  |   8 +-
 drivers/tty/serial/8250/8250_ioc3.c     |   4 +-
 drivers/tty/serial/8250/8250_lpc18xx.c  |   2 +-
 drivers/tty/serial/8250/8250_omap.c     |  53 +-
 drivers/tty/serial/8250/8250_pci.c      |   6 +-
 drivers/tty/serial/8250/8250_port.c     | 736 +++++++++++-------------
 drivers/tty/serial/8250/8250_rsa.c      |  92 +++
 drivers/tty/serial/8250/8250_rt288x.c   |   4 +-
 drivers/tty/serial/8250/8250_uniphier.c |   4 +-
 drivers/tty/serial/serial_core.c        |   7 +-
 drivers/tty/tty_port.c                  |  12 +-
 drivers/usb/class/cdc-acm.c             |   7 +-
 drivers/usb/serial/usb-serial.c         |   7 +-
 include/linux/serial_8250.h             |   4 +-
 include/linux/serial_core.h             |   4 +-
 include/linux/tty_port.h                |  12 +-
 include/uapi/linux/vt.h                 |  78 +--
 net/bluetooth/rfcomm/tty.c              |   7 +-
 31 files changed, 751 insertions(+), 746 deletions(-)
Signature · 1 line
2.49.0