mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 7 repliesIn review 2 of 3 applied
- v23 patches 31 repliesSuperseded
Changes in v3 from the cover letter
* Added tags (thanks for all the review!)
* Smaller fixups (add empty lines) and patch description improvements
Patches in v3 2 of 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()mm/ | +3 | 1 reply | |
| 2/3 | mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()mm/ | +40 | 5 replies | Applied |
| 3/3 | mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()include/ mm/ | +47 | 1 reply | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Dan Williams | Lorenzo Stoakes | Jason Gunthorpe | Oscar Salvador |
|---|---|---|---|---|
| 1/3 | R-b T-b | R-b | R-b | R-b |
| 2/3 | R-b T-b | R-b | R-b | R-b R-b |
| 3/3 | R-b T-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes
Based on mm/mm-unstable.
While working on improving vm_normal_page() and friends, I stumbled over this issues: refcounted "normal" folios must not be marked using pmd_special() / pud_special(). Otherwise, we're effectively telling the system that these folios are no "normal", violating the rules we documented for vm_normal_page().
Fortunately, there are not many pmd_special()/pud_special() users yet. So far there doesn't seem to be serious damage.
Tested using the ndctl tests ("ndctl:dax" suite).
v2 -> v3:
* Added tags (thanks for all the review!)
* Smaller fixups (add empty lines) and patch description improvements
v1 -> v2:
* "mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()" -> Added after stumbling over that
* Modified the other tests to reuse the existing function by passing a new struct
* Renamed the patches to talk about "folios" instead of pages and adjusted the patch descriptions
* Dropped RB/TB from Dan and Oscar due to the changes
David Hildenbrand (3):
mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() mm/huge_memory: don't mark refcounted folios special in
vmf_insert_folio_pmd()
mm/huge_memory: don't mark refcounted folios special in
vmf_insert_folio_pud()
include/linux/mm.h | 19 +++++++- mm/huge_memory.c | 112 ++++++++++++++++++++++++++++----------------- 2 files changed, 87 insertions(+), 44 deletions(-)
Signature · 1 line
2.49.0