Skip to content

net: ethtool: add dedicated RXFH driver callbacks

Jakub Kicinski linux-hyperv linux-rdma netdev oe-kbuild oe-kbuild-all virtualization 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 11 repliesApplied 9/9

Patches in v1 All 9 applied

#Subject and filesSizeRepliesApplied
1/9net: ethtool: copy the rxfh flow handlingnet/ethtool/ioctl.c+92 -11 replyApplied
2/9net: ethtool: remove the duplicated handling from rxfh and rxnfcnet/ethtool/ioctl.c+5 -521 replyApplied
3/9net: ethtool: require drivers to opt into the per-RSS ctx RXFHdrivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c drivers/net/ethernet/sfc/ethtool.c include/linux/ethtool.h +1 more+13 -01 replyApplied
4/9net: ethtool: add dedicated callbacks for getting and setting rxfh fieldsinclude/linux/ethtool.h net/ethtool/ioctl.c+65 -104 repliesApplied
5/9eth: remove empty RXFH handling from driversdrivers/net/ethernet/google/gve/gve_ethtool.c drivers/net/ethernet/marvell/mvneta.c+0 -81 replyApplied
6/9eth: fbnic: migrate to new RXFH callbacksdrivers/net/ethernet/meta/fbnic/fbnic_ethtool.c+56 -550 repliesApplied
7/9net: drv: vmxnet3: migrate to new RXFH callbacksdrivers/net/vmxnet3/vmxnet3_ethtool.c+25 -490 repliesApplied
8/9net: drv: virtio: migrate to new RXFH callbacksdrivers/net/virtio_net.c+18 -291 replyApplied
9/9net: drv: hyperv: migrate to new RXFH callbacksdrivers/net/hyperv/netvsc_drv.c+11 -190 repliesApplied

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchZiwei XiaoJoe DamatoJason Wang
1/9R-b
2/9R-b
3/9R-b
4/9
5/9R-b
6/9
7/9
8/9A-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/9] net: ethtool: add dedicated RXFH driver callbacks

Andrew asked me to plumb the RXFH header fields configuration thru to netlink. Before we do that we need to clean up the driver facing API a little bit. Right now RXFH configuration shares the callbacks with n-tuple filters. The future of n-tuple filters is uncertain within netlink. Separate the two for clarity both of the core code and the driver facing API.

This series adds the new callbacks and converts the initial handful of drivers. There is 31 more driver patches to come, then we can stop calling rxnfc in the core for rxfh.

Jakub Kicinski (9):
net: ethtool: copy the rxfh flow handling
net: ethtool: remove the duplicated handling from rxfh and rxnfc
net: ethtool: require drivers to opt into the per-RSS ctx RXFH
net: ethtool: add dedicated callbacks for getting and setting rxfh
fields
eth: remove empty RXFH handling from drivers
eth: fbnic: migrate to new RXFH callbacks
net: drv: vmxnet3: migrate to new RXFH callbacks
net: drv: virtio: migrate to new RXFH callbacks
net: drv: hyperv: migrate to new RXFH callbacks

 include/linux/ethtool.h                       |  23 ++++
 drivers/net/ethernet/google/gve/gve_ethtool.c |   6 -
 drivers/net/ethernet/marvell/mvneta.c         |   2 -
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |   1 +
 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   | 111 ++++++++--------
 drivers/net/ethernet/sfc/ethtool.c            |   1 +
 drivers/net/hyperv/netvsc_drv.c               |  30 ++---
 drivers/net/virtio_net.c                      |  47 +++----
 drivers/net/vmxnet3/vmxnet3_ethtool.c         |  74 ++++-------
 net/ethtool/ioctl.c                           | 121 +++++++++++++++---
 10 files changed, 239 insertions(+), 177 deletions(-)
Signature · 1 line
2.49.0