Skip to content

xfs: support on by default errortags

Brian Foster linux-xfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: support on by default errortagsfs/xfs/xfs_error.c fs/xfs/xfs_mount.h+43 -20 replies
2/3xfs: convert extent alloc debug fallback to errortagfs/xfs/libxfs/xfs_alloc.c fs/xfs/libxfs/xfs_errortag.h fs/xfs/xfs_error.c+7 -50 replies
3/3xfs: convert sparse inode alloc debug fallback to errortagfs/xfs/libxfs/xfs_errortag.h fs/xfs/libxfs/xfs_ialloc.c fs/xfs/xfs_error.c+11 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] xfs: support on by default errortags

Hi all,

This is a quick side quest based on the discussion on the iomap folio batch series here[1]. I could see this going a number of different ways and/or being enhanced in the future. For example, we could have per-tag warning state instead of the global op state, dynamic default configuration, put this behind a kconfig option, etc. My goal here is really just to implement enough to keep things simple and pretty close to existing XFS_DEBUG behavior.

Ultimately if people are Ok with something like this, I'll change the force zero tag in the iomap series to on by default. If not, I'll just leave it as is and go with a custom test. Otherwise, this survives a first run through fstests without any explosions or spurious failures.

Thoughts, reviews, flames appreciated.

Brian

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Brian Foster (3):
xfs: support on by default errortags
xfs: convert extent alloc debug fallback to errortag
xfs: convert sparse inode alloc debug fallback to errortag

 fs/xfs/libxfs/xfs_alloc.c    |  5 +---
 fs/xfs/libxfs/xfs_errortag.h |  6 ++++-
 fs/xfs/libxfs/xfs_ialloc.c   | 14 ++++-------
 fs/xfs/xfs_error.c           | 48 ++++++++++++++++++++++++++++++++++--
 fs/xfs/xfs_mount.h           |  3 +++
 5 files changed, 60 insertions(+), 16 deletions(-)
Signature · 1 line
2.49.0