Skip to content

Improve optimal IO size initialization

Damien Le Moal linux-scsi 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 4 repliesIn review
  2. v32 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- Change logical_to_bytes() to return a u64 in patch 1
- Added review tag to patch 2

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2scsi: sd: Prevent logical_to_bytes() from returning overflowed valuesdrivers/scsi/sd.h+2 -21 reply
2/2scsi: sd: Set a default optimal IO size if one is not defineddrivers/scsi/sd.c+35 -103 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchBart Van Assche
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] Improve optimal IO size initialization

A couple of patches to improve setting the optimal I/O size limit of scsi disks. A fallback default is added to make sure we always have a non-zero optimal I/O size so that file systems operate with a reasonnably sized default read_ahead_kb value, for improving buffered read performance.

Changes from v1:
- Changed message level from wrong WARNING level to INFO level
- Added review tag

Changes from v2:
- Added patch 1
- Make sure we do not overflow variables and limits in patch 2

Changes from v3:
- Change logical_to_bytes() to return a u64 in patch 1
- Added review tag to patch 2

Damien Le Moal (2):
scsi: sd: Prevent logical_to_bytes() from returning overflowed values
scsi: sd: Set a default optimal IO size if one is not defined

 drivers/scsi/sd.c | 45 +++++++++++++++++++++++++++++++++++----------
 drivers/scsi/sd.h |  4 ++--
 2 files changed, 37 insertions(+), 12 deletions(-)
Signature · 1 line
2.49.0