i3c: aspeed: Add I3C support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest19 patches 27 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | hw/misc/aspeed_i3c: Move to i3c directoryhw/ hw/ hw/ +10 more | +20 | 3 replies | |
| 2/19 | hw/i3c: Add bus supporthw/ hw/ hw/ +1 more | +946 | 1 reply | |
| 3/19 | hw/i3c: Split DesignWare I3C out of Aspeed I3Chw/ hw/ hw/ +5 more | +254 | 1 reply | |
| 4/19 | hw/i3c/dw-i3c: Add more register fieldshw/ | +216 | 2 replies | |
| 5/19 | hw/i3c/aspeed_i3c: Add more register fieldshw/ | +42 | 1 reply | |
| 6/19 | hw/i3c/dw-i3c: Add more reset valueshw/ | +19 | 2 replies | |
| 7/19 | hw/i3c/aspeed_i3c: Add register RO field maskshw/ | +16 | 1 reply | |
| 8/19 | hw/i3c/dw-i3c: Add register RO field maskshw/ | +40 | 2 replies | |
| 9/19 | hw/i3c/dw-i3c: Treat more registers as read-as-zerohw/ | +3 | 1 reply | |
| 10/19 | hw/i3c/dw-i3c: Use 32 bits on MMIO writeshw/ | +3 | 1 reply | |
| 11/19 | hw/i3c/dw-i3c: Add IRQ MMIO behaviorhw/ | +56 | 1 reply | |
| 12/19 | hw/i3c/dw-i3c: Add data TX and RXhw/ hw/ include/ +1 more | +1030 | 0 replies | |
| 13/19 | hw/i3c/dw-i3c: Add IBI handlinghw/ hw/ include/ | +346 | 0 replies | |
| 14/19 | hw/i3c/dw-i3c: Add ctrl MMIO handlinghw/ | +35 | 1 reply | |
| 15/19 | hw/i3c/dw-i3c: Add controller resetshw/ hw/ | +118 | 1 reply | |
| 16/19 | hw/i3c/aspeed: Add I3C bus get functionhw/ include/ | +11 | 1 reply | |
| 17/19 | hw/i3c: Add Mock targethw/ hw/ hw/ +2 more | +383 | 1 reply | |
| 18/19 | hw/arm/aspeed: Build with I3C_DEVICEShw/ | +1 | 1 reply | |
| 19/19 | hw/i3c: Add hotplug supporthw/ | +17 | 0 replies |
Reviews trailers per patch
18 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Patrick Venture | Titus Rwantare | Hao Wu | Stephen Longfield | Cédric Le Goater | Jamin Lin |
|---|---|---|---|---|---|---|
| Series | T-b | |||||
| 1/19 | R-b | R-b | R-b | R-b | ||
| 2/19 | R-b | R-b | R-b | |||
| 3/19 | ||||||
| 4/19 | R-b | R-b | ||||
| 5/19 | R-b | R-b | ||||
| 6/19 | R-b | R-b | ||||
| 7/19 | R-b | |||||
| 8/19 | R-b | |||||
| 9/19 | R-b | R-b | ||||
| 10/19 | R-b | R-b | R-b | |||
| 11/19 | R-b | R-b | R-b | |||
| 12/19 | R-b | R-b | ||||
| 13/19 | R-b | R-b | ||||
| 14/19 | R-b | R-b | R-b | |||
| 15/19 | R-b | R-b | R-b | |||
| 16/19 | R-b | |||||
| 17/19 | R-b | R-b | T-b | |||
| 18/19 | R-b | |||||
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH 00/19] i3c: aspeed: Add I3C support
Hi all,
This series adds I3C bus support to QEMU and adds more functionality to the Aspeed I3C controller.
This implementation is a basic implementation that introduces IBIs (including hot-join), CCCs, and SDR data transfer. As-is, it doesn't support multi-controller buses or HDR transfers.
First we add the I3C bus and controller model. With that added we extend the functionality of the Aspeed I3C controller so it can do transfers and handle IBIs.
Next, we add a mock I3C target. It's intended to be a very simple target just to verify that I3C is working on the guest. Internally, we've used it on Linux to verify that i3C devices can be probed and can send/receive data and IBIs.
This target is sort of like an EEPROM, and it can also send IBIs upon reception of a user-defined magic number.
Lastly we add hotplugging support. The hotplugging doesn't do anything too complicated, it just adds the device attempting to hotplug to the bus. It is the device's responsibility to hot-join and go through the DAA process to participate on the bus.
Thanks,
Joe
Joe Komlodi (19):
hw/misc/aspeed_i3c: Move to i3c directory hw/i3c: Add bus support
hw/i3c: Split DesignWare I3C out of Aspeed I3C hw/i3c/dw-i3c: Add more register fields hw/i3c/aspeed_i3c: Add more register fields hw/i3c/dw-i3c: Add more reset values hw/i3c/aspeed_i3c: Add register RO field masks hw/i3c/dw-i3c: Add register RO field masks hw/i3c/dw-i3c: Treat more registers as read-as-zero hw/i3c/dw-i3c: Use 32 bits on MMIO writes hw/i3c/dw-i3c: Add IRQ MMIO behavior hw/i3c/dw-i3c: Add data TX and RX hw/i3c/dw-i3c: Add IBI handling hw/i3c/dw-i3c: Add ctrl MMIO handling hw/i3c/dw-i3c: Add controller resets hw/i3c/aspeed: Add I3C bus get function hw/i3c: Add Mock target
hw/arm/aspeed: Build with I3C_DEVICES hw/i3c: Add hotplug support
hw/Kconfig | 1 +
hw/arm/Kconfig | 3 +
hw/i3c/Kconfig | 15 +
hw/i3c/aspeed_i3c.c | 261 ++++
hw/i3c/core.c | 669 +++++++++
hw/i3c/dw-i3c.c | 1881 +++++++++++++++++++++++++
hw/i3c/meson.build | 6 +
hw/i3c/mock-i3c-target.c | 311 ++++
hw/i3c/trace-events | 47 +
hw/i3c/trace.h | 2 +
hw/meson.build | 1 +
hw/misc/aspeed_i3c.c | 383 -----
hw/misc/meson.build | 1 -
hw/misc/trace-events | 6 -
include/hw/arm/aspeed_soc.h | 2 +-
include/hw/{misc => i3c}/aspeed_i3c.h | 22 +-
include/hw/i3c/dw-i3c.h | 201 +++
include/hw/i3c/i3c.h | 277 ++++
include/hw/i3c/mock-i3c-target.h | 52 +
meson.build | 1 +
20 files changed, 3735 insertions(+), 407 deletions(-)
create mode 100644 hw/i3c/Kconfig
create mode 100644 hw/i3c/aspeed_i3c.c
create mode 100644 hw/i3c/core.c
create mode 100644 hw/i3c/dw-i3c.c
create mode 100644 hw/i3c/meson.build
create mode 100644 hw/i3c/mock-i3c-target.c
create mode 100644 hw/i3c/trace-events
create mode 100644 hw/i3c/trace.h
delete mode 100644 hw/misc/aspeed_i3c.c
rename include/hw/{misc => i3c}/aspeed_i3c.h (63%)
create mode 100644 include/hw/i3c/dw-i3c.h
create mode 100644 include/hw/i3c/i3c.h
create mode 100644 include/hw/i3c/mock-i3c-target.hSignature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog