Skip to content

i3c: aspeed: Add I3C support

Joe Komlodi qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19hw/misc/aspeed_i3c: Move to i3c directoryhw/Kconfig hw/arm/Kconfig hw/i3c/Kconfig +10 more+20 -93 replies
2/19hw/i3c: Add bus supporthw/i3c/core.c hw/i3c/meson.build hw/i3c/trace-events +1 more+946 -01 reply
3/19hw/i3c: Split DesignWare I3C out of Aspeed I3Chw/arm/Kconfig hw/i3c/Kconfig hw/i3c/aspeed_i3c.c +5 more+254 -1981 reply
4/19hw/i3c/dw-i3c: Add more register fieldshw/i3c/dw-i3c.c+216 -02 replies
5/19hw/i3c/aspeed_i3c: Add more register fieldshw/i3c/aspeed_i3c.c+42 -121 reply
6/19hw/i3c/dw-i3c: Add more reset valueshw/i3c/dw-i3c.c+19 -12 replies
7/19hw/i3c/aspeed_i3c: Add register RO field maskshw/i3c/aspeed_i3c.c+16 -01 reply
8/19hw/i3c/dw-i3c: Add register RO field maskshw/i3c/dw-i3c.c+40 -02 replies
9/19hw/i3c/dw-i3c: Treat more registers as read-as-zerohw/i3c/dw-i3c.c+3 -01 reply
10/19hw/i3c/dw-i3c: Use 32 bits on MMIO writeshw/i3c/dw-i3c.c+3 -21 reply
11/19hw/i3c/dw-i3c: Add IRQ MMIO behaviorhw/i3c/dw-i3c.c+56 -01 reply
12/19hw/i3c/dw-i3c: Add data TX and RXhw/i3c/dw-i3c.c hw/i3c/trace-events include/hw/i3c/aspeed_i3c.h +1 more+1030 -60 replies
13/19hw/i3c/dw-i3c: Add IBI handlinghw/i3c/dw-i3c.c hw/i3c/trace-events include/hw/i3c/dw-i3c.h+346 -00 replies
14/19hw/i3c/dw-i3c: Add ctrl MMIO handlinghw/i3c/dw-i3c.c+35 -01 reply
15/19hw/i3c/dw-i3c: Add controller resetshw/i3c/dw-i3c.c hw/i3c/trace-events+118 -01 reply
16/19hw/i3c/aspeed: Add I3C bus get functionhw/i3c/aspeed_i3c.c include/hw/i3c/aspeed_i3c.h+11 -01 reply
17/19hw/i3c: Add Mock targethw/i3c/Kconfig hw/i3c/meson.build hw/i3c/mock-i3c-target.c +2 more+383 -01 reply
18/19hw/arm/aspeed: Build with I3C_DEVICEShw/arm/Kconfig+1 -01 reply
19/19hw/i3c: Add hotplug supporthw/i3c/core.c+17 -00 replies

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchPatrick VentureTitus RwantareHao WuStephen LongfieldCédric Le GoaterJamin Lin
SeriesT-b
1/19R-b R-b R-b R-b
2/19R-b R-b R-b
3/19
4/19R-b R-b
5/19R-b R-b
6/19R-b R-b
7/19R-b
8/19R-b
9/19R-b R-b
10/19R-b R-b R-b
11/19R-b R-b R-b
12/19R-b R-b
13/19R-b R-b
14/19R-b R-b R-b
15/19R-b R-b R-b
16/19R-b
17/19R-b R-b T-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 00/19] i3c: aspeed: Add I3C support

Hi all,

This series adds I3C bus support to QEMU and adds more functionality to the Aspeed I3C controller.

This implementation is a basic implementation that introduces IBIs (including hot-join), CCCs, and SDR data transfer. As-is, it doesn't support multi-controller buses or HDR transfers.

First we add the I3C bus and controller model. With that added we extend the functionality of the Aspeed I3C controller so it can do transfers and handle IBIs.

Next, we add a mock I3C target. It's intended to be a very simple target just to verify that I3C is working on the guest. Internally, we've used it on Linux to verify that i3C devices can be probed and can send/receive data and IBIs.
This target is sort of like an EEPROM, and it can also send IBIs upon reception of a user-defined magic number.

Lastly we add hotplugging support. The hotplugging doesn't do anything too complicated, it just adds the device attempting to hotplug to the bus. It is the device's responsibility to hot-join and go through the DAA process to participate on the bus.

Thanks,
Joe

Joe Komlodi (19):
hw/misc/aspeed_i3c: Move to i3c directory hw/i3c: Add bus support
hw/i3c: Split DesignWare I3C out of Aspeed I3C hw/i3c/dw-i3c: Add more register fields hw/i3c/aspeed_i3c: Add more register fields hw/i3c/dw-i3c: Add more reset values hw/i3c/aspeed_i3c: Add register RO field masks hw/i3c/dw-i3c: Add register RO field masks hw/i3c/dw-i3c: Treat more registers as read-as-zero hw/i3c/dw-i3c: Use 32 bits on MMIO writes hw/i3c/dw-i3c: Add IRQ MMIO behavior hw/i3c/dw-i3c: Add data TX and RX hw/i3c/dw-i3c: Add IBI handling hw/i3c/dw-i3c: Add ctrl MMIO handling hw/i3c/dw-i3c: Add controller resets hw/i3c/aspeed: Add I3C bus get function hw/i3c: Add Mock target
hw/arm/aspeed: Build with I3C_DEVICES hw/i3c: Add hotplug support

 hw/Kconfig                            |    1 +
 hw/arm/Kconfig                        |    3 +
 hw/i3c/Kconfig                        |   15 +
 hw/i3c/aspeed_i3c.c                   |  261 ++++
 hw/i3c/core.c                         |  669 +++++++++
 hw/i3c/dw-i3c.c                       | 1881 +++++++++++++++++++++++++
 hw/i3c/meson.build                    |    6 +
 hw/i3c/mock-i3c-target.c              |  311 ++++
 hw/i3c/trace-events                   |   47 +
 hw/i3c/trace.h                        |    2 +
 hw/meson.build                        |    1 +
 hw/misc/aspeed_i3c.c                  |  383 -----
 hw/misc/meson.build                   |    1 -
 hw/misc/trace-events                  |    6 -
 include/hw/arm/aspeed_soc.h           |    2 +-
 include/hw/{misc => i3c}/aspeed_i3c.h |   22 +-
 include/hw/i3c/dw-i3c.h               |  201 +++
 include/hw/i3c/i3c.h                  |  277 ++++
 include/hw/i3c/mock-i3c-target.h      |   52 +
 meson.build                           |    1 +
 20 files changed, 3735 insertions(+), 407 deletions(-)
 create mode 100644 hw/i3c/Kconfig
 create mode 100644 hw/i3c/aspeed_i3c.c
 create mode 100644 hw/i3c/core.c
 create mode 100644 hw/i3c/dw-i3c.c
 create mode 100644 hw/i3c/meson.build
 create mode 100644 hw/i3c/mock-i3c-target.c
 create mode 100644 hw/i3c/trace-events
 create mode 100644 hw/i3c/trace.h
 delete mode 100644 hw/misc/aspeed_i3c.c
 rename include/hw/{misc => i3c}/aspeed_i3c.h (63%)
 create mode 100644 include/hw/i3c/dw-i3c.h
 create mode 100644 include/hw/i3c/i3c.h
 create mode 100644 include/hw/i3c/mock-i3c-target.h
Signature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog