Skip to content

RFC Make NFSD use the vfs_iocb_iter APIs

Chuck Lever linux-nfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 4 repliesIn review
  2. v1 RFC1 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2NFSD: Use vfs_iocb_iter_read()fs/nfsd/vfs.c+6 -21 reply
2/2NFSD: Use vfs_iocb_iter_write()fs/nfsd/vfs.c+6 -51 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNeilBrownJeff LaytonChristoph Hellwig
SeriesR-b R-b
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [RFC PATCH v2 0/2] Make NFSD use the vfs_iocb_iter APIs

From: Chuck Lever <[email protected]>

Mike has expressed interest in making NFSD perform direct, uncached, or asynchronous I/O, independent of how the target file might have been opened by the file cache. To do that, the idea is to pass in RWF_ flags during each VFS read and write.

However, Christoph suggested APIs that already exist which streamline the I/O operation a bit and expose the per-I/O flag setting directly. The suggestion looks to me like a straightforward and sensible general clean up of these code paths.

This series refactors nfsd_iter_read() and nfsd_vfs_write() to use those APIs instead of vfs_iter_read() and vfs_iter_write(), respectively, as a first baby step down this path. No behavior change is expected.

Chuck Lever (2):
NFSD: Use vfs_iocb_iter_read()
NFSD: Use vfs_iocb_iter_write()

 fs/nfsd/vfs.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)
Signature · 1 line
2.49.0