dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 7 repliesIn review
- v11 patch 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocationdrivers/ drivers/ drivers/ +38 more | +62 | 5 replies | |
| 2/2 | !!! TESTING ONLY !!! Allow compile virt-dma users on ARM64 platformdrivers/ drivers/ drivers/ +3 more | +20 | 2 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Keguang Zhang | Amelie Delaunay | Ferry Toth |
|---|---|---|---|---|
| 1/2 | A-b | R-b T-b | A-b T-b | T-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/2] dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocation
Hello!
Here is v2.
I've updated patch accoding to recomendations from Andy Shevchenko:
- where possible I placed #include <linux/interrupt.h> in correct position to keep include list ordered.
Also I provide patch file for Kconfig files. It allows to compile most of virt-dma users on unsupported architecture. I've used ARM64 configuration to compile kernel.
One driver (qcom_adm.o) is impossible to compile on ARM64, and that intended behaviour. It has condition 'depends on (ARCH_QCOM || COMPILE_TEST) && !PHYS_ADDR_T_64BIT' preventing from building it on 64-bit architectures. I've checked it doesn't touch virt-dma fields directly and contains #include <linux/interrupt.h> already. It looks that it doesn't need any changes. Anyway, I tried to compile it and only get the following errors:
/kernel-source/drivers/dma/qcom/qcom_adm.c: In function 'adm_process_fc_descriptors':
/kernel-source/drivers/dma/qcom/qcom_adm.c:245:21: error: assignment to 'u32 *' {aka 'unsigned int *'} from incompatible pointer type 'phys_addr_t *'
{aka 'long long unsigned int *'} [-Werror=incompatible-pointer-types]
245 | src = &achan->slave.src_addr;
| ^
/kernel-source/drivers/dma/qcom/qcom_adm.c:251:21: error: assignment to 'u32 *' {aka 'unsigned int *'} from incompatible pointer type 'phys_addr_t *'
{aka 'long long unsigned int *'} [-Werror=incompatible-pointer-types]
251 | dst = &achan->slave.dst_addr;
| ^
/kernel-source/drivers/dma/qcom/qcom_adm.c: In function 'adm_process_non_fc_descriptors':
/kernel-source/drivers/dma/qcom/qcom_adm.c:309:21: error: assignment to 'u32 *' {aka 'unsigned int *'} from incompatible pointer type 'phys_addr_t *'
{aka 'long long unsigned int *'} [-Werror=incompatible-pointer-types]
309 | src = &achan->slave.src_addr;
| ^
/kernel-source/drivers/dma/qcom/qcom_adm.c:313:21: error: assignment to 'u32 *' {aka 'unsigned int *'} from incompatible pointer type 'phys_addr_t *'
{aka 'long long unsigned int *'} [-Werror=incompatible-pointer-types]
313 | dst = &achan->slave.dst_addr;
| ^
/kernel-source/drivers/dma/qcom/qcom_adm.c: In function 'adm_dma_probe':
/kernel-source/drivers/dma/qcom/qcom_adm.c:77:41: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744072371568648' to '2956984328' [-Woverflow]
77 | #define ADM_CI_RANGE_START(x) ((x) << 16)
/kernel-source/drivers/dma/qcom/qcom_adm.c:848:16: note: in expansion of macro 'ADM_CI_RANGE_START'
848 | writel(ADM_CI_RANGE_START(0x40) | ADM_CI_RANGE_END(0xb0) |
In order to detect all users of virt-dma, I did following.
I got all include files containing 'virt-dma.h' or 'struct virt_dma_chan'.
$ git grep -l -e virt-dma.h -e 'struct virt_dma_chan' -- '*.h' drivers/dma/amd/ae4dma/ae4dma.h drivers/dma/amd/ptdma/ptdma.h drivers/dma/amd/qdma/qdma.h drivers/dma/dw-axi-dmac/dw-axi-dmac.h drivers/dma/dw-edma/dw-edma-core.h drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h drivers/dma/fsl-edma-common.h drivers/dma/hsu/hsu.h drivers/dma/idma64.h drivers/dma/sf-pdma/sf-pdma.h drivers/dma/st_fdma.h drivers/dma/virt-dma.h
I got all include files containing all include files found in step 1:
$ git grep -l -e ae4dma.h -e ptdma.h -e qdma.h -e dw-axi-dmac.h \
-e dw-edma-core.h -e dpaa2-qdma.h -e fsl-edma-common.h \
-e hsu.h -e idma64.h -e sf-pdma.h -e st_fdma.h -e virt-dma.h \
-e 'struct virt_dma_chan' -- '*.h'
drivers/dma/amd/ae4dma/ae4dma.h
drivers/dma/amd/ptdma/ptdma.h
drivers/dma/amd/qdma/qdma.h
drivers/dma/dw-axi-dmac/dw-axi-dmac.h
drivers/dma/dw-edma/dw-edma-core.h
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h
drivers/dma/fsl-edma-common.h
drivers/dma/hsu/hsu.h
drivers/dma/idma64.h
drivers/dma/sf-pdma/sf-pdma.h
drivers/dma/st_fdma.h
drivers/dma/virt-dma.h
drivers/net/ethernet/mediatek/mtk_eth_soc.h
include/linux/dma/hsu.hAfter that I got all users of virt dma:
$ git grep -l -e ae4dma.h -e ptdma.h -e qdma.h -e dw-axi-dmac.h \
-e dw-edma-core.h -e dpaa2-qdma.h -e fsl-edma-common.h \
-e hsu.h -e idma64.h -e sf-pdma.h -e st_fdma.h -e virt-dma.h \
-e mtk_eth_soc.h -e 'struct virt_dma_chan' -- '*.c'drivers/dma/amba-pl08x.cdrivers/dma/amd/ae4dma/ae4dma-dev.cdrivers/dma/amd/ae4dma/ae4dma-pci.cdrivers/dma/amd/ptdma/ptdma-debugfs.cdrivers/dma/amd/ptdma/ptdma-dev.cdrivers/dma/amd/ptdma/ptdma-dmaengine.cdrivers/dma/amd/ptdma/ptdma-pci.cdrivers/dma/amd/qdma/qdma-comm-regs.cdrivers/dma/amd/qdma/qdma.cdrivers/dma/arm-dma350.cdrivers/dma/at_hdmac.cdrivers/dma/bcm2835-dma.cdrivers/dma/dma-axi-dmac.cdrivers/dma/dma-jz4780.cdrivers/dma/dw-axi-dmac/dw-axi-dmac-platform.cdrivers/dma/dw-edma/dw-edma-core.cdrivers/dma/dw-edma/dw-edma-pcie.cdrivers/dma/dw-edma/dw-edma-v0-core.cdrivers/dma/dw-edma/dw-edma-v0-debugfs.cdrivers/dma/dw-edma/dw-hdma-v0-core.cdrivers/dma/dw-edma/dw-hdma-v0-debugfs.cdrivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.cdrivers/dma/fsl-edma-common.cdrivers/dma/fsl-edma-main.cdrivers/dma/fsl-edma-trace.cdrivers/dma/fsl-qdma.cdrivers/dma/hisi_dma.cdrivers/dma/hsu/hsu.cdrivers/dma/hsu/pci.cdrivers/dma/idma64.cdrivers/dma/img-mdc-dma.cdrivers/dma/imx-sdma.cdrivers/dma/k3dma.cdrivers/dma/lgm/lgm-dma.cdrivers/dma/loongson1-apb-dma.cdrivers/dma/loongson2-apb-dma.cdrivers/dma/mcf-edma-main.cdrivers/dma/mediatek/mtk-cqdma.cdrivers/dma/mediatek/mtk-hsdma.cdrivers/dma/mediatek/mtk-uart-apdma.cdrivers/dma/milbeaut-hdmac.cdrivers/dma/milbeaut-xdmac.cdrivers/dma/moxart-dma.cdrivers/dma/owl-dma.cdrivers/dma/pxa_dma.cdrivers/dma/qcom/bam_dma.cdrivers/dma/qcom/gpi.cdrivers/dma/qcom/qcom_adm.cdrivers/dma/sa11x0-dma.cdrivers/dma/sf-pdma/sf-pdma.cdrivers/dma/sh/rz-dmac.cdrivers/dma/sh/usb-dmac.cdrivers/dma/sprd-dma.cdrivers/dma/st_fdma.cdrivers/dma/stm32/stm32-dma.cdrivers/dma/stm32/stm32-dma3.cdrivers/dma/stm32/stm32-mdma.cdrivers/dma/sun4i-dma.cdrivers/dma/sun6i-dma.cdrivers/dma/tegra186-gpc-dma.cdrivers/dma/tegra210-adma.cdrivers/dma/ti/edma.cdrivers/dma/ti/k3-udma.cdrivers/dma/ti/omap-dma.cdrivers/dma/uniphier-mdmac.cdrivers/dma/uniphier-xdmac.cdrivers/dma/virt-dma.cdrivers/dma/xilinx/xdma.cdrivers/dma/xilinx/xilinx_dpdma.cdrivers/mfd/intel-lpss.cdrivers/net/ethernet/airoha/airoha_eth.cdrivers/net/ethernet/mediatek/mtk_eth_path.cdrivers/net/ethernet/mediatek/mtk_eth_soc.cdrivers/net/ethernet/mediatek/mtk_ppe.cdrivers/net/ethernet/mediatek/mtk_ppe_debugfs.cdrivers/net/ethernet/mediatek/mtk_ppe_offload.cdrivers/net/ethernet/mediatek/mtk_wed.cdrivers/pci/controller/pcie-xilinx-dma-pl.cdrivers/tty/serial/8250/8250_mid.c
After that I compiled kernel with following options:CONFIG_COMPILE_TEST=yCONFIG_FORCE_PCI=yCONFIG_PCI=yCONFIG_PCI_MSI=yCONFIG_AMD_QDMA=yCONFIG_AMD_PTDMA=yCONFIG_DW_AXI_DMAC=yCONFIG_DW_EDMA=yCONFIG_DW_EDMA_PCIE=yCONFIG_INTEL_LDMA=yCONFIG_SERIAL_8250=yCONFIG_SERIAL_8250_MT6577=yCONFIG_MTK_HSDMA=yCONFIG_MTK_CQDMA=yCONFIG_MTK_UART_APDMA=y
# CONFIG_QCOM_ADM=y - error: assignment to 'u32 *' {aka 'unsigned int *'} from incompatible pointer type 'phys_addr_t *' CONFIG_QCOM_GPI_DMA=yCONFIG_QCOM_BAM_DMA=yCONFIG_SF_PDMA=yCONFIG_STM32_DMA=yCONFIG_STM32_MDMA=yCONFIG_STM32_DMA3=yCONFIG_DMA_OMAP=yCONFIG_TI_EDMA=yCONFIG_TI_MESSAGE_MANAGER=yCONFIG_TI_SCI_PROTOCOL=yCONFIG_TI_SCI_INTA_IRQCHIP=yCONFIG_TI_K3_UDMA=yCONFIG_XILINX_ZYNQMP_DPDMA=yCONFIG_XILINX_XDMA=yCONFIG_AMBA_PL08X=yCONFIG_ARM_DMA350=yCONFIG_FSL_EDMA=yCONFIG_FSL_QDMA=yCONFIG_MCF_EDMA=yCONFIG_INTEL_IDMA64=yCONFIG_DMA_SUN6I=yCONFIG_DMA_SUN4I=yCONFIG_AT_HDMAC=yCONFIG_REMOTEPROC=yCONFIG_ST_FDMA=yCONFIG_K3_DMA=yCONFIG_DMA_SA11X0=yCONFIG_AXI_DMAC=yCONFIG_IMG_MDC_DMA=yCONFIG_UNIPHIER_XDMAC=yCONFIG_UNIPHIER_MDMAC=yCONFIG_LOONGSON1_APB_DMA=yCONFIG_LOONGSON2_APB_DMA=yCONFIG_DMA_BCM2835=yCONFIG_TEGRA210_ADMA=yCONFIG_TEGRA186_GPC_DMA=yCONFIG_MOXART_DMA=yCONFIG_DMA_JZ4780=yCONFIG_IMX_SDMA=yCONFIG_OWL_DMA=yCONFIG_SPRD_DMA=yCONFIG_MILBEAUT_XDMAC=yCONFIG_MILBEAUT_HDMAC=yCONFIG_HISI_DMA=yCONFIG_FSL_MC_BUS=yCONFIG_FSL_MC_DPIO=yCONFIG_FSL_DPAA2_QDMA=yCONFIG_RZ_DMAC=yCONFIG_RENESAS_USB_DMAC=yCONFIG_PXA_DMA=yCONFIG_HSU_DMA=yCONFIG_HSU_DMA_PCI=yCONFIG_MFD_INTEL_LPSS=yCONFIG_NET_AIROHA=yCONFIG_NET_VENDOR_MEDIATEK=yCONFIG_NET_MEDIATEK_SOC=yCONFIG_NET_MEDIATEK_SOC_WED=yCONFIG_PCIE_XILINX_DMA_PL=yCONFIG_SERIAL_8250_MID=yCONFIG_AMD_AE4DMA=y
After that I've used following script to check compilation (it used file list obtained in previous step):
#!/bin/bash
for f in cat files; do
f=`echo $f | sed 's/.c$/.o/'`
test -f $f && echo $f: ok || echo $f: No such file or directorydone
It produced following output:
$ ./check drivers/dma/amba-pl08x.o: ok drivers/dma/amd/ae4dma/ae4dma-dev.o: ok drivers/dma/amd/ae4dma/ae4dma-pci.o: ok drivers/dma/amd/ptdma/ptdma-debugfs.o: ok drivers/dma/amd/ptdma/ptdma-dev.o: ok drivers/dma/amd/ptdma/ptdma-dmaengine.o: ok drivers/dma/amd/ptdma/ptdma-pci.o: ok drivers/dma/amd/qdma/qdma-comm-regs.o: ok drivers/dma/amd/qdma/qdma.o: ok drivers/dma/arm-dma350.o: ok drivers/dma/at_hdmac.o: ok drivers/dma/bcm2835-dma.o: ok drivers/dma/dma-axi-dmac.o: ok drivers/dma/dma-jz4780.o: ok drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.o: ok drivers/dma/dw-edma/dw-edma-core.o: ok drivers/dma/dw-edma/dw-edma-pcie.o: ok drivers/dma/dw-edma/dw-edma-v0-core.o: ok drivers/dma/dw-edma/dw-edma-v0-debugfs.o: ok drivers/dma/dw-edma/dw-hdma-v0-core.o: ok drivers/dma/dw-edma/dw-hdma-v0-debugfs.o: ok drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.o: ok drivers/dma/fsl-edma-common.o: ok drivers/dma/fsl-edma-main.o: ok drivers/dma/fsl-edma-trace.o: ok drivers/dma/fsl-qdma.o: ok drivers/dma/hisi_dma.o: ok drivers/dma/hsu/hsu.o: ok drivers/dma/hsu/pci.o: ok drivers/dma/idma64.o: ok drivers/dma/img-mdc-dma.o: ok drivers/dma/imx-sdma.o: ok drivers/dma/k3dma.o: ok drivers/dma/lgm/lgm-dma.o: ok drivers/dma/loongson1-apb-dma.o: ok drivers/dma/loongson2-apb-dma.o: ok drivers/dma/mcf-edma-main.o: ok drivers/dma/mediatek/mtk-cqdma.o: ok drivers/dma/mediatek/mtk-hsdma.o: ok drivers/dma/mediatek/mtk-uart-apdma.o: ok drivers/dma/milbeaut-hdmac.o: ok drivers/dma/milbeaut-xdmac.o: ok drivers/dma/moxart-dma.o: ok drivers/dma/owl-dma.o: ok drivers/dma/pxa_dma.o: ok drivers/dma/qcom/bam_dma.o: ok drivers/dma/qcom/gpi.o: ok drivers/dma/qcom/qcom_adm.o: No such file or directory drivers/dma/sa11x0-dma.o: ok drivers/dma/sf-pdma/sf-pdma.o: ok drivers/dma/sh/rz-dmac.o: ok drivers/dma/sh/usb-dmac.o: ok drivers/dma/sprd-dma.o: ok drivers/dma/st_fdma.o: ok drivers/dma/stm32/stm32-dma.o: ok drivers/dma/stm32/stm32-dma3.o: ok drivers/dma/stm32/stm32-mdma.o: ok drivers/dma/sun4i-dma.o: ok drivers/dma/sun6i-dma.o: ok drivers/dma/tegra186-gpc-dma.o: ok drivers/dma/tegra210-adma.o: ok drivers/dma/ti/edma.o: ok drivers/dma/ti/k3-udma.o: ok drivers/dma/ti/omap-dma.o: ok drivers/dma/uniphier-mdmac.o: ok drivers/dma/uniphier-xdmac.o: ok drivers/dma/virt-dma.o: ok drivers/dma/xilinx/xdma.o: ok drivers/dma/xilinx/xilinx_dpdma.o: ok drivers/mfd/intel-lpss.o: ok drivers/net/ethernet/airoha/airoha_eth.o: ok drivers/net/ethernet/mediatek/mtk_eth_path.o: ok drivers/net/ethernet/mediatek/mtk_eth_soc.o: ok drivers/net/ethernet/mediatek/mtk_ppe.o: ok drivers/net/ethernet/mediatek/mtk_ppe_debugfs.o: ok drivers/net/ethernet/mediatek/mtk_ppe_offload.o: ok drivers/net/ethernet/mediatek/mtk_wed.o: ok drivers/pci/controller/pcie-xilinx-dma-pl.o: ok drivers/tty/serial/8250/8250_mid.o: ok
Alexander Kochetkov (2):
dmaengine: virt-dma: convert tasklet to BH workqueue for callback
invocation
Allow compile virt-dma users on ARM64 platform
drivers/dma/Kconfig | 22 +++++++++---------- drivers/dma/amd/Kconfig | 4 ++-- drivers/dma/amd/qdma/qdma.c | 1 + drivers/dma/arm-dma350.c | 1 + drivers/dma/bcm2835-dma.c | 2 +- drivers/dma/dma-axi-dmac.c | 8 +++---- drivers/dma/dma-jz4780.c | 2 +- .../dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 +- drivers/dma/dw-edma/dw-edma-core.c | 2 +- drivers/dma/fsl-edma-common.c | 2 +- drivers/dma/fsl-edma-common.h | 1 + drivers/dma/fsl-qdma.c | 3 ++- drivers/dma/hisi_dma.c | 2 +- drivers/dma/hsu/Kconfig | 4 ++-- drivers/dma/hsu/hsu.c | 2 +- drivers/dma/idma64.c | 3 ++- drivers/dma/img-mdc-dma.c | 2 +- drivers/dma/imx-sdma.c | 2 +- drivers/dma/k3dma.c | 2 +- drivers/dma/loongson1-apb-dma.c | 2 +- drivers/dma/mediatek/mtk-cqdma.c | 2 +- drivers/dma/mediatek/mtk-hsdma.c | 3 ++- drivers/dma/mediatek/mtk-uart-apdma.c | 4 ++-- drivers/dma/owl-dma.c | 2 +- drivers/dma/pxa_dma.c | 2 +- drivers/dma/qcom/Kconfig | 6 ++--- drivers/dma/qcom/bam_dma.c | 4 ++-- drivers/dma/qcom/gpi.c | 1 + drivers/dma/qcom/qcom_adm.c | 2 +- drivers/dma/sa11x0-dma.c | 2 +- drivers/dma/sf-pdma/sf-pdma.c | 3 ++- drivers/dma/sprd-dma.c | 2 +- drivers/dma/st_fdma.c | 2 +- drivers/dma/stm32/stm32-dma.c | 1 + drivers/dma/stm32/stm32-dma3.c | 1 + drivers/dma/stm32/stm32-mdma.c | 1 + drivers/dma/sun6i-dma.c | 2 +- drivers/dma/tegra186-gpc-dma.c | 2 +- drivers/dma/tegra210-adma.c | 3 ++- drivers/dma/ti/Kconfig | 2 +- drivers/dma/ti/edma.c | 2 +- drivers/dma/ti/k3-udma.c | 10 ++++----- drivers/dma/ti/omap-dma.c | 2 +- drivers/dma/uniphier-xdmac.c | 1 + drivers/dma/virt-dma.c | 8 +++---- drivers/dma/virt-dma.h | 10 ++++----- drivers/mfd/Kconfig | 2 +- 47 files changed, 82 insertions(+), 69 deletions(-)
Signature · 1 line
2.43.0