Skip to content

Simplify the shash wrappers for the CRC32 library

Eric Biggers linux-btrfs linux-crypto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: stop parsing crc32c driver namefs/btrfs/disk-io.c+2 -60 replies
2/2crypto/crc32[c]: register only "-lib" driverscrypto/Makefile crypto/crc32.c crypto/crc32c.c +1 more+13 -1226 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Sterba
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Simplify the shash wrappers for the CRC32 library

This series simplifies how the CRC32 library functions are exposed through the crypto_shash API. We'll now have just one shash algorithm each for "crc32" and "crc32c", and their driver names will just always be "crc32-lib" and "crc32c-lib" respectively. This seems to be all that's actually needed.

As mentioned in patch 2, this does change the content of /sys/fs/btrfs/$uuid/checksum again, but that should be fine.

This is based on v6.16-rc1, and I'm planning to take these patches through the crc-next tree. These supersede
https://lore.kernel.org/r/[email protected]/
and
https://lore.kernel.org/r/[email protected]/,
and they fix the warning in the full crypto self-tests reported at
https://lore.kernel.org/r/[email protected]/

Eric Biggers (2):
btrfs: stop parsing crc32c driver name
crypto/crc32[c]: register only "-lib" drivers

 crypto/Makefile    |  2 --
 crypto/crc32.c     | 65 +++++----------------------------------------
 crypto/crc32c.c    | 66 ++++------------------------------------------
 crypto/testmgr.c   |  2 ++
 fs/btrfs/disk-io.c |  8 ++----
 5 files changed, 15 insertions(+), 128 deletions(-)

base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494

Signature · 1 line
2.49.0