Skip to content

assorted updates and fixes

Pablo Neira Ayuso netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rule: skip fuzzy lookup if object name is not availablesrc/rule.c+12 -00 replies
2/5cache: assert name is non-nul when looking upsrc/cache.c+9 -20 replies
3/5cache: pass name to cache_add()include/cache.h src/cache.c+16 -350 replies
4/5parser_bison: only reset by name is supported by nowsrc/parser_bison.y tests/shell/testcases/bogons/nft-f/null_set_name_crash+4 -20 replies
5/5parser_bison: allow delete command with map via handlesrc/parser_bison.y tests/shell/testcases/cache/0008_delete_by_handle_0 tests/shell/testcases/cache/0009_delete_by_handle_incorrect_0+6 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/5] assorted updates and fixes

Hi,

This batch contains several assorted updates and fixes:

1) Skip lookup for mistyped names if handle is used.
2) Assert of non-nul name when {table,chain,obj,flowtable}_cache_find() is used to catch for bugs when handle is used.
3) Consolidate repetitive cache name hash.
4) Restrict reset command to use name only because NFT_MSG_GETSET and NFT_MSG_GETSETELEM is missing lookup by handle in the kernel.
5) Allow to delete a map with handle, for consistency with the existing command to delete a set.

Pablo Neira Ayuso (5):
rule: skip fuzzy lookup if object name is not available
cache: assert name is non-nul when looking up
cache: pass name to cache_add()
parser_bison: only reset by name is supported by now
parser_bison: allow delete command with map via handle

 include/cache.h                               |  2 +-
 src/cache.c                                   | 60 ++++++++-----------
 src/parser_bison.y                            |  6 +-
 src/rule.c                                    | 12 ++++
 .../bogons/nft-f/null_set_name_crash          |  2 +
 .../testcases/cache/0008_delete_by_handle_0   |  4 ++
 .../cache/0009_delete_by_handle_incorrect_0   |  1 +
 7 files changed, 47 insertions(+), 40 deletions(-)
 create mode 100644 tests/shell/testcases/bogons/nft-f/null_set_name_crash
Signature · 1 line
2.30.2