Skip to content

tracetool: cleanup "if(true)" check from trace_foo()

Tanish Desai qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 7 repliesIn review
  2. v2 posting 1/21 patch 0 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tracetool: removed the unused vcpu propertyscripts/tracetool/__init__.py scripts/tracetool/backend/log.py scripts/tracetool/backend/simple.py +1 more+6 -182 replies
2/3tracetool: introduce generate_unconditionalscripts/tracetool/backend/__init__.py scripts/tracetool/backend/dtrace.py scripts/tracetool/backend/ust.py +1 more+13 -56 replies
3/3tracetool: remove redundant event_get_state checksscripts/tracetool/backend/ftrace.py scripts/tracetool/backend/log.py scripts/tracetool/backend/simple.py +2 more+5 -201 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] tracetool: cleanup "if(true)" check from trace_foo()

This series of patch aims to removes the leftover if (true) condition from trace_foo, a remnant from the TCG tracing feature removal.

It replaces it with a proper trace_event_get_state(...) check where necessary (for log/simple/syslog and ftrace backend).

Additionally, this change centralizes the generation of trace_event_get_state(...) calls into format/h.py, eliminating redundant code across individual backends.

This cleanup results in more consistent and less
repetitive backend code.

Tanish Desai (3):
tracetool: removed the unused vcpu property
tracetool: introduce generate_unconditional
tracetool: remove redundant event_get_state checks

 scripts/tracetool/__init__.py         |  6 +++---
 scripts/tracetool/backend/__init__.py |  3 +++
 scripts/tracetool/backend/dtrace.py   |  3 ++-
 scripts/tracetool/backend/ftrace.py   |  3 ---
 scripts/tracetool/backend/log.py      |  9 +--------
 scripts/tracetool/backend/simple.py   | 11 +----------
 scripts/tracetool/backend/syslog.py   | 11 +----------
 scripts/tracetool/backend/ust.py      |  2 +-
 scripts/tracetool/format/h.py         | 13 +++++++++----
 9 files changed, 21 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1