Skip to content

spi: zynqmp-gqspi: Support multiple buses and add GPIO support

Sean Anderson linux-arm-kernel linux-devicetree linux-spi lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest9 patches 18 repliesIn review

Changes in v2 from the cover letter

- Add spi-buses property
- Update spi-zynqmp-qspi.yaml with new binding style
- Support multi-bus controllers
- Add flag to determine default bus
- Support multiple buses with spi-buses instead of explicit upper/lower/merged buses

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9dt-bindings: spi: Add spi-buses propertyDocumentation/devicetree/bindings/spi/spi-peripheral-props.yaml+10 -012 replies
2/9dt-bindings: spi: zynqmp-qspi: Add example dual upper/lower busDocumentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml+21 -14 replies
3/9spi: Support multi-bus controllersdrivers/spi/spi.c include/linux/spi/spi.h+38 -10 replies
4/9spi: Add flag to determine default busdrivers/spi/spi.c include/linux/spi/spi.h+8 -10 replies
5/9spi: zynqmp-gqspi: Support multiple busesdrivers/spi/spi-zynqmp-gqspi.c+7 -51 reply
6/9spi: zynqmp-gqspi: Pass speed directly to config_opdrivers/spi/spi-zynqmp-gqspi.c+5 -80 replies
7/9spi: zynqmp-gqspi: Configure SPI mode dynamicallydrivers/spi/spi-zynqmp-gqspi.c+29 -140 replies
8/9spi: zynqmp-gqspi: Support GPIO chip selectsdrivers/spi/spi-zynqmp-gqspi.c+84 -90 replies
9/9ARM64: xilinx: zynqmp: Add spi-buses propertyarch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dts arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dts +7 more+10 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] spi: zynqmp-gqspi: Support multiple buses and add GPIO support

This device really has two SPI buses but they are currently determined by the slave's CS. Decouple bus selection from CS, and add support for GPIO chipselects. This allows adding arbitrary devices on either bus.

This version does the bus selction using a spi-buses property in slaves's node, as opposed to having separate nodes for the upper and lower buses. This should be backwards compatible with existing bindings, and could allow supporting "parallel" memories in the future (identical flashes on both buses controlled in lockstep).

Changes in v2:
- Add spi-buses property
- Update spi-zynqmp-qspi.yaml with new binding style
- Support multi-bus controllers
- Add flag to determine default bus
- Support multiple buses with spi-buses instead of explicit upper/lower/merged buses

David Lechner (2):
dt-bindings: spi: Add spi-buses property
spi: Support multi-bus controllers

Sean Anderson (7):
dt-bindings: spi: zynqmp-qspi: Add example dual upper/lower bus
spi: Add flag to determine default bus
spi: zynqmp-gqspi: Support multiple buses
spi: zynqmp-gqspi: Pass speed directly to config_op
spi: zynqmp-gqspi: Configure SPI mode dynamically
spi: zynqmp-gqspi: Support GPIO chip selects
ARM64: xilinx: zynqmp: Add spi-buses property

 .../bindings/spi/spi-peripheral-props.yaml    |  10 ++
 .../bindings/spi/spi-zynqmp-qspi.yaml         |  22 ++-
 .../boot/dts/xilinx/zynqmp-sm-k26-revA.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zc1254-revA.dts    |   1 +
 .../dts/xilinx/zynqmp-zc1751-xm015-dc1.dts    |   1 +
 .../dts/xilinx/zynqmp-zc1751-xm018-dc4.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu102-revA.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu104-revA.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu104-revC.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu106-revA.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu111-revA.dts    |   1 +
 .../boot/dts/xilinx/zynqmp-zcu1275-revA.dts   |   1 +
 drivers/spi/spi-zynqmp-gqspi.c                | 155 ++++++++++++++----
 drivers/spi/spi.c                             |  31 +++-
 include/linux/spi/spi.h                       |  15 ++
 15 files changed, 208 insertions(+), 35 deletions(-)
Signature · 1 line
2.35.1.1320.gc452695387.dirty