Skip to content

replace collect_mounts()/drop_collected_mounts() with a safer variant

Al Viro linux-fsdevel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest35 patches 4 repliesIn review
  2. v1 RFC1 patch 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35replace collect_mounts()/drop_collected_mounts() with a safer variantDocumentation/filesystems/porting.rst fs/namespace.c fs/pnode.h +2 more+104 -731 reply
2/35attach_recursive_mnt(): do not lock the covering tree when sliding something under itfs/namespace.c+4 -40 replies
3/35attach_mnt(): expand in attach_recursive_mnt(), then lose the flag argumentfs/namespace.c+12 -250 replies
4/35get rid of mnt_set_mountpoint_beneath()fs/namespace.c+4 -330 replies
5/35prevent mount hash conflictsfs/mount.h fs/namespace.c+23 -50 replies
6/35copy_tree(): don't set ->mnt_mountpoint on the root of copyfs/namespace.c+0 -10 replies
7/35constify mnt_has_parent()fs/mount.h+1 -10 replies
8/35pnode: lift peers() into pnode.hfs/pnode.c fs/pnode.h+5 -50 replies
9/35new predicate: mount_is_ancestor()fs/namespace.c+15 -60 replies
10/35constify is_local_mountpoint()fs/mount.h fs/namespace.c+3 -30 replies
11/35new predicate: anon_ns_root(mount)fs/mount.h fs/namespace.c+10 -250 replies
12/35dissolve_on_fput(): use anon_ns_root()fs/namespace.c+13 -490 replies
13/35__attach_mnt(): lose the second argumentfs/namespace.c+6 -50 replies
14/35don't set MNT_LOCKED on parentless mountsfs/namespace.c+15 -170 replies
15/35clone_mnt(): simplify the propagation-related logicsfs/namespace.c+13 -130 replies
16/35do_umount(): simplify the "is it still mounted" checksfs/namespace.c+6 -50 replies
17/35sanitize handling of long-term internal mountsdrivers/gpu/drm/i915/gem/i915_gemfs.c drivers/gpu/drm/v3d/v3d_gemfs.c fs/hugetlbfs/inode.c +3 more+48 -810 replies
18/35Rewrite of propagate_umount()Documentation/filesystems/propagate_umount.txt fs/mount.h fs/namespace.c +3 more+685 -1680 replies
19/35make commit_tree() usable in same-namespace move casefs/namespace.c+14 -160 replies
20/35attach_recursive_mnt(): unify the mnt_change_mountpoint() logicsfs/namespace.c+15 -90 replies
21/35attach_recursive_mnt(): pass destination mount in all casesfs/namespace.c+6 -110 replies
22/35attach_recursive_mnt(): get rid of flags entirelyfs/namespace.c+6 -120 replies
23/35do_move_mount(): take dropping the old mountpoint into attach_recursive_mnt()fs/namespace.c+2 -50 replies
24/35do_move_mount(): get rid of 'attached' flagfs/namespace.c+5 -80 replies
25/35attach_recursive_mnt(): remove from expiry list on movefs/namespace.c+3 -60 replies
26/35take ->mnt_expire handling under mount_lock [read_seqlock_excl]fs/namespace.c+11 -170 replies
27/35pivot_root(): reorder tree surgeries, collapse unhash_mnt() and put_mountpoint()fs/namespace.c+5 -60 replies
28/35combine __put_mountpoint() with unhash_mnt()fs/namespace.c+6 -60 replies
29/35get rid of mountpoint->m_countfs/mount.h fs/namespace.c+92 -950 replies
30/35don't have mounts pin their parentsfs/namespace.c fs/pnode.c+26 -540 replies
31/35copy_tree(): don't link the mounts via mnt_listfs/mount.h fs/namespace.c fs/pnode.c+27 -390 replies
32/35mount: separate the flags accessed only under namespace_semDocumentation/filesystems/propagate_umount.txt fs/mount.h fs/namespace.c +3 more+46 -460 replies
33/35propagate_one(): get rid of dest_masterfs/pnode.c+8 -50 replies
34/35propagate_mnt(): get rid of globalsfs/pnode.c+31 -300 replies
35/35take freeing of emptied mnt_namespace to namespace_unlock()fs/namespace.c+12 -150 replies

Reviews trailers per patch

22 of 35 patches have a Reviewed-by or Acked-by.

PatchChristian Brauner
1/35
2/35
3/35R-b
4/35R-b
5/35
6/35
7/35R-b
8/35R-b
9/35R-b
10/35R-b
11/35R-b
12/35R-b
13/35
14/35R-b
15/35R-b
16/35R-b
17/35R-b
18/35R-b
19/35
20/35
21/35R-b
22/35R-b
23/35R-b
24/35R-b
25/35R-b
26/35R-b
27/35R-b
28/35R-b
29/35
30/35R-b
31/35
32/35
33/35
34/35
35/35

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread