Skip to content

backlight: Do not include <linux/fb.h> in header file

Thomas Zimmermann asahi dri-devel linux-arm-kernel linux-fbdev platform-driver-x86 3 versions – Applied

Status from this message: Applied it to the review-ilpo-next branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/215 patches 25 repliesApplied
  2. v2 posting 1/215 patches 0 repliesSuperseded
  3. v112 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- add missing clean ups in jornada720, rave-sp, rt4831

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/15platform/x86: dell-uart-backlight: Use blacklight power constantdrivers/platform/x86/dell/dell-uart-backlight.c+1 -13 replies
2/15drm/panel: panel-samsung-s6e63m0: Include <linux/of.h>drivers/gpu/drm/panel/panel-samsung-s6e63m0.c+1 -03 replies
3/15drm/panel: panel-samsung-s6e88a0-ams427ap24: Include <linux/of.h>drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c+1 -00 replies
4/15drm/panel: panel-summit: Include <linux/of.h>drivers/gpu/drm/panel/panel-summit.c+1 -01 reply
5/15fbcon: Add necessary include statements and forward declarationsinclude/linux/fbcon.h+7 -01 reply
6/15backlight: Include <linux/of.h>drivers/video/backlight/backlight.c+1 -01 reply
7/15backlight: apple_dwi_bl: Include <linux/mod_devicetable.h>drivers/video/backlight/apple_dwi_bl.c+1 -01 reply
8/15backlight: as3711_bl: Include <linux/of.h>drivers/video/backlight/as3711_bl.c+1 -01 reply
9/15backlight: da9052_bl: Include <linux/mod_devicetable.h>drivers/video/backlight/da9052_bl.c+1 -01 reply
10/15backlight: jornada720: Include <linux/io.h>drivers/video/backlight/jornada720_bl.c+1 -01 reply
11/15backlight: ktd2801: Include <linux/mod_devicetable.h>drivers/video/backlight/ktd2801-backlight.c+1 -01 reply
12/15backlight: led_bl: Include <linux/of.h>drivers/video/backlight/led_bl.c+1 -01 reply
13/15backlight: rave-sp: Include <linux/of.h> and <linux/mod_devicetable.h>drivers/video/backlight/rave-sp-backlight.c+2 -03 replies
14/15backlight: rt4831: Include <linux/mod_devicetable.h>drivers/video/backlight/rt4831-backlight.c+1 -01 reply
15/15backlight: Do not include <linux/fb.h> in header fileinclude/linux/backlight.h+0 -14 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchHans de GoedeIlpo JärvinenNeil ArmstrongJanne GrunauNick ChanSimona VetterDaniel Thompson (RISCstar)
1/15R-b A-b
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b R-b
12/15R-b
13/15R-b
14/15R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/15] backlight: Do not include <linux/fb.h> in header file

Remove the final dependencies on fbdev from the backlight subsystem. This is really just the include of <linux/fb.h> in backlight, but it has some fallout in other code.

Patches 1 to 14 fix all the implicit includes that come from fb.h throughout the kernel. It's all trivial, but touches various drivers. Maintainers are in CC. Patch 15 fixes the backlight header.

With the series applied the backlight subsystem should be free from fbdev dependencies.

v2:
- add missing clean ups in jornada720, rave-sp, rt4831

Thomas Zimmermann (15):
platform/x86: dell-uart-backlight: Use blacklight power constant drm/panel: panel-samsung-s6e63m0: Include <linux/of.h> drm/panel: panel-samsung-s6e88a0-ams427ap24: Include <linux/of.h> drm/panel: panel-summit: Include <linux/of.h>
fbcon: Add necessary include statements and forward declarations
backlight: Include <linux/of.h>
backlight: apple_dwi_bl: Include <linux/mod_devicetable.h>
backlight: as3711_bl: Include <linux/of.h>
backlight: da9052_bl: Include <linux/mod_devicetable.h>
backlight: jornada720: Include <linux/io.h>
backlight: ktd2801: Include <linux/mod_devicetable.h>
backlight: led_bl: Include <linux/of.h>
backlight: rave-sp: Include <linux/of.h> and <linux/mod_devicetable.h>
backlight: rt4831: Include <linux/mod_devicetable.h>
backlight: Do not include <linux/fb.h> in header file

 drivers/gpu/drm/panel/panel-samsung-s6e63m0.c            | 1 +
 drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 1 +
 drivers/gpu/drm/panel/panel-summit.c                     | 1 +
 drivers/platform/x86/dell/dell-uart-backlight.c          | 2 +-
 drivers/video/backlight/apple_dwi_bl.c                   | 1 +
 drivers/video/backlight/as3711_bl.c                      | 1 +
 drivers/video/backlight/backlight.c                      | 1 +
 drivers/video/backlight/da9052_bl.c                      | 1 +
 drivers/video/backlight/jornada720_bl.c                  | 1 +
 drivers/video/backlight/ktd2801-backlight.c              | 1 +
 drivers/video/backlight/led_bl.c                         | 1 +
 drivers/video/backlight/rave-sp-backlight.c              | 2 ++
 drivers/video/backlight/rt4831-backlight.c               | 1 +
 include/linux/backlight.h                                | 1 -
 include/linux/fbcon.h                                    | 7 +++++++
 15 files changed, 21 insertions(+), 2 deletions(-)
Signature · 1 line
2.50.0