Introducing Broadcom BNGE Ethernet Driver
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest10 patches 0 repliesApplied 10/10
- v210 patches 2 repliesSuperseded
- v110 patches 16 repliesSuperseded
Changes in v3 from the cover letter
Addressed following comments by Jakub Kicinski
Patch 04/10:
- Move devlink register at appropriate place.
Patch 10/10:
- Free skb in xmit call
Patches in v3 All 10 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | bng_en: Add PCI interfaceMAINTAINERS drivers/ drivers/ +3 more | +177 | 0 replies | Applied |
| 2/10 | bng_en: Add devlink interfacedrivers/ drivers/ drivers/ +3 more | +211 | 0 replies | Applied |
| 3/10 | bng_en: Add firmware communication mechanismdrivers/ drivers/ drivers/ +1 more | +634 | 0 replies | Applied |
| 4/10 | bng_en: Add initial interaction with firmwaredrivers/ drivers/ drivers/ +4 more | +522 | 0 replies | Applied |
| 5/10 | bng_en: Add ring memory allocation supportdrivers/ drivers/ drivers/ | +138 | 0 replies | Applied |
| 6/10 | bng_en: Add backing store supportdrivers/ drivers/ drivers/ +2 more | +680 | 0 replies | Applied |
| 7/10 | bng_en: Add resource management supportdrivers/ drivers/ drivers/ +5 more | +761 | 0 replies | Applied |
| 8/10 | bng_en: Add irq allocation supportdrivers/ drivers/ drivers/ | +85 | 0 replies | Applied |
| 9/10 | bng_en: Initialize default configurationdrivers/ drivers/ drivers/ +3 more | +403 | 0 replies | Applied |
| 10/10 | bng_en: Add a network devicedrivers/ drivers/ drivers/ +5 more | +543 | 0 replies | Applied |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Bhargava Chenna Marreddy | Rajashekar Hudumula |
|---|---|---|
| 1/10 | R-b | R-b |
| 2/10 | R-b | R-b |
| 3/10 | R-b | R-b |
| 4/10 | R-b | R-b |
| 5/10 | R-b | R-b |
| 6/10 | R-b | R-b |
| 7/10 | R-b | R-b |
| 8/10 | R-b | R-b |
| 9/10 | R-b | R-b |
| 10/10 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [net-next, v3 00/10] Introducing Broadcom BNGE Ethernet Driver
Hi,
This patch series introduces the Ethernet driver for Broadcom’s BCM5770X chip family, which supports 50/100/200/400/800 Gbps link speeds. The driver is built as the bng_en.ko kernel module.
To keep the series within a reviewable size (~5K lines of code), this initial submission focuses on the core infrastructure and initialization, including:
1) PCIe support (device IDs, probe/remove)
2) Devlink support
3) Firmware communication mechanism
4) Creation of network device
5) PF Resource management (rings, IRQs, etc. for netdev & aux dev)
Support for Tx/Rx datapaths, link management, ethtool/devlink operations and additional features will be introduced in the subsequent patch series.
The bng_en driver shares the bnxt_hsi.h file with the bnxt_en driver, as the bng_en driver leverages the hardware communication protocol used by the bnxt_en driver.
Changes from:
=====================================================================v2->v3
Addressed following comments by Jakub Kicinski
Patch 04/10:
- Move devlink register at appropriate place.
Patch 10/10:
- Free skb in xmit call
=====================================================================v1->v2
Addressed warnings and errors in the following patches:
-Patch 8/10
-Patch 10/10
Addressed the following major comments by Vadim Fedorenko on Patch 1/10:
Patch 1/10:
- Use of the dma_set_mask_and_coherent() API.
Patch 2/10:
- Added error logs via extack.
Patch 3/10:
- Renamed functions to use the hwrm prefix. This change affects other patches in the series as well.
=====================================================================
Thanks,
Vikas
Vikas Gupta (10):
bng_en: Add PCI interface
bng_en: Add devlink interface
bng_en: Add firmware communication mechanism
bng_en: Add initial interaction with firmware
bng_en: Add ring memory allocation support
bng_en: Add backing store support
bng_en: Add resource management support
bng_en: Add irq allocation support
bng_en: Initialize default configuration
bng_en: Add a network device
MAINTAINERS | 6 + drivers/net/ethernet/broadcom/Kconfig | 9 + drivers/net/ethernet/broadcom/Makefile | 1 + drivers/net/ethernet/broadcom/bnge/Makefile | 12 + drivers/net/ethernet/broadcom/bnge/bnge.h | 218 ++++++ .../net/ethernet/broadcom/bnge/bnge_core.c | 388 ++++++++++ .../net/ethernet/broadcom/bnge/bnge_devlink.c | 306 ++++++++ .../net/ethernet/broadcom/bnge/bnge_devlink.h | 18 + .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 33 + .../net/ethernet/broadcom/bnge/bnge_ethtool.h | 9 + .../net/ethernet/broadcom/bnge/bnge_hwrm.c | 508 +++++++++++++ .../net/ethernet/broadcom/bnge/bnge_hwrm.h | 110 +++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 703 ++++++++++++++++++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.h | 27 + .../net/ethernet/broadcom/bnge/bnge_netdev.c | 268 +++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 206 +++++ .../net/ethernet/broadcom/bnge/bnge_resc.c | 605 +++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_resc.h | 94 +++ .../net/ethernet/broadcom/bnge/bnge_rmem.c | 438 +++++++++++ .../net/ethernet/broadcom/bnge/bnge_rmem.h | 188 +++++ 20 files changed, 4147 insertions(+) create mode 100644 drivers/net/ethernet/broadcom/bnge/Makefile create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_core.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_devlink.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_devlink.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_ethtool.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_hwrm.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_hwrm.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_netdev.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_netdev.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_resc.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_resc.h create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_rmem.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
Signature · 1 line
2.47.1