Skip to content

RFC mm/migration: rework movable_ops page migration (part 1)

David Hildenbrand linux-doc linux-fsdevel linux-mm linuxppc-dev lkml virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest29 patches 63 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29mm/balloon_compaction: we cannot have isolated pages in the balloon listmm/balloon_compaction.c+0 -61 reply
2/29mm/balloon_compaction: convert balloon_page_delete() to balloon_page_finalize()arch/powerpc/platforms/pseries/cmm.c drivers/misc/vmw_balloon.c drivers/virtio/virtio_balloon.c +2 more+21 -340 replies
3/29mm/zsmalloc: drop PageIsolated() related VM_BUG_ONsmm/zpdesc.h mm/zsmalloc.c+0 -103 replies
4/29mm/page_alloc: allow for making page types sticky until freedmm/page_alloc.c+3 -09 replies
5/29mm/balloon_compaction: make PageOffline stickyinclude/linux/balloon_compaction.h+1 -14 replies
6/29mm/zsmalloc: make PageZsmalloc() stickymm/zpdesc.h mm/zsmalloc.c+1 -73 replies
7/29mm/migrate: rename isolate_movable_page() to isolate_movable_ops_page()include/linux/migrate.h mm/compaction.c mm/migrate.c+32 -1313 replies
8/29mm/migrate: rename putback_movable_folio() to putback_movable_ops_page()mm/migrate.c+24 -135 replies
9/29mm/migrate: factor out movable_ops page handling into migrate_movable_ops_page()mm/migrate.c+45 -371 reply
10/29mm/migrate: remove folio_test_movable() and folio_movable_ops()include/linux/migrate.h+0 -141 reply
11/29mm/migrate: move movable_ops page handling out of move_to_new_folio()mm/migrate.c+28 -332 replies
12/29mm/zsmalloc: stop using __ClearPageMovable()mm/zsmalloc.c+11 -40 replies
13/29mm/balloon_compaction: stop using __ClearPageMovable()include/linux/balloon_compaction.h mm/balloon_compaction.c+12 -32 replies
14/29mm/migrate: remove __ClearPageMovable()include/linux/migrate.h mm/compaction.c+0 -152 replies
15/29mm/migration: remove PageMovable()include/linux/migrate.h mm/compaction.c mm/migrate.c+10 -251 reply
16/29mm: rename __PageMovable() to page_has_movable_ops()include/linux/migrate.h include/linux/page-flags.h mm/compaction.c +5 more+19 -243 replies
17/29mm/page_isolation: drop __folio_test_movable() check for large foliosmm/page_isolation.c+1 -11 reply
18/29mm: remove __folio_test_movable()include/linux/page-flags.h mm/migrate.c mm/vmscan.c+17 -382 replies
19/29mm: stop storing migration_ops in page->mappinginclude/linux/balloon_compaction.h include/linux/migrate.h include/linux/zsmalloc.h +5 more+35 -251 reply
20/29mm: convert "movable" flag in page->mapping to a page flaginclude/linux/balloon_compaction.h include/linux/migrate.h include/linux/page-flags.h +2 more+44 -262 replies
21/29mm: rename PG_isolated to PG_movable_ops_isolatedinclude/linux/page-flags.h mm/compaction.c mm/migrate.c+19 -131 reply
22/29mm/page-flags: rename PAGE_MAPPING_MOVABLE to PAGE_MAPPING_ANON_KSMinclude/linux/page-flags.h+6 -61 reply
23/29mm/page-alloc: remove PageMappingFlags()include/linux/page-flags.h mm/page_alloc.c+3 -91 reply
24/29mm/page-flags: remove folio_mapping_flags()include/linux/page-flags.h+0 -51 reply
25/29mm: simplify folio_expected_ref_count()include/linux/mm.h+2 -21 reply
26/29mm: rename PAGE_MAPPING_* to FOLIO_MAPPING_*fs/proc/page.c include/linux/fs.h include/linux/mm_types.h +7 more+30 -311 reply
27/29docs/mm: convert from "Non-LRU page migration" to "movable_ops page migration"Documentation/mm/page_migration.rst+27 -121 reply
28/29mm/balloon_compaction: "movable_ops" doc updatesinclude/linux/balloon_compaction.h+6 -70 replies
29/29mm/balloon_compaction: provide single balloon_page_insert() and balloon_mapping_gfp_mask()include/linux/balloon_compaction.h+15 -270 replies

Reviews trailers per patch

21 of 29 patches have a Reviewed-by or Acked-by.

PatchZi YanSergey SenozhatskyHarry Yoo
1/29A-b
2/29
3/29A-b R-b A-b
4/29R-b A-b
5/29A-b A-b
6/29A-b R-b A-b
7/29R-b
8/29A-b
9/29
10/29R-b
11/29R-b
12/29
13/29
14/29
15/29R-b
16/29R-b
17/29R-b
18/29R-b
19/29R-b
20/29
21/29R-b
22/29R-b
23/29R-b
24/29R-b
25/29R-b
26/29R-b
27/29R-b
28/29
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH RFC 00/29] mm/migration: rework movable_ops page migration (part 1)

Based on mm/mm-new.

In the future, as we decouple "struct page" from "struct folio", pages that support "non-lru page migration" -- movable_ops page migration such as memory balloons and zsmalloc -- will no longer be folios. They will not have ->mapping, ->lru, and likely no refcount and no page lock. But they will have flags :)

This is the first part (other parts not written yet) of decoupling movable_ops page migration from folio migration.

In this series, we get rid of the ->mapping usage, and start cleaning up the code + separating it from folio migration.

Migration core will have to be further reworked to not treat movable_ops pages like folios. This is the first step into that direction.

RFC because I only did some light testing with virtio-balloon + zsmalloc page migration, and have to polish some patch descriptions.

Cc Andrew Morton <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nicholas Piggin <[email protected]>
Cc Christophe Leroy <[email protected]>
Cc Jerrin Shaji George <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Jason Wang <[email protected]>
Cc Xuan Zhuo <[email protected]>
Cc "Eugenio Pérez" <[email protected]>
Cc Alexander Viro <[email protected]>
Cc Christian Brauner <[email protected]>
Cc Jan Kara <[email protected]>
Cc Zi Yan <[email protected]>
Cc Matthew Brost <[email protected]>
Cc Joshua Hahn <[email protected]>
Cc Rakie Kim <[email protected]>
Cc Byungchul Park <[email protected]>
Cc Gregory Price <[email protected]>
Cc Ying Huang <[email protected]>
Cc Alistair Popple <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc "Liam R. Howlett" <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Michal Hocko <[email protected]>
Cc "Matthew Wilcox (Oracle)" <[email protected]>
Cc Minchan Kim <[email protected]>
Cc Sergey Senozhatsky <[email protected]>
Cc Brendan Jackman <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Cc John Hubbard <[email protected]>
Cc Peter Xu <[email protected]>
Cc Xu Xin <[email protected]>
Cc Chengming Zhou <[email protected]>
Cc Miaohe Lin <[email protected]>
Cc Naoya Horiguchi <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Rik van Riel <[email protected]>
Cc Harry Yoo <[email protected]>
Cc Qi Zheng <[email protected]>
Cc Shakeel Butt <[email protected]>

David Hildenbrand (29):
mm/balloon_compaction: we cannot have isolated pages in the balloon
list
mm/balloon_compaction: convert balloon_page_delete() to
balloon_page_finalize()
mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs mm/page_alloc: allow for making page types sticky until freed mm/balloon_compaction: make PageOffline sticky mm/zsmalloc: make PageZsmalloc() sticky
mm/migrate: rename isolate_movable_page() to
isolate_movable_ops_page()
mm/migrate: rename putback_movable_folio() to
putback_movable_ops_page()
mm/migrate: factor out movable_ops page handling into
migrate_movable_ops_page()
mm/migrate: remove folio_test_movable() and folio_movable_ops() mm/migrate: move movable_ops page handling out of move_to_new_folio() mm/zsmalloc: stop using __ClearPageMovable() mm/balloon_compaction: stop using __ClearPageMovable() mm/migrate: remove __ClearPageMovable()
mm/migration: remove PageMovable()
mm: rename __PageMovable() to page_has_movable_ops() mm/page_isolation: drop __folio_test_movable() check for large folios
mm: remove __folio_test_movable()
mm: stop storing migration_ops in page->mapping
mm: convert "movable" flag in page->mapping to a page flag
mm: rename PG_isolated to PG_movable_ops_isolated mm/page-flags: rename PAGE_MAPPING_MOVABLE to PAGE_MAPPING_ANON_KSM mm/page-alloc: remove PageMappingFlags()
mm/page-flags: remove folio_mapping_flags()
mm: simplify folio_expected_ref_count()
mm: rename PAGE_MAPPING_* to FOLIO_MAPPING_*
docs/mm: convert from "Non-LRU page migration" to "movable_ops page
migration"
mm/balloon_compaction: "movable_ops" doc updates mm/balloon_compaction: provide single balloon_page_insert() and
balloon_mapping_gfp_mask()

 Documentation/mm/page_migration.rst  |  39 ++--
 arch/powerpc/platforms/pseries/cmm.c |   2 +-
 drivers/misc/vmw_balloon.c           |   3 +-
 drivers/virtio/virtio_balloon.c      |   4 +-
 fs/proc/page.c                       |   4 +-
 include/linux/balloon_compaction.h   |  90 ++++-----
 include/linux/fs.h                   |   2 +-
 include/linux/migrate.h              |  42 +----
 include/linux/mm.h                   |   4 +-
 include/linux/mm_types.h             |   1 -
 include/linux/page-flags.h           | 104 +++++++----
 include/linux/pagemap.h              |   2 +-
 include/linux/zsmalloc.h             |   2 +
 mm/balloon_compaction.c              |  21 ++-
 mm/compaction.c                      |  44 +----
 mm/gup.c                             |   4 +-
 mm/internal.h                        |   2 +-
 mm/ksm.c                             |   4 +-
 mm/memory-failure.c                  |   4 +-
 mm/memory_hotplug.c                  |   8 +-
 mm/migrate.c                         | 269 +++++++++++++++------------
 mm/page_alloc.c                      |  12 +-
 mm/page_isolation.c                  |  12 +-
 mm/rmap.c                            |  16 +-
 mm/util.c                            |   6 +-
 mm/vmscan.c                          |   6 +-
 mm/zpdesc.h                          |  15 +-
 mm/zsmalloc.c                        |  29 ++-
 28 files changed, 361 insertions(+), 390 deletions(-)

base-commit: 21f39cc0346ea2081a83f0469995144d75d23075

Signature · 1 line
2.49.0