Skip to content

Add ISP Generic PM Domain (genpd) support

Pratap Nirujogi amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/amd/pm: Add support to set ISP Powerdrivers/gpu/drm/amd/pm/amdgpu_dpm.c drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h +2 more+45 -01 reply
2/4drm/amd/pm: Add support to set min ISP clocksdrivers/gpu/drm/amd/include/kgd_pp_interface.h drivers/gpu/drm/amd/pm/amdgpu_dpm.c drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +3 more+56 -292 replies
3/4drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) supportdrivers/gpu/drm/amd/amdgpu/amdgpu_isp.h drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c+157 -10 replies
4/4drm/amd/amdgpu: Refine isp_v4_1_1 loggingdrivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c+6 -120 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchXiaojian DuLijo LazarMario Limonciello
SeriesR-b
1/4R-b
2/4R-b R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] Add ISP Generic PM Domain (genpd) support

This patch series adds support to control ISP power and clocks using the Generic PM Domain (genpd). Its required to control the ISP HW power from external I2C driver to successfully probe the sensor device. Instead of using an exported symbols from ISP driver, enabling Generic PM Domain (genpd) support in amdgpu_isp device allows its child devices (amd_isp_capture, amd_isp_i2c_designware) to set power and clocks directly using PM method.

We need to add support in amdgpu_smu as well for amdgpu_isp device to set power / clocks when invoked from genpd. Though the below SMU messages are defined, the actual support to configure ISP is missing in SMU interface.

PPSMC_MSG_PowerDownIspByTile
PPSMC_MSG_PowerUpIspByTile
PPSMC_MSG_SetHardMinIspiclkByFreq
PPSMC_MSG_SetHardMinIspxclkByFreq

Added support in SMU to control ISP power / clocks by updating the existing amdgpu_dpm_set_powergating_by_smu() and amdgpu_dpm_set_soft_freq_range(); and the underlying SOC specific SMU implementation for isp v4.1.

Pratap Nirujogi (4):
drm/amd/pm: Add support to set ISP Power drm/amd/pm: Add support to set min ISP clocks drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) support drm/amd/amdgpu: Refine isp_v4_1_1 logging

 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h       |   3 +
 drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c       | 173 ++++++++++++++++--
 .../gpu/drm/amd/include/kgd_pp_interface.h    |   2 +
 drivers/gpu/drm/amd/pm/amdgpu_dpm.c           |  15 +-
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     |  41 ++++-
 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |   9 +-
 .../inc/pmfw_if/smu14_driver_if_v14_0_0.h     |   1 +
 drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h  |   2 +
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c  |  60 ++++--
 9 files changed, 264 insertions(+), 42 deletions(-)
Signature · 1 line
2.43.0