ASoC: core/topology/Intel:
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | ASoC: topology: Do not call snd_soc_remove_pcm_runtime() for ignored linkssound/ | +5 | 0 replies | |
| 2/4 | ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime()sound/ | +3 | 0 replies | |
| 3/4 | ASoC: Intel: skl_hda_dsp_generic: Implement add_dai_link to filter HDMI PCMssound/ | +13 | 0 replies | |
| 4/4 | ASoC: Intel: sof_sdw: Implement add_dai_link to filter HDMI PCMssound/ | +14 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Bard Liao | Ranjani Sridharan | Liam Girdwood | Kai Vehmanen |
|---|---|---|---|---|
| 1/4 | R-b | R-b | R-b | R-b |
| 2/4 | R-b | R-b | R-b | R-b |
| 3/4 | R-b | R-b | R-b | R-b |
| 4/4 | R-b | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 0/4] ASoC: core/topology/Intel:
Hi,
There are devices where the iDisp HDA codec for HDMI is disconnected and it is not present on the HDA bus.
This usually happens on systems with dGPU, but not limited to them.
How SOF tried to deal with this is to drop in a dummy codec in place of the iDisp to allow the topology to be loaded, but these PCM devices are unusable, they fail when user tries to use them.
PA/PW is probing the PCM devices on probe and that causes the kernel log to fill up with errors, which is harmless but disturbing.
This series will use the filter function to prevent the creation of the HDMI PCM devices in the first place (like HDA legacy stack will not present HDMI devices if the codec is not visible).
The topology still loads, we still use dummy codec to satisfy it, but there will be no dummy PCM devices created.
The first two patch handles the same issue that was discovered by the ignored link: a NULL dereference.
I'm not sure if both is needed, but I felt that fixing it in one place and leaving the other open might not be future proof.
If I would to pick one, I would likely go with the patch for the soc-core.
Regards,
Peter
---
Peter Ujfalusi (4):
ASoC: topology: Do not call snd_soc_remove_pcm_runtime() for ignored
links
ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime()
ASoC: Intel: skl_hda_dsp_generic: Implement add_dai_link to filter
HDMI PCMs
ASoC: Intel: sof_sdw: Implement add_dai_link to filter HDMI PCMs
sound/soc/intel/boards/skl_hda_dsp_generic.c | 13 +++++++++++++ sound/soc/intel/boards/sof_sdw.c | 14 ++++++++++++++ sound/soc/soc-core.c | 3 +++ sound/soc/soc-topology.c | 7 +++++-- 4 files changed, 35 insertions(+), 2 deletions(-)
Signature · 1 line
2.49.0