Skip to content

hide struct start_info from PVH code

Juergen Gross xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6suspend: drop crazy pfn handling for PVHarch/x86/setup.c+0 -221 reply
2/6setup: drop parameter from map_shared_info()arch/arm/setup.c arch/x86/setup.c hypervisor.c +1 more+9 -91 reply
3/6x86/pv: remove global start_infoarch/x86/setup.c console.c include/hypervisor.h +1 more+5 -281 reply
4/6console: drop parameter from get_console()arch/arm/setup.c arch/x86/setup.c console.c +1 more+8 -81 reply
5/6xenbus: drop parameter from get_xenbus()arch/arm/setup.c arch/x86/setup.c include/xenbus.h +1 more+9 -121 reply
6/6x86/pv: make start_info_ptr PV-onlyarch/x86/setup.c+11 -51 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJason Andryuk
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [MINI-OS PATCH 0/6] hide struct start_info from PVH code

While working on xenstore-stubdom live update support I came across some really unpleasant code using struct start_info even when running in PVH mode.

Especially suspend/resume was doing some crazy stuff, including overwriting the initial struct hvm_start_info partially.

This series is hiding struct start_info from PVH code. This didn't result in any runtime error, but in future I'll need to access struct hvm_start_info some time after boot, so I need to get that fixed.

Tested especially with xl suspend/resume and xl save/restore in PV and in PVH mode.

Juergen Gross (6):
suspend: drop crazy pfn handling for PVH
setup: drop parameter from map_shared_info()
x86/pv: remove global start_info
console: drop parameter from get_console()
xenbus: drop parameter from get_xenbus()
x86/pv: make start_info_ptr PV-only

 arch/arm/setup.c     |  6 ++--
 arch/x86/setup.c     | 69 ++++++++++++--------------------------------
 console.c            | 10 +++----
 hypervisor.c         |  2 +-
 include/console.h    |  2 +-
 include/hypervisor.h | 14 ++-------
 include/xenbus.h     |  4 +--
 xenbus.c             | 13 ++++-----
 8 files changed, 39 insertions(+), 81 deletions(-)
Signature · 1 line
2.43.0