Skip to content

net: axienet: Fix deferred probe loop

Sean Anderson linux-arm-kernel lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 13 repliesIn review
  2. v37 patches 3 repliesSuperseded
  3. v24 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches19 repliesSuperseded

Changes in v4 from the cover letter

- Fix documentation for axienet_mdio_enable
- Fix platform_driver_register in exit

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: axienet: Fix resource release orderingdrivers/net/ethernet/xilinx/xilinx_axienet_main.c+37 -523 replies
2/7net: axienet: Use ioread32/iowrite32 directlydrivers/net/ethernet/xilinx/xilinx_axienet_mdio.c+20 -231 reply
3/7net: axienet: Use MDIO bus device in printsdrivers/net/ethernet/xilinx/xilinx_axienet_mdio.c+20 -162 replies
4/7net: axienet: Simplify axienet_mdio_setupdrivers/net/ethernet/xilinx/xilinx_axienet_mdio.c+5 -101 reply
5/7net: axienet: Use device variable in probedrivers/net/ethernet/xilinx/xilinx_axienet_main.c+41 -421 reply
6/7net: axienet: Rearrange lifetime functionsdrivers/net/ethernet/xilinx/xilinx_axienet.h drivers/net/ethernet/xilinx/xilinx_axienet_main.c drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c+126 -933 replies
7/7net: axienet: Split into MAC and MDIO driversdrivers/net/ethernet/xilinx/Kconfig drivers/net/ethernet/xilinx/xilinx_axienet.h drivers/net/ethernet/xilinx/xilinx_axienet_main.c +1 more+169 -692 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchSuraj GuptaAndrew Lunn
1/7R-b
2/7
3/7
4/7
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 0/7] net: axienet: Fix deferred probe loop

Fix a deferred-probe loop by splitting the MAC and MDIO functionality into separate drivers. Please refer to the last patch for an extended look at the problem this series is attempting to solve.

This is a rather large fix for a rather rare bug, so I have sent it for net-next. The first patch is a smaller fix, however, and could go via net.

Changes in v4:
- Fix documentation for axienet_mdio_enable
- Fix platform_driver_register in exit

Changes in v3:
- Use ioread32/iowrite32 directly in MDIO
- Use MDIO bus device in prints
- Use device variable to probe
- Rework to use a separate axienet_common structure, as netdevs cannot be reused once registered.
- Use ida_alloc for aux id

Changes in v2:
- Fix building as a module
- Expand commit message with much more info on the problem and possible solutions

Sean Anderson (7):
net: axienet: Fix resource release ordering
net: axienet: Use ioread32/iowrite32 directly
net: axienet: Use MDIO bus device in prints
net: axienet: Simplify axienet_mdio_setup
net: axienet: Use device variable in probe
net: axienet: Rearrange lifetime functions
net: axienet: Split into MAC and MDIO drivers

 drivers/net/ethernet/xilinx/Kconfig           |   1 +
 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  45 +-
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 383 +++++++++++-------
 .../net/ethernet/xilinx/xilinx_axienet_mdio.c | 158 ++++----
 4 files changed, 350 insertions(+), 237 deletions(-)
Signature · 1 line
2.35.1.1320.gc452695387.dirty