Skip to content

RFC Remove union from struct knfsd_fh

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2NFSD: Access a knfsd_fh's fsid by pointerfs/nfsd/nfs4layouts.c fs/nfsd/nfsfh.c fs/nfsd/nfsfh.h+20 -111 reply
2/2NFSD: Simplify struct knfsd_fhfs/nfsd/nfsfh.h+6 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJeff LaytonChristoph Hellwig
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/2] Remove union from struct knfsd_fh

From: Chuck Lever <[email protected]>

This is a low-risk way to simplify the knfsd_fh struct, based on Christoph's suggestion of using array indices rather than u8 fields.

Compile-tested only.

Chuck Lever (2):
NFSD: Access a knfsd_fh's fsid by pointer
NFSD: Simplify struct knfsd_fh

 fs/nfsd/nfs4layouts.c |  4 ++--
 fs/nfsd/nfsfh.c       | 16 +++++++++-------
 fs/nfsd/nfsfh.h       | 26 +++++++++++++++-----------
 3 files changed, 26 insertions(+), 20 deletions(-)
Signature · 1 line
2.49.0