Skip to content

mm/userfaultfd: modulize memory types

Peter Xu linux-mm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 36 repliesIn review
  2. v34 patches 28 repliesSuperseded
  3. v24 patches 66 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches18 repliesSuperseded

Changes in v4 from the cover letter

- Some cleanups within vma_can_userfault() [David]
- Rename uffd_get_folio() to minor_get_folio() [David]
- Remove uffd_features in vm_uffd_ops, deduce it from supported ioctls [David]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mm: Introduce vm_uffd_ops APIinclude/linux/mm.h include/linux/userfaultfd_k.h+38 -01 reply
2/4mm/shmem: Support vm_uffd_ops APImm/shmem.c+24 -01 reply
3/4mm/hugetlb: Support vm_uffd_ops APImm/hugetlb.c+18 -01 reply
4/4mm: Apply vm_uffd_ops API to core mminclude/linux/userfaultfd_k.h mm/userfaultfd.c+109 -570 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMike RapoportJames HoughtonDavid Hildenbrand
1/4A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] mm/userfaultfd: modulize memory types

[based on latest akpm/mm-new of Oct 14th, commit 36c6c5ce1b275]

v4:
- Some cleanups within vma_can_userfault() [David]
- Rename uffd_get_folio() to minor_get_folio() [David]
- Remove uffd_features in vm_uffd_ops, deduce it from supported ioctls [David]

v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]
v3: https://lore.kernel.org/r/[email protected]

This series is an alternative proposal of what Nikita proposed here on the initial three patches:

https://lore.kernel.org/r/[email protected]

This is not yet relevant to any guest-memfd support, but paving way for it. Here, the major goal is to make kernel modules be able to opt-in with any form of userfaultfd supports, like guest-memfd. This alternative option should hopefully be cleaner, and avoid leaking userfault details into vm_ops.fault().

It also means this series does not depend on anything. It's a pure refactoring of userfaultfd internals to provide a generic API, so that other types of files, especially RAM based, can support userfaultfd without touching mm/ at all.

To achieve it, this series introduced a file operation called vm_uffd_ops. The ops needs to be provided when a file type supports any of userfaultfd.

With that, I moved both hugetlbfs and shmem over, whenever possible. So far due to concerns on exposing an uffd_copy() API, the MISSING faults are still separately processed and can only be done within mm/. Hugetlbfs kept its special paths untouched.

An example of shmem uffd_ops:

static const struct vm_uffd_ops shmem_uffd_ops = {
	.supported_ioctls	=	BIT(_UFFDIO_COPY) |
					BIT(_UFFDIO_ZEROPAGE) |
					BIT(_UFFDIO_WRITEPROTECT) |
					BIT(_UFFDIO_CONTINUE) |
					BIT(_UFFDIO_POISON),
	.minor_get_folio	=	shmem_uffd_get_folio,
};

To show another sample, this is the patch that Nikita posted to implement minor fault for guest-memfd (on top of older versions of this series):

https://lore.kernel.org/all/[email protected]/

No functional change expected at all after the whole series applied. There might be some slightly stricter check on uffd ops here and there in the last patch, but that really shouldn't stand out anywhere to anyone.

For testing: besides the cross-compilation tests, I did also try with uffd-stress in a VM to measure any perf difference before/after the change; The static call becomes a pointer now. I really cannot measure anything different, which is more or less expected.

Comments welcomed, thanks.

Peter Xu (4):
mm: Introduce vm_uffd_ops API
mm/shmem: Support vm_uffd_ops API
mm/hugetlb: Support vm_uffd_ops API
mm: Apply vm_uffd_ops API to core mm

 include/linux/mm.h            |   9 +++
 include/linux/userfaultfd_k.h |  75 +++++++++++----------
 mm/hugetlb.c                  |  18 +++++
 mm/shmem.c                    |  24 +++++++
 mm/userfaultfd.c              | 120 +++++++++++++++++++++++++++-------
 5 files changed, 189 insertions(+), 57 deletions(-)
Signature · 1 line
2.50.1