Skip to content

net: ethtool: rss: add notifications

Jakub Kicinski netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 10 repliesApplied 8/8
  2. v19 patches 6 repliesSuperseded 1 of 9 applied

Changes in v2 from the cover letter

- [patch 2] fix typo in commit msg
- [patch 5] propagate phy_index already
- [patch 6] fix compilation with ETHTOOL_NETLINK=n
- [patch 8] old patch dropped/applied already patch 9 becomes patch 8
v1: https://lore.kernel.org/[email protected]

Patches in v2 All 8 applied

#Subject and filesSizeRepliesApplied
1/8netlink: specs: add the multicast group name to specDocumentation/netlink/specs/ethtool.yaml include/uapi/linux/ethtool_netlink.h include/uapi/linux/ethtool_netlink_generated.h+8 -20 repliesApplied
2/8net: ethtool: dynamically allocate full req size reqnet/ethtool/netlink.c+13 -71 replyApplied
3/8net: ethtool: call .parse_request for SET handlersnet/ethtool/netlink.c+1 -31 replyApplied
4/8net: ethtool: remove the data argument from ethtool_notify()include/linux/netdevice.h net/ethtool/ioctl.c net/ethtool/netlink.c +1 more+23 -181 replyApplied
5/8net: ethtool: copy req_info from SET to NTFnet/ethtool/netlink.c net/ethtool/netlink.h+15 -61 replyApplied
6/8net: ethtool: rss: add notificationsDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink_generated.h +4 more+34 -00 repliesApplied
7/8doc: ethtool: mark ETHTOOL_GRXFHINDIR as reimplementedDocumentation/networking/ethtool-netlink.rst+1 -11 replyApplied
8/8selftests: drv-net: test RSS Netlink notificationstools/testing/selftests/drivers/net/hw/rss_api.py+89 -03 repliesApplied

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchDonald HunterMaxime Chevallier
1/8R-b
2/8R-b T-b
3/8R-b T-b
4/8R-b T-b
5/8R-b T-b
6/8
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/8] net: ethtool: rss: add notifications

Next step on the path to moving RSS config to Netlink. With the refactoring of the driver-facing API for ETHTOOL_GRXFH/ETHTOOL_SRXFH out of the way we can move on to more interesting work.

Add Netlink notifications for changes in RSS configuration.

As a reminder (part) of rss-get was introduced in previous releases when input-xfrm (symmetric hashing) was added. rss-set isn't implemented, yet, but we can implement rss-ntf and hook it into the changes done via the IOCTL path (same as other ethtool-nl notifications do).

Most of the series is concerned with passing arguments to notifications. So far none of the notifications needed to be parametrized, but RSS can have multiple contexts per device, and since GET operates on a single context at a time, the notification needs to also be scoped to a context. Patches 2-5 add support for passing arguments to notifications thru ethtool-nl generic infra.

The notification handling itself is pretty trivial, it's mostly hooking in the right entries into the ethool-nl op tables.

v2:
- [patch 2] fix typo in commit msg
- [patch 5] propagate phy_index already
- [patch 6] fix compilation with ETHTOOL_NETLINK=n
- [patch 8] old patch dropped/applied already patch 9 becomes patch 8
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (8):
netlink: specs: add the multicast group name to spec
net: ethtool: dynamically allocate full req size req
net: ethtool: call .parse_request for SET handlers
net: ethtool: remove the data argument from ethtool_notify()
net: ethtool: copy req_info from SET to NTF
net: ethtool: rss: add notifications
doc: ethtool: mark ETHTOOL_GRXFHINDIR as reimplemented
selftests: drv-net: test RSS Netlink notifications

 Documentation/netlink/specs/ethtool.yaml      | 13 +++
 Documentation/networking/ethtool-netlink.rst  |  3 +-
 include/linux/netdevice.h                     |  5 +-
 include/uapi/linux/ethtool_netlink.h          |  2 -
 .../uapi/linux/ethtool_netlink_generated.h    |  3 +
 net/ethtool/common.h                          |  8 ++
 net/ethtool/netlink.h                         |  4 +
 net/ethtool/ioctl.c                           | 28 +++---
 net/ethtool/netlink.c                         | 47 ++++++----
 net/ethtool/rss.c                             | 11 +++
 .../selftests/drivers/net/hw/rss_api.py       | 89 +++++++++++++++++++
 11 files changed, 180 insertions(+), 33 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/hw/rss_api.py
Signature · 1 line
2.49.0