Skip to content

Kunit to check the longest symbol length

Sergio González Collado stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 3 repliesIn review
  2. v2 posting 1/22 patches 2 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Kunit to check the longest symbol lengtharch/x86/tools/insn_decoder_test.c lib/Kconfig.debug lib/Makefile +1 more+95 -12 replies
2/2x86/tools: Drop duplicate unlikely() definition in insn_decoder_test.carch/x86/tools/insn_decoder_test.c+0 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMartin Rodriguez ReboredoShuah KhanRae MoarDavid Gow
1/2T-b R-b R-b R-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 6.6.y 0/2] Kunit to check the longest symbol length

Hello,

Please consider this series for 6.6.y

This patch series backports two patches that implement a test to verify that a symbol with KSYM_NAME_LEN of 512 can be read.

The first patch implements the test. This commit also includes a fix for the test x86/insn_decoder_test. In the case a symbol exceeds the symbol length limit, an error will happen:

    arch/x86/tools/insn_decoder_test: error: malformed line 1152000:
    tBb_+0xf2>

..which overflowed by 10 characters reading this line:

    ffffffff81458193:   74 3d                   je

ffffffff814581d2 <_RNvXse_NtNtNtCshGpAVYOtgW1_4core4iter8adapters7flattenINtB5_13FlattenCompatINtNtB7_3map3MapNtNtNtBb_3str4iter5CharsNtB1v_17CharEscapeDefaultENtNtBb_4char13EscapeDefaultENtNtBb_3fmt5Debug3fmtBb_+0xf2>

The fix was proposed in [1] and initially mentioned at [2].

The second patch fixes a warning when building with clang because there was a definition of unlikely from compiler.h in tools/include/linux, which conflicted with the one in the instruction decoder selftest.

[1] https://lore.kernel.org/lkml/Y9ES4UKl%[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

---
Changes in v2: sign-off patch 2/2

---
Nathan Chancellor (1):
x86/tools: Drop duplicate unlikely() definition in insn_decoder_test.c

Sergio González Collado (1):
Kunit to check the longest symbol length

 arch/x86/tools/insn_decoder_test.c |  5 +-
 lib/Kconfig.debug                  |  9 ++++
 lib/Makefile                       |  2 +
 lib/longest_symbol_kunit.c         | 82 ++++++++++++++++++++++++++++++
 4 files changed, 95 insertions(+), 3 deletions(-)
 create mode 100644 lib/longest_symbol_kunit.c

base-commit: 6282921b6825fef6a1243e1c80063421d41e2576

Signature · 1 line
2.39.2