Skip to content

HID: uclogic: Add support for XP-PEN Artist 22R Pro

Joshua Goins linux-input lkml 1 version Applied

Status from this message: Queued in hid.git#for-6.17/uclogic, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest1 patch 1 replyApplied

Changes in v4 from the cover letter

- Waited 2 years, but I've been using this driver since then without issue. I also removed the old Reported-By, felt weird keeping those considering the wait between patch versions
- Changed some of the cleanup code as suggested
- Rebased onto v6.9-rc7

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/1HID: uclogic: Add support for XP-PEN Artist 22R Prodrivers/hid/hid-ids.h drivers/hid/hid-uclogic-core.c drivers/hid/hid-uclogic-params.c +3 more+248 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/1] HID: uclogic: Add support for XP-PEN Artist 22R Pro

Adds support for the XP-PEN Artist 22R Pro, including stylus, tablet frame and pen pressure.

The tablet has 20 buttons, but need to be remapped in order since the device reports invalid keycodes. Existing tablet functionality should not be inhibited, as BTN0-8 is still used.

New initialization functions are added since the device differs slightly from other UGEE v2 devices.

---

v4 changes:
- Waited 2 years, but I've been using this driver since then without issue. I also removed the old Reported-By, felt weird keeping those considering the wait between patch versions
- Changed some of the cleanup code as suggested
- Rebased onto v6.9-rc7
v3 changes:
- Removed duplicate frame initialization code, overriding the num of frame
buttons instead.
- Removed unnessecary key > 0 check.
- Renamed init function to something more specific to the device.
- Cherry-picked probe magic data patch.
- Rebased onto 6.2-rc6
v2 changes:
- rewrote initialization code to be more concise, and less error-prone, thanks
Dan Carpenter & José Expósito for pointers!
- less struct duplication, it now uses compatiable UGEE v2 ones.
- uclogic_extra_input_mapping is now static, thanks José again!
- straightened out dial transformation, now there's just the two cases and
they're decimal.
- fixed the patch formatting, it should be easier to apply now.
- rebased onto 6.2-rc2

Joshua Goins (1):
HID: uclogic: Add support for XP-PEN Artist 22R Pro

 drivers/hid/hid-ids.h            |   1 +
 drivers/hid/hid-uclogic-core.c   |  66 +++++++++++++++-
 drivers/hid/hid-uclogic-params.c | 132 +++++++++++++++++++++++++++++++
 drivers/hid/hid-uclogic-params.h |   5 ++
 drivers/hid/hid-uclogic-rdesc.c  |  44 +++++++++++
 drivers/hid/hid-uclogic-rdesc.h  |   4 +
 6 files changed, 248 insertions(+), 4 deletions(-)
Signature · 1 line
2.49.0