Skip to content

kconfig: improve gconfig

Masahiro Yamada linux-kbuild 3 versions – Applied

Status from this message: I applied this patch to the gconfig-v2 patches.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 3 repliesApplied
  2. v29 patches 8 repliesSuperseded
  3. v166 patches 37 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/1kconfig: gconf: preserve menu selection when switching view modescripts/kconfig/gconf.c+74 -80 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRandy Dunlap
SeriesA-b T-b A-b T-b
1/1

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [v3 PATCH 0/1] kconfig: improve gconfig

This replaces just one patch in the previous submission.

"kconfig: gconf: preserve menu selection when switching view mode"

There was a corner case where the menu selection was not preserved when switching to Split view.

[Test Case]

[1] Choose Full view (default)
[2] Select "64-bit kernel"
[3] Choose Split view

In v2, the selection of "64-bit kernel" was not preserved.

This has been fixed in v3. The remaining parts are the same.

In case you are interested, I pushed the entire patchset to:

git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git gconfig-v3

The code diff between v2 and v3 is very small, just as follows:

scripts/kconfig/gconf.c +3 -7
index e43d83dcdfb8..6edead20c3c9 100644
@@ -281,13 +281,9 @@ static void set_view_mode(enum view_mode mode)
                gtk_widget_set_sensitive(single_btn, FALSE);
                break;
        case SPLIT_VIEW:
-               browsed = NULL;
-               if (selected) {
-                       if (selected->type == M_MENU)
-                               browsed = selected;
-                       else
-                               browsed = menu_get_parent_menu(selected);
-               }
+               browsed = selected;
+               while (browsed && !(browsed->flags & MENU_ROOT))
+                       browsed = browsed->parent;
                gtk_tree_store_clear(tree1);
                display_tree(tree1, &rootmenu);
                gtk_tree_view_expand_all(GTK_TREE_VIEW(tree1_w));

Masahiro Yamada (1):
kconfig: gconf: preserve menu selection when switching view mode

 scripts/kconfig/gconf.c | 82 +++++++++++++++++++++++++++++++++++++----
 1 file changed, 74 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0