kconfig: improve gconfig
Status from this message: I applied this patch to the gconfig-v2 patches.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest1 patch 3 repliesApplied
- v29 patches 8 repliesSuperseded
- v166 patches 37 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | kconfig: gconf: preserve menu selection when switching view modescripts/ | +74 | 0 replies |
Reviews trailers per patch
The patch has no Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Randy Dunlap |
|---|---|
| Series | A-b T-b A-b T-b |
| 1/1 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [v3 PATCH 0/1] kconfig: improve gconfig
This replaces just one patch in the previous submission.
"kconfig: gconf: preserve menu selection when switching view mode"
There was a corner case where the menu selection was not preserved when switching to Split view.
[Test Case]
[1] Choose Full view (default)
[2] Select "64-bit kernel"
[3] Choose Split view
In v2, the selection of "64-bit kernel" was not preserved.
This has been fixed in v3. The remaining parts are the same.
In case you are interested, I pushed the entire patchset to:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git gconfig-v3
The code diff between v2 and v3 is very small, just as follows:
scripts/kconfig/gconf.c +3 -7
@@ -281,13 +281,9 @@ static void set_view_mode(enum view_mode mode)gtk_widget_set_sensitive (single_btn, FALSE);break ;case SPLIT_VIEW : - browsed =NULL ; -if (selected) { -if (selected->type ==M_MENU ) - browsed = selected; -else - browsed =menu_get_parent_menu (selected); - } + browsed = selected; +while (browsed && !(browsed->flags &MENU_ROOT )) + browsed = browsed->parent;gtk_tree_store_clear (tree1);display_tree (tree1, &rootmenu);gtk_tree_view_expand_all (GTK_TREE_VIEW (tree1_w));
Masahiro Yamada (1):
kconfig: gconf: preserve menu selection when switching view mode
scripts/kconfig/gconf.c | 82 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 74 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0