Skip to content

netlink: specs: enforce strict naming of properties

Jakub Kicinski linux-kselftest mptcp netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 21 repliesApplied 10/10

Patches in v1 All 10 applied

#Subject and filesSizeRepliesApplied
1/10netlink: specs: nfsd: replace underscores with dashes in namesDocumentation/netlink/specs/nfsd.yaml+2 -23 repliesApplied
2/10netlink: specs: fou: replace underscores with dashes in namesDocumentation/netlink/specs/fou.yaml+18 -181 replyApplied
3/10netlink: specs: ethtool: replace underscores with dashes in namesDocumentation/netlink/specs/ethtool.yaml tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py+4 -43 repliesApplied
4/10netlink: specs: dpll: replace underscores with dashes in namesDocumentation/netlink/specs/dpll.yaml+1 -12 repliesApplied
5/10netlink: specs: devlink: replace underscores with dashes in namesDocumentation/netlink/specs/devlink.yaml+4 -42 repliesApplied
6/10netlink: specs: ovs_flow: replace underscores with dashes in namesDocumentation/netlink/specs/ovs_flow.yaml+3 -33 repliesApplied
7/10netlink: specs: mptcp: replace underscores with dashes in namesDocumentation/netlink/specs/mptcp_pm.yaml include/uapi/linux/mptcp_pm.h+7 -73 repliesApplied
8/10netlink: specs: rt-link: replace underscores with dashes in namesDocumentation/netlink/specs/rt-link.yaml+2 -22 repliesApplied
9/10netlink: specs: tc: replace underscores with dashes in namesDocumentation/netlink/specs/tc.yaml+2 -21 replyApplied
10/10netlink: specs: enforce strict naming of propertiesDocumentation/netlink/genetlink-legacy.yaml Documentation/netlink/genetlink.yaml Documentation/netlink/netlink-raw.yaml+31 -191 replyApplied

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchJacob KellerVadim FedorenkoKory MaincentDavide CarattiDonald HunterIlya MaximetsEelco ChaudronJeff LaytonMatthieu Baerts (NGI0)Chuck Lever
1/10R-b R-b R-b
2/10R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b R-b
7/10R-b R-b R-b
8/10R-b R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v1 thread

Cover letter [PATCH net 00/10] netlink: specs: enforce strict naming of properties

I got annoyed once again by the name properties in the ethtool spec which use underscore instead of dash. I previously assumed that there is a lot of such properties in the specs so fixing them now would be near impossible. On a closer look, however, I only found 22 (rough grep suggests we have ~4.8k names in the specs, so bad ones are just 0.46%).

Add a regex to the JSON schema to enforce the naming, fix the few bad names. I was hoping we could start enforcing this from newer families, but there's no correlation between the protocol and the number of errors. If anything classic netlink has more recently added specs so it has fewer errors.

The regex is just for name properties which will end up visible to the user (in Python or YNL CLI). I left the c-name properties alone, those don't matter as much. C codegen rewrites them, anyway.

I'm not updating the spec for genetlink-c. Looks like it has no users, new families use genetlink, all old ones need genetlink-legacy. If these patches are merged I will remove genetlink-c completely in net-next.

Jakub Kicinski (10):
netlink: specs: nfsd: replace underscores with dashes in names
netlink: specs: fou: replace underscores with dashes in names
netlink: specs: ethtool: replace underscores with dashes in names
netlink: specs: dpll: replace underscores with dashes in names
netlink: specs: devlink: replace underscores with dashes in names
netlink: specs: ovs_flow: replace underscores with dashes in names
netlink: specs: mptcp: replace underscores with dashes in names
netlink: specs: rt-link: replace underscores with dashes in names
netlink: specs: tc: replace underscores with dashes in names
netlink: specs: enforce strict naming of properties

 Documentation/netlink/genetlink-legacy.yaml   | 15 ++++----
 Documentation/netlink/genetlink.yaml          | 17 +++++----
 Documentation/netlink/netlink-raw.yaml        | 18 ++++++----
 Documentation/netlink/specs/devlink.yaml      |  8 ++---
 Documentation/netlink/specs/dpll.yaml         |  2 +-
 Documentation/netlink/specs/ethtool.yaml      |  6 ++--
 Documentation/netlink/specs/fou.yaml          | 36 +++++++++----------
 Documentation/netlink/specs/mptcp_pm.yaml     |  8 ++---
 Documentation/netlink/specs/nfsd.yaml         |  4 +--
 Documentation/netlink/specs/ovs_flow.yaml     |  6 ++--
 Documentation/netlink/specs/rt-link.yaml      |  4 +--
 Documentation/netlink/specs/tc.yaml           |  4 +--
 include/uapi/linux/mptcp_pm.h                 |  6 ++--
 .../drivers/net/hw/rss_input_xfrm.py          |  2 +-
 14 files changed, 74 insertions(+), 62 deletions(-)
Signature · 1 line
2.49.0