netlink: specs: enforce strict naming of properties
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 10 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | netlink: specs: nfsd: replace underscores with dashes in namesDocumentation/ | +2 | 3 replies | Applied |
| 2/10 | netlink: specs: fou: replace underscores with dashes in namesDocumentation/ | +18 | 1 reply | Applied |
| 3/10 | netlink: specs: ethtool: replace underscores with dashes in namesDocumentation/ tools/ | +4 | 3 replies | Applied |
| 4/10 | netlink: specs: dpll: replace underscores with dashes in namesDocumentation/ | +1 | 2 replies | Applied |
| 5/10 | netlink: specs: devlink: replace underscores with dashes in namesDocumentation/ | +4 | 2 replies | Applied |
| 6/10 | netlink: specs: ovs_flow: replace underscores with dashes in namesDocumentation/ | +3 | 3 replies | Applied |
| 7/10 | netlink: specs: mptcp: replace underscores with dashes in namesDocumentation/ include/ | +7 | 3 replies | Applied |
| 8/10 | netlink: specs: rt-link: replace underscores with dashes in namesDocumentation/ | +2 | 2 replies | Applied |
| 9/10 | netlink: specs: tc: replace underscores with dashes in namesDocumentation/ | +2 | 1 reply | Applied |
| 10/10 | netlink: specs: enforce strict naming of propertiesDocumentation/ Documentation/ Documentation/ | +31 | 1 reply | Applied |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Jacob Keller | Vadim Fedorenko | Kory Maincent | Davide Caratti | Donald Hunter | Ilya Maximets | Eelco Chaudron | Jeff Layton | Matthieu Baerts (NGI0) | Chuck Lever |
|---|---|---|---|---|---|---|---|---|---|---|
| 1/10 | R-b | R-b | R-b | |||||||
| 2/10 | R-b | |||||||||
| 3/10 | R-b | R-b | ||||||||
| 4/10 | R-b | R-b | ||||||||
| 5/10 | R-b | R-b | ||||||||
| 6/10 | R-b | R-b | R-b | |||||||
| 7/10 | R-b | R-b | R-b | |||||||
| 8/10 | R-b | R-b | ||||||||
| 9/10 | R-b | |||||||||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.
Cover letter [PATCH net 00/10] netlink: specs: enforce strict naming of properties
I got annoyed once again by the name properties in the ethtool spec which use underscore instead of dash. I previously assumed that there is a lot of such properties in the specs so fixing them now would be near impossible. On a closer look, however, I only found 22 (rough grep suggests we have ~4.8k names in the specs, so bad ones are just 0.46%).
Add a regex to the JSON schema to enforce the naming, fix the few bad names. I was hoping we could start enforcing this from newer families, but there's no correlation between the protocol and the number of errors. If anything classic netlink has more recently added specs so it has fewer errors.
The regex is just for name properties which will end up visible to the user (in Python or YNL CLI). I left the c-name properties alone, those don't matter as much. C codegen rewrites them, anyway.
I'm not updating the spec for genetlink-c. Looks like it has no users, new families use genetlink, all old ones need genetlink-legacy. If these patches are merged I will remove genetlink-c completely in net-next.
Jakub Kicinski (10):
netlink: specs: nfsd: replace underscores with dashes in names
netlink: specs: fou: replace underscores with dashes in names
netlink: specs: ethtool: replace underscores with dashes in names
netlink: specs: dpll: replace underscores with dashes in names
netlink: specs: devlink: replace underscores with dashes in names
netlink: specs: ovs_flow: replace underscores with dashes in names
netlink: specs: mptcp: replace underscores with dashes in names
netlink: specs: rt-link: replace underscores with dashes in names
netlink: specs: tc: replace underscores with dashes in names
netlink: specs: enforce strict naming of properties
Documentation/netlink/genetlink-legacy.yaml | 15 ++++---- Documentation/netlink/genetlink.yaml | 17 +++++---- Documentation/netlink/netlink-raw.yaml | 18 ++++++---- Documentation/netlink/specs/devlink.yaml | 8 ++--- Documentation/netlink/specs/dpll.yaml | 2 +- Documentation/netlink/specs/ethtool.yaml | 6 ++-- Documentation/netlink/specs/fou.yaml | 36 +++++++++---------- Documentation/netlink/specs/mptcp_pm.yaml | 8 ++--- Documentation/netlink/specs/nfsd.yaml | 4 +-- Documentation/netlink/specs/ovs_flow.yaml | 6 ++-- Documentation/netlink/specs/rt-link.yaml | 4 +-- Documentation/netlink/specs/tc.yaml | 4 +-- include/uapi/linux/mptcp_pm.h | 6 ++-- .../drivers/net/hw/rss_input_xfrm.py | 2 +- 14 files changed, 74 insertions(+), 62 deletions(-)
Signature · 1 line
2.49.0